From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Wolfram Sang <wsa@the-dreams.de>, linux-i2c@vger.kernel.org
Cc: linux-sh@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
Simon Horman <horms@verge.net.au>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-pm@vger.kernel.org
Subject: Re: [RFC 3/3] i2c: rcar: disable PM in multi-master mode
Date: Wed, 16 Dec 2015 21:48:24 +0300 [thread overview]
Message-ID: <5671B1F8.8070103@cogentembedded.com> (raw)
In-Reply-To: <1450291460-10514-4-git-send-email-wsa@the-dreams.de>
Hello.
On 12/16/2015 09:44 PM, Wolfram Sang wrote:
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> In multi master mode, the IP core needs to be always active for
> arbitration reasons. Get the config from DT and set up PM depending on
> the config.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> drivers/i2c/busses/i2c-rcar.c | 17 ++++++++++++++---
> 1 file changed, 14 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-rcar.c b/drivers/i2c/busses/i2c-rcar.c
> index 79fd2aab8fa087..7c523dcaee3e48 100644
> --- a/drivers/i2c/busses/i2c-rcar.c
> +++ b/drivers/i2c/busses/i2c-rcar.c
[...]
> @@ -630,7 +633,13 @@ static int rcar_i2c_probe(struct platform_device *pdev)
> goto out_pm_put;
>
> rcar_i2c_init(priv);
> - pm_runtime_put(dev);
> +
> + /* Don't suspend when multi-master to keep arbitration working */
> + if (of_get_property(dev->of_node, "multi-master", NULL))
of_property_read_bool(), perhaps?
[...]
MBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Wolfram Sang <wsa@the-dreams.de>, linux-i2c@vger.kernel.org
Cc: linux-sh@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
Simon Horman <horms@verge.net.au>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-pm@vger.kernel.org
Subject: Re: [RFC 3/3] i2c: rcar: disable PM in multi-master mode
Date: Wed, 16 Dec 2015 18:48:24 +0000 [thread overview]
Message-ID: <5671B1F8.8070103@cogentembedded.com> (raw)
In-Reply-To: <1450291460-10514-4-git-send-email-wsa@the-dreams.de>
Hello.
On 12/16/2015 09:44 PM, Wolfram Sang wrote:
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> In multi master mode, the IP core needs to be always active for
> arbitration reasons. Get the config from DT and set up PM depending on
> the config.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> drivers/i2c/busses/i2c-rcar.c | 17 ++++++++++++++---
> 1 file changed, 14 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-rcar.c b/drivers/i2c/busses/i2c-rcar.c
> index 79fd2aab8fa087..7c523dcaee3e48 100644
> --- a/drivers/i2c/busses/i2c-rcar.c
> +++ b/drivers/i2c/busses/i2c-rcar.c
[...]
> @@ -630,7 +633,13 @@ static int rcar_i2c_probe(struct platform_device *pdev)
> goto out_pm_put;
>
> rcar_i2c_init(priv);
> - pm_runtime_put(dev);
> +
> + /* Don't suspend when multi-master to keep arbitration working */
> + if (of_get_property(dev->of_node, "multi-master", NULL))
of_property_read_bool(), perhaps?
[...]
MBR, Sergei
next prev parent reply other threads:[~2015-12-16 18:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-16 18:44 [RFC 0/3] i2c: rcar: adapt PM usage to multi master case Wolfram Sang
2015-12-16 18:44 ` Wolfram Sang
2015-12-16 18:44 ` [RFC 1/3] i2c: document binding for multi-master case Wolfram Sang
2015-12-16 18:44 ` Wolfram Sang
2015-12-19 4:18 ` Rob Herring
2015-12-19 4:18 ` Rob Herring
2015-12-16 18:44 ` [RFC 2/3] i2c: rcar: remove macros dealing with flags Wolfram Sang
2015-12-16 18:44 ` Wolfram Sang
2015-12-16 18:44 ` [RFC 3/3] i2c: rcar: disable PM in multi-master mode Wolfram Sang
2015-12-16 18:44 ` Wolfram Sang
2015-12-16 18:48 ` Sergei Shtylyov [this message]
2015-12-16 18:48 ` Sergei Shtylyov
2015-12-16 21:26 ` [RFC 0/3] i2c: rcar: adapt PM usage to multi master case Geert Uytterhoeven
2015-12-16 21:26 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5671B1F8.8070103@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.