From: Suravee Suthikulanit <suravee.suthikulpanit@amd.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org
Subject: Re: [PATCH] iommu/amd: Assign default IOMMU when there is only one IOMMU
Date: Wed, 16 Dec 2015 21:17:57 -0600 [thread overview]
Message-ID: <56722965.2010806@amd.com> (raw)
In-Reply-To: <20151214150805.GE11292@8bytes.org>
On 12/14/2015 9:08 AM, Joerg Roedel wrote:
> On Fri, Dec 11, 2015 at 04:54:38PM -0600, Suravee Suthikulpanit wrote:
>> Current driver makes assumption that device with devid zero is always
>> included in the range of devices to be managed by IOMMU. However,
>> certain FW does not include devid zero in IVRS table.
>> This has caused IOMMU perf driver to fail to initialize.
>
> Hmm, this is a firmware bug. Is this bug seen in any systems that are
> for sale?
>
>> This patch implements a workaround for this case by always assign
>> devid zero to be handled by the first IOMMU.
>
> Otherwise its better to fix the firmware than to add workarounds.
>
>
> Joerg
>
Please ignore this patch. There are more stuff that I am planning to
fix, and I am reworking them into V2. I'll send this out soon.
Suravee
WARNING: multiple messages have this Message-ID (diff)
From: Suravee Suthikulanit <suravee.suthikulpanit@amd.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: <linux-kernel@vger.kernel.org>, <iommu@lists.linux-foundation.org>
Subject: Re: [PATCH] iommu/amd: Assign default IOMMU when there is only one IOMMU
Date: Wed, 16 Dec 2015 21:17:57 -0600 [thread overview]
Message-ID: <56722965.2010806@amd.com> (raw)
In-Reply-To: <20151214150805.GE11292@8bytes.org>
On 12/14/2015 9:08 AM, Joerg Roedel wrote:
> On Fri, Dec 11, 2015 at 04:54:38PM -0600, Suravee Suthikulpanit wrote:
>> Current driver makes assumption that device with devid zero is always
>> included in the range of devices to be managed by IOMMU. However,
>> certain FW does not include devid zero in IVRS table.
>> This has caused IOMMU perf driver to fail to initialize.
>
> Hmm, this is a firmware bug. Is this bug seen in any systems that are
> for sale?
>
>> This patch implements a workaround for this case by always assign
>> devid zero to be handled by the first IOMMU.
>
> Otherwise its better to fix the firmware than to add workarounds.
>
>
> Joerg
>
Please ignore this patch. There are more stuff that I am planning to
fix, and I am reworking them into V2. I'll send this out soon.
Suravee
next prev parent reply other threads:[~2015-12-17 3:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 22:54 [PATCH] iommu/amd: Assign default IOMMU when there is only one IOMMU Suravee Suthikulpanit
2015-12-11 22:54 ` Suravee Suthikulpanit
2015-12-14 15:08 ` Joerg Roedel
2015-12-16 6:20 ` Suravee Suthikulpanit
2015-12-16 6:20 ` Suravee Suthikulpanit
2015-12-17 3:17 ` Suravee Suthikulanit [this message]
2015-12-17 3:17 ` Suravee Suthikulanit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56722965.2010806@amd.com \
--to=suravee.suthikulpanit@amd.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.