All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ilya Maximets <i.maximets@samsung.com>
To: "Wang, Zhihong" <zhihong.wang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "s.dyasly@samsung.com" <s.dyasly@samsung.com>
Subject: Re: [PATCH] Unlink existing unused sockets at start up
Date: Fri, 18 Dec 2015 09:17:56 +0300	[thread overview]
Message-ID: <5673A514.10004@samsung.com> (raw)
In-Reply-To: <8F6C2BD409508844A0EFC19955BE0941856F7D@SHSMSX103.ccr.corp.intel.com>

On 18.12.2015 05:39, Wang, Zhihong wrote:

> Yes ideally the underneath lib shouldn't meddle with the recovery logic.
> But I do think we should at least put a warning in the lib function said the app should make the path available. This is another topic though :-)
> Like we did in memcpy:
> /**
>  * Copy 16 bytes from one location to another,
>  * locations should not overlap.
>  */
> 

Isn't it enough to have an error in the log?

lib/librte_vhost/vhost_user/vhost-net-user.c:130:
RTE_LOG(ERR, VHOST_CONFIG, "fail to bind fd:%d, remove file:%s and try again.\n",

Best regards, Ilya Maximets.

  reply	other threads:[~2015-12-18  6:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-17  4:21 [PATCH] Unlink existing unused sockets at start up Zhihong Wang
2015-12-17 11:47 ` Ilya Maximets
2015-12-18  2:39   ` Wang, Zhihong
2015-12-18  6:17     ` Ilya Maximets [this message]
2015-12-21  3:31       ` Wang, Zhihong
2015-12-17 11:59 ` Yuanhan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5673A514.10004@samsung.com \
    --to=i.maximets@samsung.com \
    --cc=dev@dpdk.org \
    --cc=s.dyasly@samsung.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.