* [U-Boot] Asymmetry in setting of "fileaddr" variable
@ 2015-12-18 12:27 David Müller (ELSOFT AG)
2016-01-08 8:27 ` [U-Boot] [PATCH] fs: handle the fileaddr variable in the same way as in the network case David Müller
2016-01-08 8:39 ` [U-Boot] [PATCH v2] " David Müller
0 siblings, 2 replies; 4+ messages in thread
From: David Müller (ELSOFT AG) @ 2015-12-18 12:27 UTC (permalink / raw)
To: u-boot
Hello
In net/net.c::net_loop(), the variables "fileaddr" and "filesize" are
both set in case of a successful transfer.
In fs/fs.c::do_load(), just the variable "filesize" is set in case of
success.
Is this asymmetry intentional or a mistake?
Dave
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] fs: handle the fileaddr variable in the same way as in the network case
2015-12-18 12:27 [U-Boot] Asymmetry in setting of "fileaddr" variable David Müller (ELSOFT AG)
@ 2016-01-08 8:27 ` David Müller
2016-01-08 8:39 ` [U-Boot] [PATCH v2] " David Müller
1 sibling, 0 replies; 4+ messages in thread
From: David Müller @ 2016-01-08 8:27 UTC (permalink / raw)
To: u-boot
---
fs/fs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/fs.c b/fs/fs.c
index b2d6a53..a2f1bf5 100644
--- a/fs/fs.c
+++ b/fs/fs.c
@@ -427,6 +427,7 @@ int do_load(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[],
}
puts("\n");
+ setenv_hex("fileaddr", addr);
setenv_hex("filesize", len_read);
return 0;
--
1.8.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [U-Boot] [PATCH v2] fs: handle the fileaddr variable in the same way as in the network case
2015-12-18 12:27 [U-Boot] Asymmetry in setting of "fileaddr" variable David Müller (ELSOFT AG)
2016-01-08 8:27 ` [U-Boot] [PATCH] fs: handle the fileaddr variable in the same way as in the network case David Müller
@ 2016-01-08 8:39 ` David Müller
2016-01-09 3:35 ` [U-Boot] [U-Boot, " Tom Rini
1 sibling, 1 reply; 4+ messages in thread
From: David Müller @ 2016-01-08 8:39 UTC (permalink / raw)
To: u-boot
Signed-off-by: David M?ller <d.mueller@elsoft.ch>
---
fs/fs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/fs.c b/fs/fs.c
index b2d6a53..a2f1bf5 100644
--- a/fs/fs.c
+++ b/fs/fs.c
@@ -427,6 +427,7 @@ int do_load(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[],
}
puts("\n");
+ setenv_hex("fileaddr", addr);
setenv_hex("filesize", len_read);
return 0;
--
1.8.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-01-09 3:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-18 12:27 [U-Boot] Asymmetry in setting of "fileaddr" variable David Müller (ELSOFT AG)
2016-01-08 8:27 ` [U-Boot] [PATCH] fs: handle the fileaddr variable in the same way as in the network case David Müller
2016-01-08 8:39 ` [U-Boot] [PATCH v2] " David Müller
2016-01-09 3:35 ` [U-Boot] [U-Boot, " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.