All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	myungjoo.ham@samsung.com, Chanwoo Choi <cw00.choi@samsung.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-sh@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v3] extcon: add Maxim MAX3355 driver
Date: Fri, 18 Dec 2015 13:45:05 +0000	[thread overview]
Message-ID: <56740DE1.8040301@cogentembedded.com> (raw)
In-Reply-To: <56735125.1040304@samsung.com>

Hello.

On 12/18/2015 3:19 AM, Krzysztof Kozlowski wrote:

[...]

>>> Please pass the source through recent coccicheck and fix the findings.
>>
>>     Has it been included in the kernel source somewhere already?
>
> The rules detecting the unnecessary owner should be there for some time
> (sice 4.2 or 4.1?). The coccicheck is in kernel - scripts/coccicheck. It

    Found it already.

> uses coccinelle/spatch.

    Installed it.

> You can run it just like other code-checker
> tools - sparse and smatch.

    I tried but couldn't figure out how to confine 'make coccicheck'only to 
the files I need.

> Best regards,
> Krzysztof

MBR, Sergei


WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	myungjoo.ham@samsung.com, Chanwoo Choi <cw00.choi@samsung.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-sh@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v3] extcon: add Maxim MAX3355 driver
Date: Fri, 18 Dec 2015 16:45:05 +0300	[thread overview]
Message-ID: <56740DE1.8040301@cogentembedded.com> (raw)
In-Reply-To: <56735125.1040304@samsung.com>

Hello.

On 12/18/2015 3:19 AM, Krzysztof Kozlowski wrote:

[...]

>>> Please pass the source through recent coccicheck and fix the findings.
>>
>>     Has it been included in the kernel source somewhere already?
>
> The rules detecting the unnecessary owner should be there for some time
> (sice 4.2 or 4.1?). The coccicheck is in kernel - scripts/coccicheck. It

    Found it already.

> uses coccinelle/spatch.

    Installed it.

> You can run it just like other code-checker
> tools - sparse and smatch.

    I tried but couldn't figure out how to confine 'make coccicheck'only to 
the files I need.

> Best regards,
> Krzysztof

MBR, Sergei


  reply	other threads:[~2015-12-18 13:45 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-16 18:07 [PATCH v3] extcon: add Maxim MAX3355 driver Sergei Shtylyov
2015-12-16 18:07 ` Sergei Shtylyov
2015-12-17  0:53 ` Krzysztof Kozlowski
2015-12-17  0:53   ` Krzysztof Kozlowski
2015-12-17 14:36   ` Sergei Shtylyov
2015-12-17 14:36     ` Sergei Shtylyov
     [not found]     ` <5672C884.3000603-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2015-12-18  0:19       ` Krzysztof Kozlowski
2015-12-18  0:19         ` Krzysztof Kozlowski
2015-12-18  0:19         ` Krzysztof Kozlowski
2015-12-18 13:45         ` Sergei Shtylyov [this message]
2015-12-18 13:45           ` Sergei Shtylyov
     [not found] ` <2473780.4IzuWX8hE2-gHKXc3Y1Z8zGSmamagVegGFoWSdPRAKMAL8bYrjMMd8@public.gmane.org>
2015-12-17  2:16   ` Chanwoo Choi
2015-12-17  2:16     ` Chanwoo Choi
2015-12-17  2:16     ` Chanwoo Choi
     [not found]     ` <56721AFE.9020103-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-12-17  2:34       ` Chanwoo Choi
2015-12-17  2:34         ` Chanwoo Choi
2015-12-17  2:34         ` Chanwoo Choi
2015-12-17 21:20         ` Sergei Shtylyov
2015-12-17 21:20           ` Sergei Shtylyov
     [not found]           ` <56732719.7020301-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2015-12-18  1:04             ` Chanwoo Choi
2015-12-18  1:04               ` Chanwoo Choi
2015-12-18  1:04               ` Chanwoo Choi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56740DE1.8040301@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=k.kozlowski@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=myungjoo.ham@samsung.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.