From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Stefan Agner <stefan@agner.ch>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH libdrm] tests: remove missleading comments
Date: Fri, 18 Dec 2015 08:54:37 -0800 [thread overview]
Message-ID: <56743A4D.3080302@virtuousgeek.org> (raw)
In-Reply-To: <1450426489-5630-1-git-send-email-stefan@agner.ch>
On 12/18/2015 12:14 AM, Stefan Agner wrote:
> The comment has been copied from modetest and is not applicable
> for vbltest.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> tests/vbltest/vbltest.c | 15 +--------------
> 1 file changed, 1 insertion(+), 14 deletions(-)
>
> diff --git a/tests/vbltest/vbltest.c b/tests/vbltest/vbltest.c
> index 531196c..5c61b43 100644
> --- a/tests/vbltest/vbltest.c
> +++ b/tests/vbltest/vbltest.c
> @@ -1,5 +1,5 @@
> /*
> - * DRM based mode setting test program
> + * DRM based vblank test program
> * Copyright 2008 Tungsten Graphics
> * Jakob Bornecrantz <jakob@tungstengraphics.com>
> * Copyright 2008 Intel Corporation
> @@ -24,19 +24,6 @@
> * IN THE SOFTWARE.
> */
>
> -/*
> - * This fairly simple test program dumps output in a similar format to the
> - * "xrandr" tool everyone knows & loves. It's necessarily slightly different
> - * since the kernel separates outputs into encoder and connector structures,
> - * each with their own unique ID. The program also allows test testing of the
> - * memory management and mode setting APIs by allowing the user to specify a
> - * connector and mode to use for mode setting. If all works as expected, a
> - * blue background should be painted on the monitor attached to the specified
> - * connector after the selected mode is set.
> - *
> - * TODO: use cairo to write the mode info on the selected output once
> - * the mode has been programmed, along with possible test patterns.
> - */
> #ifdef HAVE_CONFIG_H
> #include "config.h"
> #endif
Yep, thanks.
Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-12-18 16:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 8:14 [PATCH libdrm] tests: remove missleading comments Stefan Agner
2015-12-18 16:54 ` Jesse Barnes [this message]
2015-12-18 17:40 ` Emil Velikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56743A4D.3080302@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.