[PATCH libdrm] tests: remove missleading comments

[PATCH libdrm] tests: remove missleading comments

[Stefan Agner]

The comment has been copied from modetest and is not applicable
for vbltest.

Signed-off-by: Stefan Agner <stefan@agner.ch>
---
 tests/vbltest/vbltest.c | 15 +--------------
 1 file changed, 1 insertion(+), 14 deletions(-)

diff --git a/tests/vbltest/vbltest.c b/tests/vbltest/vbltest.c
index 531196c..5c61b43 100644
--- a/tests/vbltest/vbltest.c
+++ b/tests/vbltest/vbltest.c
@@ -1,5 +1,5 @@
 /*
- * DRM based mode setting test program
+ * DRM based vblank test program
  * Copyright 2008 Tungsten Graphics
  *   Jakob Bornecrantz <jakob@tungstengraphics.com>
  * Copyright 2008 Intel Corporation
@@ -24,19 +24,6 @@
  * IN THE SOFTWARE.
  */
 
-/*
- * This fairly simple test program dumps output in a similar format to the
- * "xrandr" tool everyone knows & loves.  It's necessarily slightly different
- * since the kernel separates outputs into encoder and connector structures,
- * each with their own unique ID.  The program also allows test testing of the
- * memory management and mode setting APIs by allowing the user to specify a
- * connector and mode to use for mode setting.  If all works as expected, a
- * blue background should be painted on the monitor attached to the specified
- * connector after the selected mode is set.
- *
- * TODO: use cairo to write the mode info on the selected output once
- *       the mode has been programmed, along with possible test patterns.
- */
 #ifdef HAVE_CONFIG_H
 #include "config.h"
 #endif
-- 
2.6.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH libdrm] tests: remove missleading comments

[Jesse Barnes]

On 12/18/2015 12:14 AM, Stefan Agner wrote:
> The comment has been copied from modetest and is not applicable
> for vbltest.
> 
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
>  tests/vbltest/vbltest.c | 15 +--------------
>  1 file changed, 1 insertion(+), 14 deletions(-)
> 
> diff --git a/tests/vbltest/vbltest.c b/tests/vbltest/vbltest.c
> index 531196c..5c61b43 100644
> --- a/tests/vbltest/vbltest.c
> +++ b/tests/vbltest/vbltest.c
> @@ -1,5 +1,5 @@
>  /*
> - * DRM based mode setting test program
> + * DRM based vblank test program
>   * Copyright 2008 Tungsten Graphics
>   *   Jakob Bornecrantz <jakob@tungstengraphics.com>
>   * Copyright 2008 Intel Corporation
> @@ -24,19 +24,6 @@
>   * IN THE SOFTWARE.
>   */
>  
> -/*
> - * This fairly simple test program dumps output in a similar format to the
> - * "xrandr" tool everyone knows & loves.  It's necessarily slightly different
> - * since the kernel separates outputs into encoder and connector structures,
> - * each with their own unique ID.  The program also allows test testing of the
> - * memory management and mode setting APIs by allowing the user to specify a
> - * connector and mode to use for mode setting.  If all works as expected, a
> - * blue background should be painted on the monitor attached to the specified
> - * connector after the selected mode is set.
> - *
> - * TODO: use cairo to write the mode info on the selected output once
> - *       the mode has been programmed, along with possible test patterns.
> - */
>  #ifdef HAVE_CONFIG_H
>  #include "config.h"
>  #endif

Yep, thanks.

Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH libdrm] tests: remove missleading comments

[Emil Velikov]

On 18 December 2015 at 16:54, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> On 12/18/2015 12:14 AM, Stefan Agner wrote:
>> The comment has been copied from modetest and is not applicable
>> for vbltest.
>>
>> Signed-off-by: Stefan Agner <stefan@agner.ch>
>> ---
>>  tests/vbltest/vbltest.c | 15 +--------------
>>  1 file changed, 1 insertion(+), 14 deletions(-)
>>
>> diff --git a/tests/vbltest/vbltest.c b/tests/vbltest/vbltest.c
>> index 531196c..5c61b43 100644
>> --- a/tests/vbltest/vbltest.c
>> +++ b/tests/vbltest/vbltest.c
>> @@ -1,5 +1,5 @@
>>  /*
>> - * DRM based mode setting test program
>> + * DRM based vblank test program
>>   * Copyright 2008 Tungsten Graphics
>>   *   Jakob Bornecrantz <jakob@tungstengraphics.com>
>>   * Copyright 2008 Intel Corporation
>> @@ -24,19 +24,6 @@
>>   * IN THE SOFTWARE.
>>   */
>>
>> -/*
>> - * This fairly simple test program dumps output in a similar format to the
>> - * "xrandr" tool everyone knows & loves.  It's necessarily slightly different
>> - * since the kernel separates outputs into encoder and connector structures,
>> - * each with their own unique ID.  The program also allows test testing of the
>> - * memory management and mode setting APIs by allowing the user to specify a
>> - * connector and mode to use for mode setting.  If all works as expected, a
>> - * blue background should be painted on the monitor attached to the specified
>> - * connector after the selected mode is set.
>> - *
>> - * TODO: use cairo to write the mode info on the selected output once
>> - *       the mode has been programmed, along with possible test patterns.
>> - */
>>  #ifdef HAVE_CONFIG_H
>>  #include "config.h"
>>  #endif
>
> Yep, thanks.
>
> Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
>
Committed to master. Thanks guys.

-Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel