From: Jon Hunter <jonathanh@nvidia.com>
To: Arnd Bergmann <arnd@arndb.de>, linux-arm-kernel@lists.infradead.org
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH v2] serial: 8250: of: Fix the driver and actually compile the 8250_of
Date: Fri, 18 Dec 2015 16:57:32 +0000 [thread overview]
Message-ID: <56743AFC.7000402@nvidia.com> (raw)
In-Reply-To: <3295738.CvTDrXdGbt@wuerfel>
On 18/12/15 13:16, Arnd Bergmann wrote:
> On Friday 18 December 2015 15:00:49 Peter Ujfalusi wrote:
>> The 8250_of never compiled since in the Kconfig we have SERIAL_OF_PLATFORM
>> but in the makefile we expect to have SERIAL_8250_OF...
>>
>> When the 8250_of.c is actually compiled we will have two errors:
>> missing linux/nwpserial.h and 8250/8250.h.
>> Fix those as well at the same time when enable the compilation of the
>> driver.
>>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>> Fixes: afd7f88f1577 ("serial: 8250: move of_serial code to 8250 directory")
>> CC: Arnd Bergmann <arnd@arndb.de>
>>
>
> Thanks for fixing this, and sorry for the mess.
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
Thanks, this fixes booting tegra 32-bit devices on -next.
Acked-by: Jon Hunter <jonathanh@nvidia.com>
Tested-by: Jon Hunter <jonathanh@nvidia.com>
Cheers
Jon
WARNING: multiple messages have this Message-ID (diff)
From: jonathanh@nvidia.com (Jon Hunter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] serial: 8250: of: Fix the driver and actually compile the 8250_of
Date: Fri, 18 Dec 2015 16:57:32 +0000 [thread overview]
Message-ID: <56743AFC.7000402@nvidia.com> (raw)
In-Reply-To: <3295738.CvTDrXdGbt@wuerfel>
On 18/12/15 13:16, Arnd Bergmann wrote:
> On Friday 18 December 2015 15:00:49 Peter Ujfalusi wrote:
>> The 8250_of never compiled since in the Kconfig we have SERIAL_OF_PLATFORM
>> but in the makefile we expect to have SERIAL_8250_OF...
>>
>> When the 8250_of.c is actually compiled we will have two errors:
>> missing linux/nwpserial.h and 8250/8250.h.
>> Fix those as well at the same time when enable the compilation of the
>> driver.
>>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>> Fixes: afd7f88f1577 ("serial: 8250: move of_serial code to 8250 directory")
>> CC: Arnd Bergmann <arnd@arndb.de>
>>
>
> Thanks for fixing this, and sorry for the mess.
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
Thanks, this fixes booting tegra 32-bit devices on -next.
Acked-by: Jon Hunter <jonathanh@nvidia.com>
Tested-by: Jon Hunter <jonathanh@nvidia.com>
Cheers
Jon
WARNING: multiple messages have this Message-ID (diff)
From: Jon Hunter <jonathanh@nvidia.com>
To: Arnd Bergmann <arnd@arndb.de>, <linux-arm-kernel@lists.infradead.org>
Cc: <gregkh@linuxfoundation.org>, <linux-kernel@vger.kernel.org>,
<linux-serial@vger.kernel.org>
Subject: Re: [PATCH v2] serial: 8250: of: Fix the driver and actually compile the 8250_of
Date: Fri, 18 Dec 2015 16:57:32 +0000 [thread overview]
Message-ID: <56743AFC.7000402@nvidia.com> (raw)
In-Reply-To: <3295738.CvTDrXdGbt@wuerfel>
On 18/12/15 13:16, Arnd Bergmann wrote:
> On Friday 18 December 2015 15:00:49 Peter Ujfalusi wrote:
>> The 8250_of never compiled since in the Kconfig we have SERIAL_OF_PLATFORM
>> but in the makefile we expect to have SERIAL_8250_OF...
>>
>> When the 8250_of.c is actually compiled we will have two errors:
>> missing linux/nwpserial.h and 8250/8250.h.
>> Fix those as well at the same time when enable the compilation of the
>> driver.
>>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>> Fixes: afd7f88f1577 ("serial: 8250: move of_serial code to 8250 directory")
>> CC: Arnd Bergmann <arnd@arndb.de>
>>
>
> Thanks for fixing this, and sorry for the mess.
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
Thanks, this fixes booting tegra 32-bit devices on -next.
Acked-by: Jon Hunter <jonathanh@nvidia.com>
Tested-by: Jon Hunter <jonathanh@nvidia.com>
Cheers
Jon
next prev parent reply other threads:[~2015-12-18 16:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 13:00 [PATCH v2] serial: 8250: of: Fix the driver and actually compile the 8250_of Peter Ujfalusi
2015-12-18 13:00 ` Peter Ujfalusi
2015-12-18 13:00 ` Peter Ujfalusi
2015-12-18 13:16 ` Arnd Bergmann
2015-12-18 13:16 ` Arnd Bergmann
2015-12-18 16:57 ` Jon Hunter [this message]
2015-12-18 16:57 ` Jon Hunter
2015-12-18 16:57 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56743AFC.7000402@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.