From: Paolo Bonzini <pbonzini@redhat.com>
To: Cao jin <caoj.fnst@cn.fujitsu.com>, qemu-devel@nongnu.org
Cc: ehabkost@redhat.com, mst@redhat.com, qemu-trivial@nongnu.org,
leon.alrae@imgtec.com, rth@twiddle.net
Subject: Re: [Qemu-trivial] [PATCH 1/5] SH PCI Host: convert to realize()
Date: Fri, 18 Dec 2015 18:59:11 +0100 [thread overview]
Message-ID: <5674496F.4000503@redhat.com> (raw)
In-Reply-To: <1450436632-23980-2-git-send-email-caoj.fnst@cn.fujitsu.com>
Cc: qemu-trivial@nongnu.org
On 18/12/2015 12:03, Cao jin wrote:
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
> hw/sh4/sh_pci.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/hw/sh4/sh_pci.c b/hw/sh4/sh_pci.c
> index a2f6d9e..4509053 100644
> --- a/hw/sh4/sh_pci.c
> +++ b/hw/sh4/sh_pci.c
> @@ -151,12 +151,11 @@ static int sh_pci_device_init(SysBusDevice *dev)
> return 0;
> }
>
> -static int sh_pci_host_init(PCIDevice *d)
> +static void sh_pci_host_realize(PCIDevice *d, Error **errp)
> {
> pci_set_word(d->config + PCI_COMMAND, PCI_COMMAND_WAIT);
> pci_set_word(d->config + PCI_STATUS, PCI_STATUS_CAP_LIST |
> PCI_STATUS_FAST_BACK | PCI_STATUS_DEVSEL_MEDIUM);
> - return 0;
> }
>
> static void sh_pci_host_class_init(ObjectClass *klass, void *data)
> @@ -164,7 +163,7 @@ static void sh_pci_host_class_init(ObjectClass *klass, void *data)
> PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
> DeviceClass *dc = DEVICE_CLASS(klass);
>
> - k->init = sh_pci_host_init;
> + k->realize = sh_pci_host_realize;
> k->vendor_id = PCI_VENDOR_ID_HITACHI;
> k->device_id = PCI_DEVICE_ID_HITACHI_SH7751R;
> /*
>
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Cao jin <caoj.fnst@cn.fujitsu.com>, qemu-devel@nongnu.org
Cc: ehabkost@redhat.com, mst@redhat.com, qemu-trivial@nongnu.org,
leon.alrae@imgtec.com, aurelien@aurel32.net, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH 1/5] SH PCI Host: convert to realize()
Date: Fri, 18 Dec 2015 18:59:11 +0100 [thread overview]
Message-ID: <5674496F.4000503@redhat.com> (raw)
In-Reply-To: <1450436632-23980-2-git-send-email-caoj.fnst@cn.fujitsu.com>
Cc: qemu-trivial@nongnu.org
On 18/12/2015 12:03, Cao jin wrote:
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
> hw/sh4/sh_pci.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/hw/sh4/sh_pci.c b/hw/sh4/sh_pci.c
> index a2f6d9e..4509053 100644
> --- a/hw/sh4/sh_pci.c
> +++ b/hw/sh4/sh_pci.c
> @@ -151,12 +151,11 @@ static int sh_pci_device_init(SysBusDevice *dev)
> return 0;
> }
>
> -static int sh_pci_host_init(PCIDevice *d)
> +static void sh_pci_host_realize(PCIDevice *d, Error **errp)
> {
> pci_set_word(d->config + PCI_COMMAND, PCI_COMMAND_WAIT);
> pci_set_word(d->config + PCI_STATUS, PCI_STATUS_CAP_LIST |
> PCI_STATUS_FAST_BACK | PCI_STATUS_DEVSEL_MEDIUM);
> - return 0;
> }
>
> static void sh_pci_host_class_init(ObjectClass *klass, void *data)
> @@ -164,7 +163,7 @@ static void sh_pci_host_class_init(ObjectClass *klass, void *data)
> PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
> DeviceClass *dc = DEVICE_CLASS(klass);
>
> - k->init = sh_pci_host_init;
> + k->realize = sh_pci_host_realize;
> k->vendor_id = PCI_VENDOR_ID_HITACHI;
> k->device_id = PCI_DEVICE_ID_HITACHI_SH7751R;
> /*
>
next prev parent reply other threads:[~2015-12-18 17:59 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 11:03 [Qemu-devel] [PATCH 0/5] Convert to realize() Cao jin
2015-12-18 11:03 ` [Qemu-devel] [PATCH 1/5] SH PCI Host: convert " Cao jin
2015-12-18 17:59 ` Paolo Bonzini [this message]
2015-12-18 17:59 ` Paolo Bonzini
2016-01-10 18:13 ` [Qemu-trivial] " Michael Tokarev
2016-01-10 18:13 ` [Qemu-devel] " Michael Tokarev
2015-12-18 11:03 ` [Qemu-devel] [PATCH 2/5] igd-passthrough-i440FX: " Cao jin
2015-12-18 18:37 ` Eduardo Habkost
2015-12-18 21:18 ` Markus Armbruster
2015-12-20 11:59 ` Cao jin
2016-01-11 14:32 ` Markus Armbruster
2016-01-12 2:24 ` Cao jin
2015-12-20 11:56 ` Cao jin
2015-12-18 11:03 ` [Qemu-devel] [PATCH 3/5] PXB: " Cao jin
2015-12-18 18:01 ` Paolo Bonzini
2015-12-20 11:38 ` Cao jin
2015-12-21 10:39 ` Cao jin
2015-12-21 15:49 ` Paolo Bonzini
2015-12-22 3:58 ` Cao jin
2015-12-22 7:34 ` Marcel Apfelbaum
2015-12-22 9:16 ` Cao jin
2015-12-22 9:35 ` Marcel Apfelbaum
2015-12-22 9:52 ` Cao jin
2015-12-22 11:40 ` Cao jin
2015-12-20 10:22 ` Marcel Apfelbaum
2015-12-20 10:48 ` Cao jin
2015-12-20 11:21 ` Marcel Apfelbaum
2015-12-21 2:59 ` Cao jin
2015-12-21 10:08 ` Marcel Apfelbaum
2015-12-21 10:19 ` Cao jin
2015-12-18 11:03 ` [Qemu-devel] [PATCH 4/5] gt64120: " Cao jin
2015-12-18 17:59 ` [Qemu-trivial] " Paolo Bonzini
2015-12-18 17:59 ` [Qemu-devel] " Paolo Bonzini
2016-01-10 18:12 ` [Qemu-trivial] " Michael Tokarev
2016-01-10 18:12 ` [Qemu-devel] " Michael Tokarev
2015-12-18 11:03 ` [Qemu-devel] [PATCH 5/5] xen-pvdevice: " Cao jin
2015-12-18 18:00 ` Paolo Bonzini
2015-12-21 5:52 ` Cao jin
2015-12-21 15:00 ` Stefano Stabellini
2015-12-21 15:15 ` Stefano Stabellini
2015-12-22 1:24 ` Cao jin
2015-12-22 2:40 ` Cao jin
2015-12-18 11:08 ` [Qemu-devel] [PATCH 0/5] Convert " Cao jin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5674496F.4000503@redhat.com \
--to=pbonzini@redhat.com \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=ehabkost@redhat.com \
--cc=leon.alrae@imgtec.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.