All of lore.kernel.org
 help / color / mirror / Atom feed
From: Suzuki.Poulose@arm.com (Suzuki K. Poulose)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4] arm64: run-time detection for aarch32 support
Date: Fri, 18 Dec 2015 22:09:59 +0000	[thread overview]
Message-ID: <56748437.2040905@arm.com> (raw)
In-Reply-To: <20151218174607.GE30229@leverpostej>

On 18/12/15 17:46, Mark Rutland wrote:
> On Fri, Dec 18, 2015 at 05:03:11PM +0000, Suzuki K. Poulose wrote:
>> On 18/12/15 16:00, Yury Norov wrote:
>>> Kernel option COMPAT defines the ability of executing aarch32 binaries.
>> As per ARM ARM, AArch32 only ID register values are unknown if AArch32 is
>> not implemented. So I think we need to skip accessing the AArch32 ID registers
>> everywhere (feature tracking), if the CPU doesn't supports it, to avoid
>> unnecessary SANITY failures and TAINTing the kernel.
>
> That all sounds good to me.
>
> After boot-time we should also fail hotplug of a CPU that doesn't
> support AArch32, if we decided at boot-time that AArch32 was supported
> accross the system. That should probably be added to your early cpu
> feature verification [1].

You are right. I think we could add this as system capability to arm64_feautres
which would make the check automatic. Also, the compat_elf_arch() check won't
have to always to read_system_reg(), something like ARM64_HAS_32BIT_EL0.

Thanks
Suzuki

WARNING: multiple messages have this Message-ID (diff)
From: "Suzuki K. Poulose" <Suzuki.Poulose@arm.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Yury Norov <ynorov@caviumnetworks.com>,
	Catalin.Marinas@arm.com, klimov.linux@gmail.com,
	ddaney.cavm@gmail.com, ard.biesheuvel@linaro.org,
	will.deacon@arm.com, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] arm64: run-time detection for aarch32 support
Date: Fri, 18 Dec 2015 22:09:59 +0000	[thread overview]
Message-ID: <56748437.2040905@arm.com> (raw)
In-Reply-To: <20151218174607.GE30229@leverpostej>

On 18/12/15 17:46, Mark Rutland wrote:
> On Fri, Dec 18, 2015 at 05:03:11PM +0000, Suzuki K. Poulose wrote:
>> On 18/12/15 16:00, Yury Norov wrote:
>>> Kernel option COMPAT defines the ability of executing aarch32 binaries.
>> As per ARM ARM, AArch32 only ID register values are unknown if AArch32 is
>> not implemented. So I think we need to skip accessing the AArch32 ID registers
>> everywhere (feature tracking), if the CPU doesn't supports it, to avoid
>> unnecessary SANITY failures and TAINTing the kernel.
>
> That all sounds good to me.
>
> After boot-time we should also fail hotplug of a CPU that doesn't
> support AArch32, if we decided at boot-time that AArch32 was supported
> accross the system. That should probably be added to your early cpu
> feature verification [1].

You are right. I think we could add this as system capability to arm64_feautres
which would make the check automatic. Also, the compat_elf_arch() check won't
have to always to read_system_reg(), something like ARM64_HAS_32BIT_EL0.

Thanks
Suzuki


  reply	other threads:[~2015-12-18 22:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-18 16:00 [PATCH v4] arm64: run-time detection for aarch32 support Yury Norov
2015-12-18 16:00 ` Yury Norov
2015-12-18 17:03 ` Suzuki K. Poulose
2015-12-18 17:03   ` Suzuki K. Poulose
2015-12-18 17:46   ` Mark Rutland
2015-12-18 17:46     ` Mark Rutland
2015-12-18 22:09     ` Suzuki K. Poulose [this message]
2015-12-18 22:09       ` Suzuki K. Poulose
2015-12-18 17:42 ` Mark Rutland
2015-12-18 17:42   ` Mark Rutland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56748437.2040905@arm.com \
    --to=suzuki.poulose@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.