All of lore.kernel.org
 help / color / mirror / Atom feed
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org,
	Richard Cochran <richardcochran@gmail.com>
Subject: Re: [PATCH] posix-clock: Use an unsigned data type for a variable
Date: Sun, 20 Dec 2015 13:08:03 +0000	[thread overview]
Message-ID: <5676A833.4090700@users.sourceforge.net> (raw)
In-Reply-To: <alpine.DEB.2.02.1512201350100.2067@localhost6.localdomain6>

>>>> Reuse the type from this poll call instead.
>>>
>>> Why use uint when the function return type it unsigned int?
>>
>> Do you prefer to express the type modifier once more there?
> 
> I don't know what the sentence means,

Can it be a matter of taste if the key word "unsigned" should be repeated
in such an use case?


> but I think that the type should be referenced in a consistent manner.

How do involved software designers and developers prefer to achieve
data type consistency here?

Which kind of naming convention will get priority?


>>> On the other hand, why is the function return type unsigned int
>>> when there is a return of a negative constant?
>>
>> This implementation detail can trigger further software development
>> considerations, can't it?
> 
> It would seem reasonable to address all of the signed/unsigned issues 
> related to the function return value at once.

Would you like to extend another evolving script for the semantic patch language?


I imagine that the general issue around the exception handling will cause
too many software development challenges to tackle them "at once".

Regards,
Markus

WARNING: multiple messages have this Message-ID (diff)
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org,
	Richard Cochran <richardcochran@gmail.com>
Subject: Re: [PATCH] posix-clock: Use an unsigned data type for a variable
Date: Sun, 20 Dec 2015 14:08:03 +0100	[thread overview]
Message-ID: <5676A833.4090700@users.sourceforge.net> (raw)
In-Reply-To: <alpine.DEB.2.02.1512201350100.2067@localhost6.localdomain6>

>>>> Reuse the type from this poll call instead.
>>>
>>> Why use uint when the function return type it unsigned int?
>>
>> Do you prefer to express the type modifier once more there?
> 
> I don't know what the sentence means,

Can it be a matter of taste if the key word "unsigned" should be repeated
in such an use case?


> but I think that the type should be referenced in a consistent manner.

How do involved software designers and developers prefer to achieve
data type consistency here?

Which kind of naming convention will get priority?


>>> On the other hand, why is the function return type unsigned int
>>> when there is a return of a negative constant?
>>
>> This implementation detail can trigger further software development
>> considerations, can't it?
> 
> It would seem reasonable to address all of the signed/unsigned issues 
> related to the function return value at once.

Would you like to extend another evolving script for the semantic patch language?


I imagine that the general issue around the exception handling will cause
too many software development challenges to tackle them "at once".

Regards,
Markus

  reply	other threads:[~2015-12-20 13:08 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-20  8:19 [PATCH] posix-clock: Use an unsigned data type for a variable SF Markus Elfring
2015-12-20  8:19 ` SF Markus Elfring
2015-12-20 11:09 ` Julia Lawall
2015-12-20 11:09   ` Julia Lawall
2015-12-20 12:48   ` SF Markus Elfring
2015-12-20 12:48     ` SF Markus Elfring
2015-12-20 12:51     ` Julia Lawall
2015-12-20 12:51       ` Julia Lawall
2015-12-20 13:08       ` SF Markus Elfring [this message]
2015-12-20 13:08         ` SF Markus Elfring
2015-12-20 20:09 ` Richard Cochran
2015-12-20 20:09   ` Richard Cochran
2015-12-21  9:30   ` SF Markus Elfring
2015-12-21  9:30     ` SF Markus Elfring
2015-12-21 10:12     ` Richard Cochran
2015-12-21 10:12       ` Richard Cochran
2015-12-22 21:19 ` [PATCH] posix-clock: fix return code on the poll method's error path Richard Cochran
2015-12-22 21:19   ` Richard Cochran
2015-12-29 10:36   ` [tip:timers/urgent] posix-clock: Fix " tip-bot for Richard Cochran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5676A833.4090700@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    --cc=julia.lawall@lip6.fr \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.