All of lore.kernel.org
 help / color / mirror / Atom feed
From: hdegoede@redhat.com (Hans de Goede)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-sunxi] Re: [PATCH 0/5] ARM: dts: sunxi: Add backlight node to q8 tablets
Date: Mon, 21 Dec 2015 13:59:59 +0100	[thread overview]
Message-ID: <5677F7CF.3050308@redhat.com> (raw)
In-Reply-To: <fc4adcf5-4362-4d4c-b42e-729922c79f65@googlegroups.com>

Hi,

On 21-12-15 11:56, Silvio Pellicano wrote:
>
>
>> Here is a slightly updated version of Chen-Yu's backlight
>> patches, also adding support for the backlight found on A13
>> based q8 tablets.
>>
>
> If i compile your dtsi with (obviously) pwm  support enable , backlight
> switch off after kernel start,
> if i disable pwm in menuconfig,it stay on, all seem correct (pwm on PB2 in
> original script.bin),
> but there is somewhere a bug in pwm or dtsi description of backlight.

No there is not, if you enable the pwm driver you must also enable
the backlight-pwm driver / add CONFIG_BACKLIGHT_PWM=y to your .config
(and make sure it stays that way after a "make oldconfig").

Regards,

Hans

WARNING: multiple messages have this Message-ID (diff)
From: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Silvio Pellicano
	<8001010-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-sunxi <linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>
Cc: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
	wens-jdAy2FN1RRM@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: Re: [PATCH 0/5] ARM: dts: sunxi: Add backlight node to q8 tablets
Date: Mon, 21 Dec 2015 13:59:59 +0100	[thread overview]
Message-ID: <5677F7CF.3050308@redhat.com> (raw)
In-Reply-To: <fc4adcf5-4362-4d4c-b42e-729922c79f65-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>

Hi,

On 21-12-15 11:56, Silvio Pellicano wrote:
>
>
>> Here is a slightly updated version of Chen-Yu's backlight
>> patches, also adding support for the backlight found on A13
>> based q8 tablets.
>>
>
> If i compile your dtsi with (obviously) pwm  support enable , backlight
> switch off after kernel start,
> if i disable pwm in menuconfig,it stay on, all seem correct (pwm on PB2 in
> original script.bin),
> but there is somewhere a bug in pwm or dtsi description of backlight.

No there is not, if you enable the pwm driver you must also enable
the backlight-pwm driver / add CONFIG_BACKLIGHT_PWM=y to your .config
(and make sure it stays that way after a "make oldconfig").

Regards,

Hans

  reply	other threads:[~2015-12-21 12:59 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-20 12:30 [PATCH 0/5] ARM: dts: sunxi: Add backlight node to q8 tablets Hans de Goede
2015-09-20 12:30 ` Hans de Goede
2015-09-20 12:30 ` [PATCH 1/5] ARM: dts: sun5i: Add PWM controller node for A13/A10s Hans de Goede
2015-09-20 12:30   ` Hans de Goede
2015-09-22 14:28   ` Maxime Ripard
2015-09-22 14:28     ` Maxime Ripard
2015-09-20 12:30 ` [PATCH 2/5] ARM: dts: sun5i: Add PWM channel 0 pinmux setting " Hans de Goede
2015-09-20 12:30   ` Hans de Goede
2015-09-22 14:29   ` Maxime Ripard
2015-09-22 14:29     ` Maxime Ripard
2015-09-20 12:30 ` [PATCH 3/5] ARM: dts: sunxi: Enable PWM controller on Q8 format tablets Hans de Goede
2015-09-20 12:30   ` Hans de Goede
2015-09-20 12:30 ` [PATCH 4/5] ARM: dts: sun8i: Add pwm-backlight device for A23/A33 " Hans de Goede
2015-09-20 12:30   ` Hans de Goede
2015-09-22 14:44   ` Maxime Ripard
2015-09-22 14:44     ` Maxime Ripard
2015-09-20 12:30 ` [PATCH 5/5] ARM: dts: sun5i: Add backlight node to sun5i-q8-common.dtsi Hans de Goede
2015-09-20 12:30   ` Hans de Goede
2015-09-20 14:46   ` Chen-Yu Tsai
2015-09-20 14:46     ` Chen-Yu Tsai
2015-09-20 15:14     ` [linux-sunxi] " Hans de Goede
2015-09-20 15:14       ` Hans de Goede
2015-09-20 15:21       ` [linux-sunxi] " Hans de Goede
2015-09-20 15:21         ` Hans de Goede
2015-12-19 10:54   ` 8001010 at gmail.com
2015-12-19 10:54     ` 8001010
2015-12-22  3:21     ` Chen-Yu Tsai
2015-12-22  3:21       ` Chen-Yu Tsai
     [not found] ` <1442752251-20744-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-12-21 10:56   ` [PATCH 0/5] ARM: dts: sunxi: Add backlight node to q8 tablets Silvio Pellicano
2015-12-21 12:59     ` Hans de Goede [this message]
2015-12-21 12:59       ` Hans de Goede
     [not found]       ` <5677F7CF.3050308-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-01-01  0:17         ` Silvio Pellicano
2016-01-11 10:34       ` [linux-sunxi] " 8001010
2016-01-11 10:34         ` 8001010
2016-01-11 11:09         ` Hans de Goede
2016-01-11 11:09           ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5677F7CF.3050308@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.