From: Eric Blake <eblake@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] io: bind to loopback IP addrs in test suite
Date: Tue, 22 Dec 2015 09:33:07 -0700 [thread overview]
Message-ID: <56797B43.70801@redhat.com> (raw)
In-Reply-To: <1450799164-14027-1-git-send-email-berrange@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 671 bytes --]
On 12/22/2015 08:46 AM, Daniel P. Berrange wrote:
> The test suite currently binds to 0.0.0.0 or ::, which covers
> all interfaces of the machine. It is bad practice for test
> suite to open publically accessible ports on a machine, so
> switch to use loopback addrs 127.0.0.1 or ::1.
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
> tests/test-io-channel-socket.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
prev parent reply other threads:[~2015-12-22 16:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-22 15:46 [Qemu-devel] [PATCH] io: bind to loopback IP addrs in test suite Daniel P. Berrange
2015-12-22 16:33 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56797B43.70801@redhat.com \
--to=eblake@redhat.com \
--cc=berrange@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.