All of lore.kernel.org
 help / color / mirror / Atom feed
From: "André Przywara" <andre.przywara-5wv7dgnIgG8@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: Maxime Ripard
	<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
	Herbert Xu
	<herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>,
	marc.zyngier-5wv7dgnIgG8@public.gmane.org,
	catalin.marinas-5wv7dgnIgG8@public.gmane.org,
	will.deacon-5wv7dgnIgG8@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
	Corentin Labbe
	<clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Subject: Re: [RFC PATCH 2/5] crypto: sunxi-ss: fix min3() call to match types
Date: Wed, 23 Dec 2015 00:07:41 +0000	[thread overview]
Message-ID: <5679E5CD.2070103@arm.com> (raw)
In-Reply-To: <201512222306.58681.arnd-r2nGTMty4D4@public.gmane.org>

Hi Arnd,
On 12/22/15 22:06, Arnd Bergmann wrote:
> On Tuesday 22 December 2015, Andre Przywara wrote:
>> The min3() macro expects all arguments to be of the same type (or
>> size at least). While two arguments are ints or u32s, one is size_t,
>> which does not match on 64-bit architectures.
>> Cast the size_t to u32 to make min3() happy. In this context here the
>> length should never exceed 32 bits anyway.
>>
>> Signed-off-by: Andre Przywara <andre.przywara-5wv7dgnIgG8@public.gmane.org>
> 
> Looks correct, but a bit ugly. Could we avoid the casts by using
> temporary variables to keep the size_t based data?

I guess this gets even uglier, but I found a better solution by
promoting the other involved variables to size_t in this function. This
works nicely for most of the cases, I just need two size_t casts now.
Will send an updated version soon.

Cheers,
Andre.

WARNING: multiple messages have this Message-ID (diff)
From: andre.przywara@arm.com (André Przywara)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 2/5] crypto: sunxi-ss: fix min3() call to match types
Date: Wed, 23 Dec 2015 00:07:41 +0000	[thread overview]
Message-ID: <5679E5CD.2070103@arm.com> (raw)
In-Reply-To: <201512222306.58681.arnd@arndb.de>

Hi Arnd,
On 12/22/15 22:06, Arnd Bergmann wrote:
> On Tuesday 22 December 2015, Andre Przywara wrote:
>> The min3() macro expects all arguments to be of the same type (or
>> size at least). While two arguments are ints or u32s, one is size_t,
>> which does not match on 64-bit architectures.
>> Cast the size_t to u32 to make min3() happy. In this context here the
>> length should never exceed 32 bits anyway.
>>
>> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> 
> Looks correct, but a bit ugly. Could we avoid the casts by using
> temporary variables to keep the size_t based data?

I guess this gets even uglier, but I found a better solution by
promoting the other involved variables to size_t in this function. This
works nicely for most of the cases, I just need two size_t casts now.
Will send an updated version soon.

Cheers,
Andre.

WARNING: multiple messages have this Message-ID (diff)
From: "André Przywara" <andre.przywara@arm.com>
To: Arnd Bergmann <arnd@arndb.de>, linux-arm-kernel@lists.infradead.org
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>,
	Chen-Yu Tsai <wens@csie.org>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	marc.zyngier@arm.com, catalin.marinas@arm.com,
	will.deacon@arm.com, linux-kernel@vger.kernel.org,
	linux-sunxi@googlegroups.com,
	Corentin Labbe <clabbe.montjoie@gmail.com>,
	linux-crypto@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [RFC PATCH 2/5] crypto: sunxi-ss: fix min3() call to match types
Date: Wed, 23 Dec 2015 00:07:41 +0000	[thread overview]
Message-ID: <5679E5CD.2070103@arm.com> (raw)
In-Reply-To: <201512222306.58681.arnd@arndb.de>

Hi Arnd,
On 12/22/15 22:06, Arnd Bergmann wrote:
> On Tuesday 22 December 2015, Andre Przywara wrote:
>> The min3() macro expects all arguments to be of the same type (or
>> size at least). While two arguments are ints or u32s, one is size_t,
>> which does not match on 64-bit architectures.
>> Cast the size_t to u32 to make min3() happy. In this context here the
>> length should never exceed 32 bits anyway.
>>
>> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> 
> Looks correct, but a bit ugly. Could we avoid the casts by using
> temporary variables to keep the size_t based data?

I guess this gets even uglier, but I found a better solution by
promoting the other involved variables to size_t in this function. This
works nicely for most of the cases, I just need two size_t casts now.
Will send an updated version soon.

Cheers,
Andre.


  parent reply	other threads:[~2015-12-23  0:07 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-22 12:27 [RFC PATCH 0/5] arm64: prepare for basic Allwinner support Andre Przywara
2015-12-22 12:27 ` Andre Przywara
2015-12-22 12:27 ` [RFC PATCH 1/5] drivers: sunxi-rsb: fix error output type Andre Przywara
2015-12-22 12:27   ` Andre Przywara
2015-12-22 22:02   ` Arnd Bergmann
2015-12-22 22:02     ` Arnd Bergmann
2015-12-27 22:03   ` Maxime Ripard
2015-12-27 22:03     ` Maxime Ripard
2015-12-22 12:27 ` [RFC PATCH 2/5] crypto: sunxi-ss: fix min3() call to match types Andre Przywara
2015-12-22 12:27   ` Andre Przywara
     [not found]   ` <1450787267-26836-3-git-send-email-andre.przywara-5wv7dgnIgG8@public.gmane.org>
2015-12-22 22:06     ` Arnd Bergmann
2015-12-22 22:06       ` Arnd Bergmann
2015-12-22 22:06       ` Arnd Bergmann
     [not found]       ` <201512222306.58681.arnd-r2nGTMty4D4@public.gmane.org>
2015-12-23  0:07         ` André Przywara [this message]
2015-12-23  0:07           ` André Przywara
2015-12-23  0:07           ` André Przywara
2016-01-04 14:20   ` Uwe Kleine-König
2016-01-04 14:20     ` Uwe Kleine-König
2015-12-22 12:27 ` [RFC PATCH 3/5] crypto: sunxi-ss: fix dev_dbg() output type Andre Przywara
2015-12-22 12:27   ` Andre Przywara
     [not found]   ` <1450787267-26836-4-git-send-email-andre.przywara-5wv7dgnIgG8@public.gmane.org>
2015-12-22 22:07     ` Arnd Bergmann
2015-12-22 22:07       ` Arnd Bergmann
2015-12-22 22:07       ` Arnd Bergmann
2015-12-24 12:56     ` Corentin LABBE
2015-12-24 12:56       ` Corentin LABBE
2015-12-24 12:56       ` Corentin LABBE
2015-12-27 22:05   ` Maxime Ripard
2015-12-27 22:05     ` Maxime Ripard
2015-12-22 12:27 ` [RFC PATCH 4/5] irqchip: sun4i: fix compilation outside of arch/arm Andre Przywara
2015-12-22 12:27   ` Andre Przywara
2015-12-22 22:08   ` Arnd Bergmann
2015-12-22 22:08     ` Arnd Bergmann
2015-12-27 22:04   ` Maxime Ripard
2015-12-27 22:04     ` Maxime Ripard
2015-12-22 12:27 ` [RFC PATCH 5/5] arm64: Introduce Allwinner SoC config option Andre Przywara
2015-12-22 12:27   ` Andre Przywara
2015-12-22 22:09   ` Arnd Bergmann
2015-12-22 22:09     ` Arnd Bergmann
2016-01-04 11:26   ` Maxime Ripard
2016-01-04 11:26     ` Maxime Ripard
2016-01-04 12:12     ` Arnd Bergmann
2016-01-04 12:12       ` Arnd Bergmann
2016-01-06 21:03       ` Maxime Ripard
2016-01-06 21:03         ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5679E5CD.2070103@arm.com \
    --to=andre.przywara-5wv7dgnigg8@public.gmane.org \
    --cc=arnd-r2nGTMty4D4@public.gmane.org \
    --cc=catalin.marinas-5wv7dgnIgG8@public.gmane.org \
    --cc=clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
    --cc=herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
    --cc=marc.zyngier-5wv7dgnIgG8@public.gmane.org \
    --cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
    --cc=wens-jdAy2FN1RRM@public.gmane.org \
    --cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.