[PATCH] libav: Add "--enable-gpl" to PACKAGECONFIG[x264]

[PATCH] libav: Add "--enable-gpl" to PACKAGECONFIG[x264]

[Mike Looijmans]

Building libav resulted in the following message during configure:
  libx264 is gpl and --enable-gpl is not specified.
Resolve it by adding --enable-gpl to the x264 package config.

Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
---
 meta/recipes-multimedia/libav/libav.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-multimedia/libav/libav.inc b/meta/recipes-multimedia/libav/libav.inc
index 05b7e87..8ae6739 100644
--- a/meta/recipes-multimedia/libav/libav.inc
+++ b/meta/recipes-multimedia/libav/libav.inc
@@ -52,7 +52,7 @@ PACKAGECONFIG[theora] = "--enable-libtheora,--disable-libtheora,libtheora"
 PACKAGECONFIG[vaapi] = "--enable-vaapi,--disable-vaapi,libva"
 PACKAGECONFIG[vpx] = "--enable-libvpx,--disable-libvpx,libvpx"
 PACKAGECONFIG[x11] = "--enable-x11grab,--disable-x11grab,virtual/libx11 libxfixes libxext xproto virtual/libsdl"
-PACKAGECONFIG[x264] = "--enable-libx264,--disable-libx264,x264"
+PACKAGECONFIG[x264] = "--enable-gpl --enable-libx264,--disable-libx264,x264"
 
 # Check codecs that require --enable-nonfree
 USE_NONFREE = "${@bb.utils.contains_any('PACKAGECONFIG', [ 'faac', 'openssl' ], 'yes', '', d)}"
-- 
2.1.4

Re: [PATCH] libav: Add "--enable-gpl" to PACKAGECONFIG[x264]

[Mike Looijmans]

hmm, apparently there's already a "gpl" PACKAGECONFIG item.
I don't think we have dependencies in that, so there's no easy way to 
tell people that "if you include 'x264' in the list you must include 
'gpl' as well"?

I guess this patch better be dropped then.

On 23-12-15 09:05, Mike Looijmans wrote:
> Building libav resulted in the following message during configure:
>    libx264 is gpl and --enable-gpl is not specified.
> Resolve it by adding --enable-gpl to the x264 package config.
>
> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
> ---
>   meta/recipes-multimedia/libav/libav.inc | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-multimedia/libav/libav.inc b/meta/recipes-multimedia/libav/libav.inc
> index 05b7e87..8ae6739 100644
> --- a/meta/recipes-multimedia/libav/libav.inc
> +++ b/meta/recipes-multimedia/libav/libav.inc
> @@ -52,7 +52,7 @@ PACKAGECONFIG[theora] = "--enable-libtheora,--disable-libtheora,libtheora"
>   PACKAGECONFIG[vaapi] = "--enable-vaapi,--disable-vaapi,libva"
>   PACKAGECONFIG[vpx] = "--enable-libvpx,--disable-libvpx,libvpx"
>   PACKAGECONFIG[x11] = "--enable-x11grab,--disable-x11grab,virtual/libx11 libxfixes libxext xproto virtual/libsdl"
> -PACKAGECONFIG[x264] = "--enable-libx264,--disable-libx264,x264"
> +PACKAGECONFIG[x264] = "--enable-gpl --enable-libx264,--disable-libx264,x264"
>
>   # Check codecs that require --enable-nonfree
>   USE_NONFREE = "${@bb.utils.contains_any('PACKAGECONFIG', [ 'faac', 'openssl' ], 'yes', '', d)}"
>


-- 
Mike Looijmans

Re: [PATCH] libav: Add "--enable-gpl" to PACKAGECONFIG[x264]

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 311 bytes --]

On 23 December 2015 at 13:17, Mike Looijmans <mike.looijmans@topic.nl>
wrote:

> I don't think we have dependencies in that, so there's no easy way to tell
> people that "if you include 'x264' in the list you must include 'gpl' as
> well"?
>

I think the best approach here would be a comment.

Ross

[-- Attachment #2: Type: text/html, Size: 748 bytes --]