* [PATCH v2] PCI/AER: include header file
@ 2015-12-23 15:35 ` Sudip Mukherjee
0 siblings, 0 replies; 4+ messages in thread
From: Sudip Mukherjee @ 2015-12-23 15:35 UTC (permalink / raw)
We are having build failure with sparc allmodconfig with the error:
drivers/nvme/host/pci.c:15:0:
include/linux/aer.h: In function 'pci_enable_pcie_error_reporting':
include/linux/aer.h:49:10: error: 'EINVAL' undeclared (first use in this function)
The file aer.h is using the error values but they are defined in
errno.h. Include errno.h so that we have the definitions of the error
codes.
Fixes: a0a3408ee614 ("NVMe: Add pci error handlers")
Cc: Keith Busch <keith.busch at intel.com>
Signed-off-by: Sudip Mukherjee <sudip at vectorindia.org>
---
v1 and its review is at:
https://lkml.org/lkml/2015/12/23/226
sparc allmodconfig build is at:
https://travis-ci.org/sudipm-mukherjee/parport/jobs/98451364
include/linux/aer.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/aer.h b/include/linux/aer.h
index 744b997..1640493 100644
--- a/include/linux/aer.h
+++ b/include/linux/aer.h
@@ -7,6 +7,7 @@
#ifndef _AER_H_
#define _AER_H_
+#include <linux/errno.h>
#include <linux/types.h>
#define AER_NONFATAL 0
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH v2] PCI/AER: include header file
@ 2015-12-23 15:35 ` Sudip Mukherjee
0 siblings, 0 replies; 4+ messages in thread
From: Sudip Mukherjee @ 2015-12-23 15:35 UTC (permalink / raw)
To: Bjorn Helgaas, Jens Axboe, Keith Busch
Cc: linux-kernel, Matthew Wilcox, linux-nvme, Sudip Mukherjee
We are having build failure with sparc allmodconfig with the error:
drivers/nvme/host/pci.c:15:0:
include/linux/aer.h: In function 'pci_enable_pcie_error_reporting':
include/linux/aer.h:49:10: error: 'EINVAL' undeclared (first use in this function)
The file aer.h is using the error values but they are defined in
errno.h. Include errno.h so that we have the definitions of the error
codes.
Fixes: a0a3408ee614 ("NVMe: Add pci error handlers")
Cc: Keith Busch <keith.busch@intel.com>
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
v1 and its review is at:
https://lkml.org/lkml/2015/12/23/226
sparc allmodconfig build is at:
https://travis-ci.org/sudipm-mukherjee/parport/jobs/98451364
include/linux/aer.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/aer.h b/include/linux/aer.h
index 744b997..1640493 100644
--- a/include/linux/aer.h
+++ b/include/linux/aer.h
@@ -7,6 +7,7 @@
#ifndef _AER_H_
#define _AER_H_
+#include <linux/errno.h>
#include <linux/types.h>
#define AER_NONFATAL 0
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH v2] PCI/AER: include header file
2015-12-23 15:35 ` Sudip Mukherjee
@ 2015-12-23 15:37 ` Jens Axboe
-1 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2015-12-23 15:37 UTC (permalink / raw)
On 12/23/2015 08:35 AM, Sudip Mukherjee wrote:
> We are having build failure with sparc allmodconfig with the error:
>
> drivers/nvme/host/pci.c:15:0:
> include/linux/aer.h: In function 'pci_enable_pcie_error_reporting':
> include/linux/aer.h:49:10: error: 'EINVAL' undeclared (first use in this function)
>
> The file aer.h is using the error values but they are defined in
> errno.h. Include errno.h so that we have the definitions of the error
> codes.
Applied to for-4.5/nvme, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] PCI/AER: include header file
@ 2015-12-23 15:37 ` Jens Axboe
0 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2015-12-23 15:37 UTC (permalink / raw)
To: Sudip Mukherjee, Bjorn Helgaas, Keith Busch
Cc: linux-kernel, Matthew Wilcox, linux-nvme
On 12/23/2015 08:35 AM, Sudip Mukherjee wrote:
> We are having build failure with sparc allmodconfig with the error:
>
> drivers/nvme/host/pci.c:15:0:
> include/linux/aer.h: In function 'pci_enable_pcie_error_reporting':
> include/linux/aer.h:49:10: error: 'EINVAL' undeclared (first use in this function)
>
> The file aer.h is using the error values but they are defined in
> errno.h. Include errno.h so that we have the definitions of the error
> codes.
Applied to for-4.5/nvme, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-12-23 15:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-23 15:35 [PATCH v2] PCI/AER: include header file Sudip Mukherjee
2015-12-23 15:35 ` Sudip Mukherjee
2015-12-23 15:37 ` Jens Axboe
2015-12-23 15:37 ` Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.