All of lore.kernel.org
 help / color / mirror / Atom feed
From: Doug Ledford <dledford@redhat.com>
To: Dave Goodell <dgoodell@cisco.com>, Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Christian Benvenuti <benve@cisco.com>,
	kernel-janitors@vger.kernel.org,
	Sean Hefty <sean.hefty@intel.com>,
	Hal Rosenstock <hal.rosenstock@gmail.com>,
	linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
	Nelson Escobar <neescoba@cisco.com>
Subject: Re: [PATCH] IB/usnic: delete unneeded IS_ERR test
Date: Wed, 23 Dec 2015 16:11:06 +0000	[thread overview]
Message-ID: <567AC79A.8000306@redhat.com> (raw)
In-Reply-To: <20151222152903.GA23118@DGOODELL-M-F02A.cisco.com>

[-- Attachment #1: Type: text/plain, Size: 681 bytes --]

On 12/22/2015 10:29 AM, Dave Goodell wrote:
> [copying Nelson too]
> 
> On Sat, Dec 19, 2015 at 09:48:59PM +0100, Julia Lawall wrote:
>> kzalloc doesn't return ERR_PTR, so there is no need to test for it.
>>
>> The semantic match that finds this problem is as follows:
>> (http://coccinelle.lip6.fr/)
>>
>> // <smpl>
>> @@
>> expression x,e;
>> @@
>>
>> * x = kzalloc(...)
>> ... when != x = e
>> * IS_ERR_OR_NULL(x)
>> // </smpl>
>>
>> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> Reviewed-by: Dave Goodell <dgoodell@cisco.com>
> 
> -Dave
> 

Thanks, applied.

-- 
Doug Ledford <dledford@redhat.com>
              GPG KeyID: 0E572FDD



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Doug Ledford <dledford@redhat.com>
To: Dave Goodell <dgoodell@cisco.com>, Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Christian Benvenuti <benve@cisco.com>,
	kernel-janitors@vger.kernel.org,
	Sean Hefty <sean.hefty@intel.com>,
	Hal Rosenstock <hal.rosenstock@gmail.com>,
	linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
	Nelson Escobar <neescoba@cisco.com>
Subject: Re: [PATCH] IB/usnic: delete unneeded IS_ERR test
Date: Wed, 23 Dec 2015 11:11:06 -0500	[thread overview]
Message-ID: <567AC79A.8000306@redhat.com> (raw)
In-Reply-To: <20151222152903.GA23118@DGOODELL-M-F02A.cisco.com>

[-- Attachment #1: Type: text/plain, Size: 681 bytes --]

On 12/22/2015 10:29 AM, Dave Goodell wrote:
> [copying Nelson too]
> 
> On Sat, Dec 19, 2015 at 09:48:59PM +0100, Julia Lawall wrote:
>> kzalloc doesn't return ERR_PTR, so there is no need to test for it.
>>
>> The semantic match that finds this problem is as follows:
>> (http://coccinelle.lip6.fr/)
>>
>> // <smpl>
>> @@
>> expression x,e;
>> @@
>>
>> * x = kzalloc(...)
>> ... when != x = e
>> * IS_ERR_OR_NULL(x)
>> // </smpl>
>>
>> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> Reviewed-by: Dave Goodell <dgoodell@cisco.com>
> 
> -Dave
> 

Thanks, applied.

-- 
Doug Ledford <dledford@redhat.com>
              GPG KeyID: 0E572FDD



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]

  reply	other threads:[~2015-12-23 16:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-19 20:48 [PATCH] IB/usnic: delete unneeded IS_ERR test Julia Lawall
2015-12-19 20:48 ` Julia Lawall
2015-12-19 20:48 ` Julia Lawall
2015-12-22 15:29 ` Dave Goodell
2015-12-22 15:29   ` Dave Goodell
2015-12-23 16:11   ` Doug Ledford [this message]
2015-12-23 16:11     ` Doug Ledford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=567AC79A.8000306@redhat.com \
    --to=dledford@redhat.com \
    --cc=Julia.Lawall@lip6.fr \
    --cc=benve@cisco.com \
    --cc=dgoodell@cisco.com \
    --cc=hal.rosenstock@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=neescoba@cisco.com \
    --cc=sean.hefty@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.