From: akshay.bhat@timesys.com (Akshay Bhat)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 3/7] ARM: dts: imx: Add Advantech BA-16 Qseven module
Date: Wed, 23 Dec 2015 17:12:37 -0500 [thread overview]
Message-ID: <567B1C55.1050709@timesys.com> (raw)
In-Reply-To: <20151223023035.GH26290@tiger>
On 12/22/2015 09:31 PM, Shawn Guo wrote:
> On Tue, Dec 22, 2015 at 05:42:01PM -0500, Akshay Bhat wrote:
>>>> +&iomuxc {
>>>
>>> Suggest to put the iomuxc node at the bottom of the dts to make the read
>>> of this file a bit easier.
>>>
>> Will fix it
>>
>>>> + pinctrl-names = "default";
>>>> + pinctrl-0 = <&pinctrl_hog>;
>>>> +
>>>> + imx6q-ba16 {
>>>
>>> With commit 5fcdf6a7ed95 (pinctrl: imx: Allow parsing DT without function
>>> nodes) in place, we can get rid of this container node to save one level
>>> of indentation.
>>>
>>
>> If i remove the imx6q-ba16 container node, then I get multiple
>> errors during boot.
>>
>> [ 2.043594] imx6q-pinctrl 20e0000.iomuxc: unable to find group
>> for node ecspi1grp
>> .....
>> [ 2.467403] imx6q-pinctrl 20e0000.iomuxc: unable to find group
>> for node usbotggrp
>> [ 2.482394] imx6q-pinctrl 20e0000.iomuxc: unable to find group
>> for node usbhubgrp
>> .....
>> [ 2.640509] imx6q-pinctrl 20e0000.iomuxc: unable to find group
>> for node usdhc2grp
>> [ 2.640889] imx6q-pinctrl 20e0000.iomuxc: unable to find group
>> for node usdhc2grp
>> [ 2.640986] sdhci-esdhc-imx: probe of 2194000.usdhc failed with error -22
>> [ 2.641048] imx6q-pinctrl 20e0000.iomuxc: unable to find group
>> for node usdhc3grp
>> [ 2.641301] imx6q-pinctrl 20e0000.iomuxc: unable to find group
>> for node usdhc3grp
>> [ 2.641385] sdhci-esdhc-imx: probe of 2198000.usdhc failed with error -22
>> [ 2.641446] imx6q-pinctrl 20e0000.iomuxc: unable to find group
>> for node usdhc4grp
>> [ 2.641688] imx6q-pinctrl 20e0000.iomuxc: unable to find group
>> for node usdhc4grp
>> [ 2.641770] sdhci-esdhc-imx: probe of 219c000.usdhc failed with error -22
>
> Sorry. I just found that to get this work on imx6q board we need to
> clean up the ipu2/ipu2grp-1 group from imx6q.dtsi. I just send a patch
> doing that with you on copy. Let me know if it works for you with that
> change.
>
> Shawn
>
Thanks Shawn, I applied the patch you sent and it fixed the above issue.
Also I have addressed all the comments and re-submitted the patches.
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-December/396131.html
WARNING: multiple messages have this Message-ID (diff)
From: Akshay Bhat <akshay.bhat-jEh4hwF5bVhBDgjK7y7TUQ@public.gmane.org>
To: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
justin.waters-jEh4hwF5bVhBDgjK7y7TUQ@public.gmane.org,
l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org
Subject: Re: [PATCH v5 3/7] ARM: dts: imx: Add Advantech BA-16 Qseven module
Date: Wed, 23 Dec 2015 17:12:37 -0500 [thread overview]
Message-ID: <567B1C55.1050709@timesys.com> (raw)
In-Reply-To: <20151223023035.GH26290@tiger>
On 12/22/2015 09:31 PM, Shawn Guo wrote:
> On Tue, Dec 22, 2015 at 05:42:01PM -0500, Akshay Bhat wrote:
>>>> +&iomuxc {
>>>
>>> Suggest to put the iomuxc node at the bottom of the dts to make the read
>>> of this file a bit easier.
>>>
>> Will fix it
>>
>>>> + pinctrl-names = "default";
>>>> + pinctrl-0 = <&pinctrl_hog>;
>>>> +
>>>> + imx6q-ba16 {
>>>
>>> With commit 5fcdf6a7ed95 (pinctrl: imx: Allow parsing DT without function
>>> nodes) in place, we can get rid of this container node to save one level
>>> of indentation.
>>>
>>
>> If i remove the imx6q-ba16 container node, then I get multiple
>> errors during boot.
>>
>> [ 2.043594] imx6q-pinctrl 20e0000.iomuxc: unable to find group
>> for node ecspi1grp
>> .....
>> [ 2.467403] imx6q-pinctrl 20e0000.iomuxc: unable to find group
>> for node usbotggrp
>> [ 2.482394] imx6q-pinctrl 20e0000.iomuxc: unable to find group
>> for node usbhubgrp
>> .....
>> [ 2.640509] imx6q-pinctrl 20e0000.iomuxc: unable to find group
>> for node usdhc2grp
>> [ 2.640889] imx6q-pinctrl 20e0000.iomuxc: unable to find group
>> for node usdhc2grp
>> [ 2.640986] sdhci-esdhc-imx: probe of 2194000.usdhc failed with error -22
>> [ 2.641048] imx6q-pinctrl 20e0000.iomuxc: unable to find group
>> for node usdhc3grp
>> [ 2.641301] imx6q-pinctrl 20e0000.iomuxc: unable to find group
>> for node usdhc3grp
>> [ 2.641385] sdhci-esdhc-imx: probe of 2198000.usdhc failed with error -22
>> [ 2.641446] imx6q-pinctrl 20e0000.iomuxc: unable to find group
>> for node usdhc4grp
>> [ 2.641688] imx6q-pinctrl 20e0000.iomuxc: unable to find group
>> for node usdhc4grp
>> [ 2.641770] sdhci-esdhc-imx: probe of 219c000.usdhc failed with error -22
>
> Sorry. I just found that to get this work on imx6q board we need to
> clean up the ipu2/ipu2grp-1 group from imx6q.dtsi. I just send a patch
> doing that with you on copy. Let me know if it works for you with that
> change.
>
> Shawn
>
Thanks Shawn, I applied the patch you sent and it fixed the above issue.
Also I have addressed all the comments and re-submitted the patches.
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-December/396131.html
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-12-23 22:12 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 21:10 [PATCH v5 0/7] ARM: dts: Add Advantech board support Akshay Bhat
2015-12-03 21:10 ` Akshay Bhat
2015-12-03 21:10 ` [PATCH v5 1/7] of: Add vendor prefix for Advantech Corporation Akshay Bhat
2015-12-03 21:10 ` Akshay Bhat
2015-12-03 21:10 ` [PATCH v5 2/7] of: Add vendor prefix for General Electric Company Akshay Bhat
2015-12-03 21:10 ` Akshay Bhat
2015-12-03 21:10 ` [PATCH v5 3/7] ARM: dts: imx: Add Advantech BA-16 Qseven module Akshay Bhat
2015-12-03 21:10 ` Akshay Bhat
2015-12-22 11:40 ` Shawn Guo
2015-12-22 11:40 ` Shawn Guo
2015-12-22 22:42 ` Akshay Bhat
2015-12-22 22:42 ` Akshay Bhat
2015-12-23 2:31 ` Shawn Guo
2015-12-23 2:31 ` Shawn Guo
2015-12-23 22:12 ` Akshay Bhat [this message]
2015-12-23 22:12 ` Akshay Bhat
2015-12-23 22:22 ` Akshay Bhat
2015-12-23 22:22 ` Akshay Bhat
2015-12-03 21:10 ` [PATCH v5 4/7] ARM: dts: imx: Add support for Advantech/GE Bx50v3 Akshay Bhat
2015-12-03 21:10 ` Akshay Bhat
2015-12-03 21:10 ` [PATCH v5 5/7] ARM: dts: imx: Add support for Advantech/GE B450v3 Akshay Bhat
2015-12-03 21:10 ` Akshay Bhat
2015-12-03 21:10 ` [PATCH v5 6/7] ARM: dts: imx: Add support for Advantech/GE B650v3 Akshay Bhat
2015-12-03 21:10 ` Akshay Bhat
2015-12-03 21:10 ` [PATCH v5 7/7] ARM: dts: imx: Add support for Advantech/GE B850v3 Akshay Bhat
2015-12-03 21:10 ` Akshay Bhat
2015-12-21 22:53 ` [PATCH v5 0/7] ARM: dts: Add Advantech board support Akshay Bhat
2015-12-21 22:53 ` Akshay Bhat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=567B1C55.1050709@timesys.com \
--to=akshay.bhat@timesys.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.