Re: [PATCH 2/2] power:bq27xxx: fix register numbers of bq27500

All of lore.kernel.org
 help / color / mirror / Atom feed

From: "Andrew F. Davis" <afd@ti.com>
To: "H. Nikolaus Schaller" <hns@goldelico.com>,
	"Pali Rohár" <pali.rohar@gmail.com>,
	"Sebastian Reichel" <sre@kernel.org>,
	"Dmitry Eremin-Solenikov" <dbaryshkov@gmail.com>,
	"David Woodhouse" <dwmw2@infradead.org>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	gta04-owner@goldelico.com, marek@goldelico.com
Subject: Re: [PATCH 2/2] power:bq27xxx: fix register numbers of bq27500
Date: Wed, 23 Dec 2015 20:52:28 -0600	[thread overview]
Message-ID: <567B5DEC.3050106@ti.com> (raw)
In-Reply-To: <dd1c67a7c8a2cabed0433f2d7b30f91bb0b06b78.1450347172.git.hns@goldelico.com>

On 12/17/2015 04:12 AM, H. Nikolaus Schaller wrote:
> bug: according to data sheet some register numbers are wrong.
>
> tested: no
>
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>

Indeed they are, good catch.

Acked-by: Andrew F. Davis <afd@ti.com>

> ---
>   drivers/power/bq27xxx_battery.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/power/bq27xxx_battery.c b/drivers/power/bq27xxx_battery.c
> index e54a125..f9a5f4f 100644
> --- a/drivers/power/bq27xxx_battery.c
> +++ b/drivers/power/bq27xxx_battery.c
> @@ -198,10 +198,10 @@ static u8 bq27500_regs[] = {
>   	INVALID_REG_ADDR,	/* TTECP - NA	*/
>   	0x0c,	/* NAC		*/
>   	0x12,	/* LMD(FCC)	*/
> -	0x1e,	/* CYCT		*/
> +	0x2a,	/* CYCT		*/
>   	INVALID_REG_ADDR,	/* AE - NA	*/
> -	0x20,	/* SOC(RSOC)	*/
> -	0x2e,	/* DCAP(ILMD)	*/
> +	0x2c,	/* SOC(RSOC)	*/
> +	0x3c,	/* DCAP(ILMD)	*/
>   	INVALID_REG_ADDR,	/* AP - NA	*/
>   };
>
>

WARNING: multiple messages have this Message-ID (diff)

From: "Andrew F. Davis" <afd@ti.com>
To: "H. Nikolaus Schaller" <hns@goldelico.com>,
	"Pali Rohár" <pali.rohar@gmail.com>,
	"Sebastian Reichel" <sre@kernel.org>,
	"Dmitry Eremin-Solenikov" <dbaryshkov@gmail.com>,
	"David Woodhouse" <dwmw2@infradead.org>
Cc: <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<gta04-owner@goldelico.com>, <marek@goldelico.com>
Subject: Re: [PATCH 2/2] power:bq27xxx: fix register numbers of bq27500
Date: Wed, 23 Dec 2015 20:52:28 -0600	[thread overview]
Message-ID: <567B5DEC.3050106@ti.com> (raw)
In-Reply-To: <dd1c67a7c8a2cabed0433f2d7b30f91bb0b06b78.1450347172.git.hns@goldelico.com>

On 12/17/2015 04:12 AM, H. Nikolaus Schaller wrote:
> bug: according to data sheet some register numbers are wrong.
>
> tested: no
>
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>

Indeed they are, good catch.

Acked-by: Andrew F. Davis <afd@ti.com>

> ---
>   drivers/power/bq27xxx_battery.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/power/bq27xxx_battery.c b/drivers/power/bq27xxx_battery.c
> index e54a125..f9a5f4f 100644
> --- a/drivers/power/bq27xxx_battery.c
> +++ b/drivers/power/bq27xxx_battery.c
> @@ -198,10 +198,10 @@ static u8 bq27500_regs[] = {
>   	INVALID_REG_ADDR,	/* TTECP - NA	*/
>   	0x0c,	/* NAC		*/
>   	0x12,	/* LMD(FCC)	*/
> -	0x1e,	/* CYCT		*/
> +	0x2a,	/* CYCT		*/
>   	INVALID_REG_ADDR,	/* AE - NA	*/
> -	0x20,	/* SOC(RSOC)	*/
> -	0x2e,	/* DCAP(ILMD)	*/
> +	0x2c,	/* SOC(RSOC)	*/
> +	0x3c,	/* DCAP(ILMD)	*/
>   	INVALID_REG_ADDR,	/* AP - NA	*/
>   };
>
>

next prev parent reply	other threads:[~2015-12-24  2:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-17 10:12 [PATCH 0/2] two fixes for new bq27000/10 and bq27500 driver H. Nikolaus Schaller
2015-12-17 10:12 ` [PATCH 1/2] power:bq27xxx: fix reading for bq27000 and bq27010 H. Nikolaus Schaller
2015-12-24  2:46   ` Andrew F. Davis
2015-12-24  2:46     ` Andrew F. Davis
2015-12-25 13:20   ` Pali Rohár
2015-12-17 10:12 ` [PATCH 2/2] power:bq27xxx: fix register numbers of bq27500 H. Nikolaus Schaller
2015-12-24  2:52   ` Andrew F. Davis [this message]
2015-12-24  2:52     ` Andrew F. Davis
2015-12-19  8:00 ` [PATCH 0/2] two fixes for new bq27000/10 and bq27500 driver Sebastian Reichel
2015-12-24 13:57   ` Andrew F. Davis
2015-12-25 13:22     ` Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=567B5DEC.3050106@ti.com \
    --to=afd@ti.com \
    --cc=dbaryshkov@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=gta04-owner@goldelico.com \
    --cc=hns@goldelico.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=marek@goldelico.com \
    --cc=pali.rohar@gmail.com \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.