From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: cocci@systeme.lip6.fr
Subject: [Cocci] [PATCH v2] coccinelle: api: check for propagation of error from platform_get_irq
Date: Sun, 27 Dec 2015 14:18:44 +0300 [thread overview]
Message-ID: <567FC914.4080705@cogentembedded.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1512270709420.2038@localhost6.localdomain6>
On 12/27/2015 9:13 AM, Julia Lawall wrote:
>> Well, looking again, the patch should be good. I just thought its goal was
>> to fix the code as well...
>
> I could do that for the irq < 0 case, but I think that in that case, kbuild
> will only run the patch version, and the <= cases will not be reported on.
> I don't have a general fix for the <= 0. Is it even correct to have < in
> some cases and <= in others?
That's a good question...
In my prior fixes of this case I preferred to consider IRQ0 valid and so
used 'irq < 0'. I myself don't share the "IRQ0 is invalid" sentiment...
> julia
MBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: cocci@systeme.lip6.fr
Subject: Re: [PATCH v2] coccinelle: api: check for propagation of error from platform_get_irq
Date: Sun, 27 Dec 2015 11:18:44 +0000 [thread overview]
Message-ID: <567FC914.4080705@cogentembedded.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1512270709420.2038@localhost6.localdomain6>
On 12/27/2015 9:13 AM, Julia Lawall wrote:
>> Well, looking again, the patch should be good. I just thought its goal was
>> to fix the code as well...
>
> I could do that for the irq < 0 case, but I think that in that case, kbuild
> will only run the patch version, and the <= cases will not be reported on.
> I don't have a general fix for the <= 0. Is it even correct to have < in
> some cases and <= in others?
That's a good question...
In my prior fixes of this case I preferred to consider IRQ0 valid and so
used 'irq < 0'. I myself don't share the "IRQ0 is invalid" sentiment...
> julia
MBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Gilles Muller <Gilles.Muller@lip6.fr>,
Nicolas Palix <nicolas.palix@imag.fr>,
Michal Marek <mmarek@suse.com>,
cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, netdev@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-spi@vger.kernel.org,
dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] coccinelle: api: check for propagation of error from platform_get_irq
Date: Sun, 27 Dec 2015 14:18:44 +0300 [thread overview]
Message-ID: <567FC914.4080705@cogentembedded.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1512270709420.2038@localhost6.localdomain6>
On 12/27/2015 9:13 AM, Julia Lawall wrote:
>> Well, looking again, the patch should be good. I just thought its goal was
>> to fix the code as well...
>
> I could do that for the irq < 0 case, but I think that in that case, kbuild
> will only run the patch version, and the <= cases will not be reported on.
> I don't have a general fix for the <= 0. Is it even correct to have < in
> some cases and <= in others?
That's a good question...
In my prior fixes of this case I preferred to consider IRQ0 valid and so
used 'irq < 0'. I myself don't share the "IRQ0 is invalid" sentiment...
> julia
MBR, Sergei
next prev parent reply other threads:[~2015-12-27 11:18 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-26 19:24 [Cocci] [PATCH] coccinelle: api: check for propagation of error from platform_get_irq Julia Lawall
2015-12-26 19:24 ` Julia Lawall
2015-12-26 19:24 ` Julia Lawall
2015-12-26 19:59 ` [Cocci] " Sergei Shtylyov
2015-12-26 19:59 ` Sergei Shtylyov
2015-12-26 19:59 ` Sergei Shtylyov
2015-12-26 20:08 ` [Cocci] " Julia Lawall
2015-12-26 20:08 ` Julia Lawall
2015-12-26 20:08 ` Julia Lawall
2015-12-26 20:24 ` [Cocci] " Julia Lawall
2015-12-26 20:24 ` Julia Lawall
2015-12-26 20:24 ` Julia Lawall
2015-12-26 20:29 ` [Cocci] " Sergei Shtylyov
2015-12-26 20:29 ` Sergei Shtylyov
2015-12-26 20:29 ` Sergei Shtylyov
2015-12-26 20:38 ` [Cocci] " Julia Lawall
2015-12-26 20:38 ` Julia Lawall
2015-12-26 20:38 ` Julia Lawall
2015-12-26 20:58 ` [Cocci] [PATCH v2] " Julia Lawall
2015-12-26 20:58 ` Julia Lawall
2015-12-26 20:58 ` Julia Lawall
2015-12-26 22:26 ` [Cocci] " Sergei Shtylyov
2015-12-26 22:26 ` Sergei Shtylyov
2015-12-26 22:26 ` Sergei Shtylyov
2015-12-26 22:26 ` Sergei Shtylyov
2015-12-26 22:32 ` [Cocci] " Julia Lawall
2015-12-26 22:32 ` Julia Lawall
2015-12-26 22:32 ` Julia Lawall
2015-12-26 22:32 ` Julia Lawall
2015-12-26 22:36 ` [Cocci] " Sergei Shtylyov
2015-12-26 22:36 ` Sergei Shtylyov
2015-12-26 22:36 ` Sergei Shtylyov
2015-12-27 6:13 ` [Cocci] " Julia Lawall
2015-12-27 6:13 ` Julia Lawall
2015-12-27 6:13 ` Julia Lawall
2015-12-27 6:13 ` Julia Lawall
2015-12-27 11:18 ` Sergei Shtylyov [this message]
2015-12-27 11:18 ` Sergei Shtylyov
2015-12-27 11:18 ` Sergei Shtylyov
2015-12-27 7:58 ` [Cocci] " SF Markus Elfring
2015-12-27 7:58 ` SF Markus Elfring
2015-12-27 7:58 ` SF Markus Elfring
2015-12-27 7:58 ` SF Markus Elfring
2015-12-27 11:41 ` Julia Lawall
2015-12-27 11:41 ` Julia Lawall
2015-12-27 11:41 ` Julia Lawall
2015-12-27 11:41 ` Julia Lawall
2015-12-27 16:24 ` SF Markus Elfring
2015-12-27 16:24 ` SF Markus Elfring
2015-12-27 16:24 ` SF Markus Elfring
2015-12-27 16:24 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=567FC914.4080705@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.