From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Arnd Bergmann <arnd@arndb.de>, Kukjin Kim <kgene@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH] ARM: s3c: simplify s3c_irqwake_{e,}intallow definition
Date: Mon, 28 Dec 2015 10:02:57 +0900 [thread overview]
Message-ID: <56808A41.2050105@samsung.com> (raw)
In-Reply-To: <16503982.4JeEM7ZXq8@wuerfel>
On 18.12.2015 23:45, Arnd Bergmann wrote:
> For a long time, gcc has warned about odd configurations on s3c64xx:
>
> In file included from arch/arm/plat-samsung/pm.c:34:0:
> arch/arm/mach-s3c64xx/include/mach/pm-core.h:61:0: warning: "s3c_irqwake_eintallow" redefined
> #define s3c_irqwake_eintallow ((1 << 28) - 1)
> In file included from arch/arm/plat-samsung/pm.c:33:0:
> arch/arm/plat-samsung/include/plat/pm.h:49:0: note: this is the location of the previous definition
> #define s3c_irqwake_eintallow 0
>
> The definitions of s3c_irqwake_intallow and s3c_irqwake_eintallow are a bit consistent
> between the various platforms. Things have become easier now that it's only s3c24xx
> and s3c64xx that use them at all, so I've tried to rearrange the definitions to
> make it more obvious what is going on.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> This fixes a very old and harmless warning, please apply to a cleanup branch
> if you agree.
>
Looks correct and makes sense. Hoping you compiled it on all machs:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: s3c: simplify s3c_irqwake_{e,}intallow definition
Date: Mon, 28 Dec 2015 10:02:57 +0900 [thread overview]
Message-ID: <56808A41.2050105@samsung.com> (raw)
In-Reply-To: <16503982.4JeEM7ZXq8@wuerfel>
On 18.12.2015 23:45, Arnd Bergmann wrote:
> For a long time, gcc has warned about odd configurations on s3c64xx:
>
> In file included from arch/arm/plat-samsung/pm.c:34:0:
> arch/arm/mach-s3c64xx/include/mach/pm-core.h:61:0: warning: "s3c_irqwake_eintallow" redefined
> #define s3c_irqwake_eintallow ((1 << 28) - 1)
> In file included from arch/arm/plat-samsung/pm.c:33:0:
> arch/arm/plat-samsung/include/plat/pm.h:49:0: note: this is the location of the previous definition
> #define s3c_irqwake_eintallow 0
>
> The definitions of s3c_irqwake_intallow and s3c_irqwake_eintallow are a bit consistent
> between the various platforms. Things have become easier now that it's only s3c24xx
> and s3c64xx that use them at all, so I've tried to rearrange the definitions to
> make it more obvious what is going on.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> This fixes a very old and harmless warning, please apply to a cleanup branch
> if you agree.
>
Looks correct and makes sense. Hoping you compiled it on all machs:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2015-12-28 1:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 14:45 [PATCH] ARM: s3c: simplify s3c_irqwake_{e,}intallow definition Arnd Bergmann
2015-12-18 14:45 ` Arnd Bergmann
2015-12-28 1:02 ` Krzysztof Kozlowski [this message]
2015-12-28 1:02 ` Krzysztof Kozlowski
2015-12-28 11:13 ` Arnd Bergmann
2015-12-28 11:13 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56808A41.2050105@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=arnd@arndb.de \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.