From: Sven Eckelmann <sven@narfation.org>
To: Jakub Kicinski <kuba@kernel.org>,
Simon Wunderlich <sw@simonwunderlich.de>,
Paolo Abeni <pabeni@redhat.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
b.a.t.m.a.n@lists.open-mesh.org,
Vladislav Efanov <VEfanov@ispras.ru>,
stable@kernel.org
Subject: Re: [PATCH 1/1] batman-adv: Broken sync while rescheduling delayed work
Date: Thu, 08 Jun 2023 18:57:44 +0200 [thread overview]
Message-ID: <5681063.DvuYhMxLoT@ripper> (raw)
In-Reply-To: <6a36f208b961181df9a0c611a6f5ffc4c76911f6.camel@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 661 bytes --]
On Thursday, 8 June 2023 11:27:31 CEST Paolo Abeni wrote:
[...]
> > We're still not preventing the timer / work from getting scheduled
> > and staying alive after the netdev has been freed, right?
>
> I *think* this specific use case does not expose such problem, as the
> delayed work is (AFAICS) scheduled only at device creation time and by
> the work itself, it should never be re-scheduled after
> cancel_delayed_work_sync()
Correct.
* batadv_dat_start_timer is the only thing scheduling it
* batadv_dat_start_timer is called by:
- batadv_dat_purge (the worker rearming itself)
- batadv_dat_init (when the interface is created)
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2023-06-08 16:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 15:55 [PATCH 0/1] pull request for net: batman-adv 2023-06-07 Simon Wunderlich
2023-06-07 15:55 ` Simon Wunderlich
2023-06-07 15:55 ` [PATCH 1/1] batman-adv: Broken sync while rescheduling delayed work Simon Wunderlich
2023-06-08 5:00 ` patchwork-bot+netdevbpf
2023-06-08 5:00 ` patchwork-bot+netdevbpf
2023-06-08 5:01 ` Jakub Kicinski
2023-06-08 5:01 ` Jakub Kicinski
2023-06-08 5:24 ` Keller, Jacob E
2023-06-08 5:24 ` Keller, Jacob E
2023-06-08 9:01 ` Vlad Efanov
2023-06-08 9:01 ` Vlad Efanov
2023-06-08 9:27 ` Paolo Abeni
2023-06-08 9:27 ` Paolo Abeni
2023-06-08 16:57 ` Sven Eckelmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5681063.DvuYhMxLoT@ripper \
--to=sven@narfation.org \
--cc=VEfanov@ispras.ru \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@kernel.org \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.