From: Jakub Kicinski <kuba@kernel.org>
To: Simon Wunderlich <sw@simonwunderlich.de>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
b.a.t.m.a.n@lists.open-mesh.org,
Vladislav Efanov <VEfanov@ispras.ru>,
stable@kernel.org
Subject: Re: [PATCH 1/1] batman-adv: Broken sync while rescheduling delayed work
Date: Wed, 7 Jun 2023 22:01:26 -0700 [thread overview]
Message-ID: <20230607220126.26c6ee40@kernel.org> (raw)
In-Reply-To: <20230607155515.548120-2-sw@simonwunderlich.de>
On Wed, 7 Jun 2023 17:55:15 +0200 Simon Wunderlich wrote:
> The reason for these issues is the lack of synchronization. Delayed
> work (batadv_dat_purge) schedules new timer/work while the device
> is being deleted. As the result new timer/delayed work is set after
> cancel_delayed_work_sync() was called. So after the device is freed
> the timer list contains pointer to already freed memory.
I guess this is better than status quo but is the fix really complete?
We're still not preventing the timer / work from getting scheduled
and staying alive after the netdev has been freed, right?
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Simon Wunderlich <sw@simonwunderlich.de>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
b.a.t.m.a.n@lists.open-mesh.org,
Vladislav Efanov <VEfanov@ispras.ru>,
stable@kernel.org, Sven Eckelmann <sven@narfation.org>
Subject: Re: [PATCH 1/1] batman-adv: Broken sync while rescheduling delayed work
Date: Wed, 7 Jun 2023 22:01:26 -0700 [thread overview]
Message-ID: <20230607220126.26c6ee40@kernel.org> (raw)
In-Reply-To: <20230607155515.548120-2-sw@simonwunderlich.de>
On Wed, 7 Jun 2023 17:55:15 +0200 Simon Wunderlich wrote:
> The reason for these issues is the lack of synchronization. Delayed
> work (batadv_dat_purge) schedules new timer/work while the device
> is being deleted. As the result new timer/delayed work is set after
> cancel_delayed_work_sync() was called. So after the device is freed
> the timer list contains pointer to already freed memory.
I guess this is better than status quo but is the fix really complete?
We're still not preventing the timer / work from getting scheduled
and staying alive after the netdev has been freed, right?
next prev parent reply other threads:[~2023-06-08 6:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 15:55 [PATCH 0/1] pull request for net: batman-adv 2023-06-07 Simon Wunderlich
2023-06-07 15:55 ` Simon Wunderlich
2023-06-07 15:55 ` [PATCH 1/1] batman-adv: Broken sync while rescheduling delayed work Simon Wunderlich
2023-06-08 5:00 ` patchwork-bot+netdevbpf
2023-06-08 5:00 ` patchwork-bot+netdevbpf
2023-06-08 5:01 ` Jakub Kicinski [this message]
2023-06-08 5:01 ` Jakub Kicinski
2023-06-08 5:24 ` Keller, Jacob E
2023-06-08 5:24 ` Keller, Jacob E
2023-06-08 9:01 ` Vlad Efanov
2023-06-08 9:01 ` Vlad Efanov
2023-06-08 9:27 ` Paolo Abeni
2023-06-08 9:27 ` Paolo Abeni
2023-06-08 16:57 ` Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230607220126.26c6ee40@kernel.org \
--to=kuba@kernel.org \
--cc=VEfanov@ispras.ru \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=stable@kernel.org \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.