From: Chen Gang <chengang@emindsoft.com.cn>
To: Joerg Roedel <joro@8bytes.org>
Cc: akpm@linux-foundation.org, oded.gabbay@gmail.com,
airlied@linux.ie, joe@perches.com, jslaby@suse.com,
gregkh@linuxfoundation.org, davem@davemloft.net,
mchehab@osg.samsung.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] include/linux/amd-iommu.h: Move to arch/x86/include/asm
Date: Tue, 29 Dec 2015 04:40:27 +0800 [thread overview]
Message-ID: <56819E3B.20506@emindsoft.com.cn> (raw)
In-Reply-To: <20151228155153.GM18805@8bytes.org>
On 12/28/15 23:51, Joerg Roedel wrote:
> On Sat, Dec 26, 2015 at 09:26:32PM +0800, chengang@emindsoft.com.cn wrote:
>>
>> It is architecture specific mechanism header, not generic header, so
>> move it to arch/x86/include/asm.
>
> There might be future non-x86 hardware which also has an amd iommu, so
> the header file should stay where it is for now.
>
For me, amd-iommu.h is architecture specific, for this kind of headers,
if it is used by most of archs, it will be in "include/asm-generic". If
it is used by several archs, it will be in "arch/*/include/asm/".
So for me, at present, it is only used by x86, so is move to "arch/x86/
include/asm/"; if another archs want it, they can copy one. If quite a
few archs (e.g. > 3 archs) need it, move it to "include/asm-generic".
Thanks.
--
Chen Gang (陈刚)
Open, share, and attitude like air, water, and life which God blessed
prev parent reply other threads:[~2015-12-28 20:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-26 13:26 [PATCH] include/linux/amd-iommu.h: Move to arch/x86/include/asm chengang
2015-12-28 15:51 ` Joerg Roedel
2015-12-28 20:40 ` Chen Gang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56819E3B.20506@emindsoft.com.cn \
--to=chengang@emindsoft.com.cn \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=joro@8bytes.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=oded.gabbay@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.