* Re: Each grub-mkrescue run leaves a file in /tmp/ [not found] <21871572876213560699@scdbackup.webframe.org> @ 2015-12-28 3:40 ` Andrei Borzenkov 2015-12-29 16:51 ` Vladimir 'φ-coder/phcoder' Serbinenko 0 siblings, 1 reply; 6+ messages in thread From: Andrei Borzenkov @ 2015-12-28 3:40 UTC (permalink / raw) To: bug-grub; +Cc: The development of GNU GRUB [-- Attachment #1: Type: text/plain, Size: 850 bytes --] 27.12.2015 23:48, Thomas Schmitt пишет: > Hi, > > when running grub-mkrescue from Debian Sid, i get a > growing collection of files in /tmp. One per run. > > Names are like: > /tmp/grub.00529W > > Content is always the same: > insmod part_acorn > insmod part_amiga > insmod part_apple > insmod part_bsd > insmod part_dfly > insmod part_dvh > insmod part_gpt > insmod part_msdos > insmod part_plan > insmod part_sun > insmod part_sunpc > That's load.cfg used to build image. I'm surprised this is the only one left, there should be more. > grub-mkrescue -V > grub-mkrescue (GRUB) 2.02~beta2-33 > > Where to report ? Upstream or distro ? > Yes, I have this hanging around. Not because of garbage in /tmp, but to better documentation of generated image (load.cfg is stored by grub-install as well). Vladimir? [-- Attachment #2: load_cfg.patch --] [-- Type: text/x-patch, Size: 2358 bytes --] From: Andrey Borzenkov <arvidjaar@gmail.com> Subject: [PATCH] grub-mkrescue: save load.cfg in image platform directory --- util/grub-mkrescue.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/util/grub-mkrescue.c b/util/grub-mkrescue.c index 4511826..ed86d44 100644 --- a/util/grub-mkrescue.c +++ b/util/grub-mkrescue.c @@ -257,7 +257,9 @@ make_image_abs (enum grub_install_plat plat, grub_util_info (N_("enabling %s support ..."), mkimage_target); - load_cfg = grub_util_make_temporary_file (); + load_cfg = grub_util_path_concat (3, boot_grub, + grub_install_get_platform_name (plat), + "load.cfg"); load_cfg_f = grub_util_fopen (load_cfg, "wb"); fprintf (load_cfg_f, "search --fs-uuid --set=root %s\n", iso_uuid); @@ -273,7 +275,7 @@ make_image_abs (enum grub_install_plat plat, mkimage_target, 0); grub_install_pop_module (); grub_install_pop_module (); - grub_util_unlink (load_cfg); + free (load_cfg); } static void @@ -300,7 +302,9 @@ make_image_fwdisk_abs (enum grub_install_plat plat, grub_util_info (N_("enabling %s support ..."), mkimage_target); - load_cfg = grub_util_make_temporary_file (); + load_cfg = grub_util_path_concat (3, boot_grub, + grub_install_get_platform_name (plat), + "load.cfg"); load_cfg_f = grub_util_fopen (load_cfg, "wb"); write_part (load_cfg_f, source_dirs[plat]); @@ -310,6 +314,7 @@ make_image_fwdisk_abs (enum grub_install_plat plat, grub_install_make_image_wrap (source_dirs[plat], "()/boot/grub", output, 0, load_cfg, mkimage_target, 0); grub_install_pop_module (); + free (load_cfg); } static int @@ -572,7 +577,7 @@ main (int argc, char *argv[]) char *load_cfg; FILE *load_cfg_f; char *output = grub_util_path_concat (3, boot_grub, "i386-pc", "eltorito.img"); - load_cfg = grub_util_make_temporary_file (); + load_cfg = grub_util_path_concat (3, boot_grub, "i386-pc", "load.cfg"); grub_util_info (N_("enabling %s support ..."), "BIOS"); load_cfg_f = grub_util_fopen (load_cfg, "wb"); @@ -647,6 +652,7 @@ main (int argc, char *argv[]) } grub_install_pop_module (); grub_install_pop_module (); + free (load_cfg); } /** build multiboot core.img */ -- tg: (3bca85b..) u/load_cfg (depends on: master) ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: Each grub-mkrescue run leaves a file in /tmp/ 2015-12-28 3:40 ` Each grub-mkrescue run leaves a file in /tmp/ Andrei Borzenkov @ 2015-12-29 16:51 ` Vladimir 'φ-coder/phcoder' Serbinenko 2015-12-29 18:04 ` Andrei Borzenkov 0 siblings, 1 reply; 6+ messages in thread From: Vladimir 'φ-coder/phcoder' Serbinenko @ 2015-12-29 16:51 UTC (permalink / raw) To: The development of GNU GRUB [-- Attachment #1: Type: text/plain, Size: 1289 bytes --] On 28.12.2015 04:40, Andrei Borzenkov wrote: > 27.12.2015 23:48, Thomas Schmitt пишет: >> Hi, >> >> when running grub-mkrescue from Debian Sid, i get a >> growing collection of files in /tmp. One per run. >> >> Names are like: >> /tmp/grub.00529W >> >> Content is always the same: >> insmod part_acorn >> insmod part_amiga >> insmod part_apple >> insmod part_bsd >> insmod part_dfly >> insmod part_dvh >> insmod part_gpt >> insmod part_msdos >> insmod part_plan >> insmod part_sun >> insmod part_sunpc >> > > That's load.cfg used to build image. I'm surprised this is the only one > left, there should be more. > >> grub-mkrescue -V >> grub-mkrescue (GRUB) 2.02~beta2-33 >> >> Where to report ? Upstream or distro ? >> > > Yes, I have this hanging around. Not because of garbage in /tmp, but to > better documentation of generated image (load.cfg is stored by > grub-install as well). > > Vladimir? > Fixed. It was just omission of delete. We leave load.cfg in our directory (boot/grub) but it makes no sense to leave anything in temp > > > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel > [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 213 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Each grub-mkrescue run leaves a file in /tmp/ 2015-12-29 16:51 ` Vladimir 'φ-coder/phcoder' Serbinenko @ 2015-12-29 18:04 ` Andrei Borzenkov 2015-12-29 18:13 ` Vladimir 'phcoder' Serbinenko 0 siblings, 1 reply; 6+ messages in thread From: Andrei Borzenkov @ 2015-12-29 18:04 UTC (permalink / raw) To: grub-devel [-- Attachment #1: Type: text/plain, Size: 1195 bytes --] 29.12.2015 19:51, Vladimir 'φ-coder/phcoder' Serbinenko пишет: > On 28.12.2015 04:40, Andrei Borzenkov wrote: >> 27.12.2015 23:48, Thomas Schmitt пишет: >>> Hi, >>> >>> when running grub-mkrescue from Debian Sid, i get a >>> growing collection of files in /tmp. One per run. >>> >>> Names are like: >>> /tmp/grub.00529W >>> >>> Content is always the same: >>> insmod part_acorn >>> insmod part_amiga >>> insmod part_apple >>> insmod part_bsd >>> insmod part_dfly >>> insmod part_dvh >>> insmod part_gpt >>> insmod part_msdos >>> insmod part_plan >>> insmod part_sun >>> insmod part_sunpc >>> >> >> That's load.cfg used to build image. I'm surprised this is the only one >> left, there should be more. >> >>> grub-mkrescue -V >>> grub-mkrescue (GRUB) 2.02~beta2-33 >>> >>> Where to report ? Upstream or distro ? >>> >> >> Yes, I have this hanging around. Not because of garbage in /tmp, but to >> better documentation of generated image (load.cfg is stored by >> grub-install as well). >> >> Vladimir? >> > Fixed. It was just omission of delete. We leave load.cfg in our > directory (boot/grub) No, we do not. [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 198 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Each grub-mkrescue run leaves a file in /tmp/ 2015-12-29 18:04 ` Andrei Borzenkov @ 2015-12-29 18:13 ` Vladimir 'phcoder' Serbinenko 2015-12-29 18:31 ` Andrei Borzenkov 0 siblings, 1 reply; 6+ messages in thread From: Vladimir 'phcoder' Serbinenko @ 2015-12-29 18:13 UTC (permalink / raw) To: The development of GRUB 2 [-- Attachment #1: Type: text/plain, Size: 1737 bytes --] Le 29 déc. 2015 7:05 PM, "Andrei Borzenkov" <arvidjaar@gmail.com> a écrit : > > 29.12.2015 19:51, Vladimir 'φ-coder/phcoder' Serbinenko пишет: > > On 28.12.2015 04:40, Andrei Borzenkov wrote: > >> 27.12.2015 23:48, Thomas Schmitt пишет: > >>> Hi, > >>> > >>> when running grub-mkrescue from Debian Sid, i get a > >>> growing collection of files in /tmp. One per run. > >>> > >>> Names are like: > >>> /tmp/grub.00529W > >>> > >>> Content is always the same: > >>> insmod part_acorn > >>> insmod part_amiga > >>> insmod part_apple > >>> insmod part_bsd > >>> insmod part_dfly > >>> insmod part_dvh > >>> insmod part_gpt > >>> insmod part_msdos > >>> insmod part_plan > >>> insmod part_sun > >>> insmod part_sunpc > >>> > >> > >> That's load.cfg used to build image. I'm surprised this is the only one > >> left, there should be more. > >> > >>> grub-mkrescue -V > >>> grub-mkrescue (GRUB) 2.02~beta2-33 > >>> > >>> Where to report ? Upstream or distro ? > >>> > >> > >> Yes, I have this hanging around. Not because of garbage in /tmp, but to > >> better documentation of generated image (load.cfg is stored by > >> grub-install as well). > >> > >> Vladimir? > >> > > Fixed. It was just omission of delete. We leave load.cfg in our > > directory (boot/grub) > > No, we do not. > > I meant in grub-install case. I don't think we need to waste space on ISO in mkrescue case. We shouldn't leave any files behind in temp for normal operation. We can have an option to leave them if it's useful > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel > [-- Attachment #2: Type: text/html, Size: 2671 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Each grub-mkrescue run leaves a file in /tmp/ 2015-12-29 18:13 ` Vladimir 'phcoder' Serbinenko @ 2015-12-29 18:31 ` Andrei Borzenkov 2015-12-29 18:55 ` Vladimir 'phcoder' Serbinenko 0 siblings, 1 reply; 6+ messages in thread From: Andrei Borzenkov @ 2015-12-29 18:31 UTC (permalink / raw) To: grub-devel 29.12.2015 21:13, Vladimir 'phcoder' Serbinenko пишет: > Le 29 déc. 2015 7:05 PM, "Andrei Borzenkov" <arvidjaar@gmail.com> a écrit : >> >> 29.12.2015 19:51, Vladimir 'φ-coder/phcoder' Serbinenko пишет: >>> On 28.12.2015 04:40, Andrei Borzenkov wrote: >>>> 27.12.2015 23:48, Thomas Schmitt пишет: >>>>> Hi, >>>>> >>>>> when running grub-mkrescue from Debian Sid, i get a >>>>> growing collection of files in /tmp. One per run. >>>>> >>>>> Names are like: >>>>> /tmp/grub.00529W >>>>> >>>>> Content is always the same: >>>>> insmod part_acorn >>>>> insmod part_amiga >>>>> insmod part_apple >>>>> insmod part_bsd >>>>> insmod part_dfly >>>>> insmod part_dvh >>>>> insmod part_gpt >>>>> insmod part_msdos >>>>> insmod part_plan >>>>> insmod part_sun >>>>> insmod part_sunpc >>>>> >>>> >>>> That's load.cfg used to build image. I'm surprised this is the only one >>>> left, there should be more. >>>> >>>>> grub-mkrescue -V >>>>> grub-mkrescue (GRUB) 2.02~beta2-33 >>>>> >>>>> Where to report ? Upstream or distro ? >>>>> >>>> >>>> Yes, I have this hanging around. Not because of garbage in /tmp, but to >>>> better documentation of generated image (load.cfg is stored by >>>> grub-install as well). >>>> >>>> Vladimir? >>>> >>> Fixed. It was just omission of delete. We leave load.cfg in our >>> directory (boot/grub) >> >> No, we do not. >> >> > I meant in grub-install case. I don't think we need to waste space on ISO > in mkrescue case. We shouldn't leave any files behind in temp for normal > operation. Ehem ... https://lists.gnu.org/archive/html/grub-devel/2014-09/msg00045.html :) ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Each grub-mkrescue run leaves a file in /tmp/ 2015-12-29 18:31 ` Andrei Borzenkov @ 2015-12-29 18:55 ` Vladimir 'phcoder' Serbinenko 0 siblings, 0 replies; 6+ messages in thread From: Vladimir 'phcoder' Serbinenko @ 2015-12-29 18:55 UTC (permalink / raw) To: The development of GRUB 2 [-- Attachment #1: Type: text/plain, Size: 2252 bytes --] Le 29 déc. 2015 7:32 PM, "Andrei Borzenkov" <arvidjaar@gmail.com> a écrit : > > 29.12.2015 21:13, Vladimir 'phcoder' Serbinenko пишет: > > Le 29 déc. 2015 7:05 PM, "Andrei Borzenkov" <arvidjaar@gmail.com> a écrit : > >> > >> 29.12.2015 19:51, Vladimir 'φ-coder/phcoder' Serbinenko пишет: > >>> On 28.12.2015 04:40, Andrei Borzenkov wrote: > >>>> 27.12.2015 23:48, Thomas Schmitt пишет: > >>>>> Hi, > >>>>> > >>>>> when running grub-mkrescue from Debian Sid, i get a > >>>>> growing collection of files in /tmp. One per run. > >>>>> > >>>>> Names are like: > >>>>> /tmp/grub.00529W > >>>>> > >>>>> Content is always the same: > >>>>> insmod part_acorn > >>>>> insmod part_amiga > >>>>> insmod part_apple > >>>>> insmod part_bsd > >>>>> insmod part_dfly > >>>>> insmod part_dvh > >>>>> insmod part_gpt > >>>>> insmod part_msdos > >>>>> insmod part_plan > >>>>> insmod part_sun > >>>>> insmod part_sunpc > >>>>> > >>>> > >>>> That's load.cfg used to build image. I'm surprised this is the only one > >>>> left, there should be more. > >>>> > >>>>> grub-mkrescue -V > >>>>> grub-mkrescue (GRUB) 2.02~beta2-33 > >>>>> > >>>>> Where to report ? Upstream or distro ? > >>>>> > >>>> > >>>> Yes, I have this hanging around. Not because of garbage in /tmp, but to > >>>> better documentation of generated image (load.cfg is stored by > >>>> grub-install as well). > >>>> > >>>> Vladimir? > >>>> > >>> Fixed. It was just omission of delete. We leave load.cfg in our > >>> directory (boot/grub) > >> > >> No, we do not. > >> > >> > > I meant in grub-install case. I don't think we need to waste space on ISO > > in mkrescue case. We shouldn't leave any files behind in temp for normal > > operation. > > Ehem ... https://lists.gnu.org/archive/html/grub-devel/2014-09/msg00045.html > > :) > Nice find. Shows that experience and good arguments make people change mind. In this case I never had to actually look into this file for mkrescue, which show that it wasn't as useful as I have thought > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel [-- Attachment #2: Type: text/html, Size: 3699 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-12-29 18:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <21871572876213560699@scdbackup.webframe.org>
2015-12-28 3:40 ` Each grub-mkrescue run leaves a file in /tmp/ Andrei Borzenkov
2015-12-29 16:51 ` Vladimir 'φ-coder/phcoder' Serbinenko
2015-12-29 18:04 ` Andrei Borzenkov
2015-12-29 18:13 ` Vladimir 'phcoder' Serbinenko
2015-12-29 18:31 ` Andrei Borzenkov
2015-12-29 18:55 ` Vladimir 'phcoder' Serbinenko
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.