All of lore.kernel.org
 help / color / mirror / Atom feed
From: sudeep.holla@arm.com (Sudeep Holla)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: Add DT support for Juno r2 board
Date: Wed, 30 Dec 2015 15:34:09 +0000	[thread overview]
Message-ID: <5683F971.9000300@arm.com> (raw)
In-Reply-To: <CAL_Jsq+RZk3LnOhGtiXRFmxmA6bTOEdymtF1yN=6q=iRmUr_9Q@mail.gmail.com>



On 30/12/15 15:09, Rob Herring wrote:
> On Wed, Dec 30, 2015 at 5:22 AM, Sudeep Holla <sudeep.holla@arm.com> wrote:
>> Hi Rob,
>>
>> Thanks for the review.
>>
>> On 29/12/15 18:35, Rob Herring wrote:
>>>
>>> On Wed, Dec 23, 2015 at 12:10:11PM +0000, Sudeep Holla wrote:
>>>>
>>>> Juno r2 is identical to Juno r1 with Cortex A57 cores replaced by
>>>> Cortex A72 cores.
>>>
>>>
>>> That's a bigger change than I'd expect...
>>>
>>
>> I am not sure if I understood what you meant by that. Do you want me to
>> elaborate with more details ?
>
> No, just my commentary that I'd expect r1 -> r2 to be a board or Si
> spin rather than a whole new core.
>

Ah OK, yes it's new Si and has other minor updates like latest revisions
of Cortex-A53 and other IPs. I just mentioned only the DT visible
changes in the commit log.

>>>> Acked-by: Liviu Dudau <Liviu.Dudau@arm.com>
>>>> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
>>>> ---
>>>>    Documentation/devicetree/bindings/arm/arm-boards |   1 +
>>>>    Documentation/devicetree/bindings/arm/cpus.txt   |   1 +
>>>
>>>
>>> This should probably be a separate patch, but I already have a patch in
>>> my tree for 4.5 adding arm,cortex-a72. So just drop this hunk.
>>>
>>
>> OK, will post DT binding separately.
>
> No need, it is already in my tree.
>

Sorry for not being clear earlier. I was referring the "arm,juno-r2"
compatible addition. I assume you have no objection if it's part of the
same patch.

>>>> +       pcie-controller at 40000000 {
>>>> +               compatible = "arm,juno-r1-pcie", "plda,xpressrich3-axi",
>>>> "pci-host-ecam-generic";
>>>
>>>
>>> Is this common with r1?
>>>
>>
>> AFAIK it is. Liviu can you confirm ?
>
> Then perhaps you should move this to a common spot.
>

True, will wait for Liviu's response.

-- 
Regards,
Sudeep

WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla-5wv7dgnIgG8@public.gmane.org>
To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Sudeep Holla <sudeep.holla-5wv7dgnIgG8@public.gmane.org>,
	Liviu Dudau <Liviu.Dudau-5wv7dgnIgG8@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	arm-hC8oa7XEHlfYtjvyW6yDsg@public.gmane.org,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
	Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
	Kevin Hilman <khilman-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH] arm64: Add DT support for Juno r2 board
Date: Wed, 30 Dec 2015 15:34:09 +0000	[thread overview]
Message-ID: <5683F971.9000300@arm.com> (raw)
In-Reply-To: <CAL_Jsq+RZk3LnOhGtiXRFmxmA6bTOEdymtF1yN=6q=iRmUr_9Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>



On 30/12/15 15:09, Rob Herring wrote:
> On Wed, Dec 30, 2015 at 5:22 AM, Sudeep Holla <sudeep.holla-5wv7dgnIgG8@public.gmane.org> wrote:
>> Hi Rob,
>>
>> Thanks for the review.
>>
>> On 29/12/15 18:35, Rob Herring wrote:
>>>
>>> On Wed, Dec 23, 2015 at 12:10:11PM +0000, Sudeep Holla wrote:
>>>>
>>>> Juno r2 is identical to Juno r1 with Cortex A57 cores replaced by
>>>> Cortex A72 cores.
>>>
>>>
>>> That's a bigger change than I'd expect...
>>>
>>
>> I am not sure if I understood what you meant by that. Do you want me to
>> elaborate with more details ?
>
> No, just my commentary that I'd expect r1 -> r2 to be a board or Si
> spin rather than a whole new core.
>

Ah OK, yes it's new Si and has other minor updates like latest revisions
of Cortex-A53 and other IPs. I just mentioned only the DT visible
changes in the commit log.

>>>> Acked-by: Liviu Dudau <Liviu.Dudau-5wv7dgnIgG8@public.gmane.org>
>>>> Signed-off-by: Sudeep Holla <sudeep.holla-5wv7dgnIgG8@public.gmane.org>
>>>> ---
>>>>    Documentation/devicetree/bindings/arm/arm-boards |   1 +
>>>>    Documentation/devicetree/bindings/arm/cpus.txt   |   1 +
>>>
>>>
>>> This should probably be a separate patch, but I already have a patch in
>>> my tree for 4.5 adding arm,cortex-a72. So just drop this hunk.
>>>
>>
>> OK, will post DT binding separately.
>
> No need, it is already in my tree.
>

Sorry for not being clear earlier. I was referring the "arm,juno-r2"
compatible addition. I assume you have no objection if it's part of the
same patch.

>>>> +       pcie-controller@40000000 {
>>>> +               compatible = "arm,juno-r1-pcie", "plda,xpressrich3-axi",
>>>> "pci-host-ecam-generic";
>>>
>>>
>>> Is this common with r1?
>>>
>>
>> AFAIK it is. Liviu can you confirm ?
>
> Then perhaps you should move this to a common spot.
>

True, will wait for Liviu's response.

-- 
Regards,
Sudeep
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2015-12-30 15:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-23 12:10 [PATCH] arm64: Add DT support for Juno r2 board Sudeep Holla
2015-12-23 12:10 ` Sudeep Holla
2015-12-29 18:35 ` Rob Herring
2015-12-29 18:35   ` Rob Herring
2015-12-30 11:22   ` Sudeep Holla
2015-12-30 11:22     ` Sudeep Holla
2015-12-30 15:09     ` Rob Herring
2015-12-30 15:09       ` Rob Herring
2015-12-30 15:34       ` Sudeep Holla [this message]
2015-12-30 15:34         ` Sudeep Holla
2016-01-11 11:09         ` Liviu Dudau
2016-01-11 11:09           ` Liviu Dudau
2016-01-11 11:12           ` Sudeep Holla
2016-01-11 11:12             ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5683F971.9000300@arm.com \
    --to=sudeep.holla@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.