From: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Or Gerlitz <gerlitz.or-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Yishai Hadas <yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Majd Dibbiny <majd-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH for-next 5/7] IB/mlx4: Enable send of RoCE QP1 packets with IP/UDP headers
Date: Thu, 31 Dec 2015 09:04:05 +0200 [thread overview]
Message-ID: <5684D365.1010607@mellanox.com> (raw)
In-Reply-To: <CAG9sBKMOE1ULAnL=OWiSYc76vgi8jiuhnQxY3Li9NwGy3+r7oQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 12/30/2015 1:04 PM, Moni Shoua wrote:
>> The last hunk that you removed had a role and was by no means
>> dead-code, right? so... (1) why it's correct to remove it? (2) if you
>> want to introduce different way to implement what was done here, why
>> in this patch? maybe add pre-patch for that
> In a way you are right. This hunk does not insert a bug and even
> improves correctness but it acutally belongs to an earlier patch
> (dbf727de7440f73c4b92be4b958cbc24977e8ca2 IB/core: Use GID table in AH
> creation and dmac resolution)
so what's the plan here? avoid deleting it?
Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-12-31 7:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-29 13:24 [PATCH for-next 0/7] Add RoCE v2 support for mlx4 driver Matan Barak
[not found] ` <1451395447-5198-1-git-send-email-matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-12-29 13:24 ` [PATCH for-next 1/7] IB/mlx4: Query RoCE support Matan Barak
[not found] ` <1451395447-5198-2-git-send-email-matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-12-29 15:19 ` Or Gerlitz
[not found] ` <5682A499.9040701-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-12-30 8:27 ` Matan Barak
[not found] ` <5683957B.1070401-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-12-30 8:44 ` Or Gerlitz
[not found] ` <5683997E.9090307-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-12-30 11:11 ` Matan Barak
2015-12-29 13:24 ` [PATCH for-next 2/7] IB/mlx4: Add RoCE per GID support for add_gid and del_gid Matan Barak
[not found] ` <1451395447-5198-3-git-send-email-matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-12-29 15:24 ` Or Gerlitz
[not found] ` <5682A5AA.9040709-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-12-30 10:21 ` Matan Barak
2015-12-29 13:24 ` [PATCH for-next 3/7] IB/mlx4: Configure device to work in RoCEv2 Matan Barak
[not found] ` <1451395447-5198-4-git-send-email-matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-12-29 14:37 ` Or Gerlitz
[not found] ` <56829AB0.3080805-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-12-30 8:23 ` Matan Barak
[not found] ` <56839469.3070508-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-12-30 8:46 ` Or Gerlitz
2015-12-29 13:24 ` [PATCH for-next 4/7] net/mlx4_core: Add handlning of RoCE v2 over IPV4 in attach_flow Matan Barak
[not found] ` <1451395447-5198-5-git-send-email-matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-12-29 14:28 ` Or Gerlitz
2015-12-29 13:24 ` [PATCH for-next 5/7] IB/mlx4: Enable send of RoCE QP1 packets with IP/UDP headers Matan Barak
[not found] ` <1451395447-5198-6-git-send-email-matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-12-29 19:01 ` Or Gerlitz
[not found] ` <CAJ3xEMgVvpj5S9gc_3onzCU5zjkXayOEZCCk_DofAwz194s8KQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-12-30 11:04 ` Moni Shoua
[not found] ` <CAG9sBKMOE1ULAnL=OWiSYc76vgi8jiuhnQxY3Li9NwGy3+r7oQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-12-31 7:04 ` Or Gerlitz [this message]
2015-12-29 13:24 ` [PATCH for-next 6/7] IB/mlx4: Create and use another QP1 for RoCEv2 Matan Barak
[not found] ` <1451395447-5198-7-git-send-email-matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-12-29 14:42 ` Or Gerlitz
[not found] ` <56829BC4.2070709-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-12-30 8:24 ` Matan Barak
2015-12-29 13:24 ` [PATCH for-next 7/7] IB/mlx4: Advertise RoCE support Matan Barak
[not found] ` <1451395447-5198-8-git-send-email-matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-12-29 14:44 ` Or Gerlitz
[not found] ` <56829C3D.5050009-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-12-30 8:25 ` Matan Barak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5684D365.1010607@mellanox.com \
--to=ogerlitz-vpraknaxozvwk0htik3j/w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=gerlitz.or-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=majd-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.