From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH] arm64: build with -mcmodel=large
Date: Thu, 31 Dec 2015 13:52:44 +0100 [thread overview]
Message-ID: <5685251C.4000600@gmail.com> (raw)
In-Reply-To: <20151225181855.GU25034@bivouac.eciton.net>
[-- Attachment #1: Type: text/plain, Size: 2099 bytes --]
On 25.12.2015 19:18, Leif Lindholm wrote:
> On Thu, Dec 24, 2015 at 04:20:29AM +0000, Colin Watson wrote:
>> On Thu, Dec 24, 2015 at 04:14:20AM +0000, Colin Watson wrote:
>>> This fixes a build failure with very current GCC versions, such as the one
>>> in Ubuntu xenial. Leif (or anyone with suitable arm64 systems), would you
>>> mind testing that this doesn't break things? I've tested that it builds
>>> cleanly now, but I don't have a particularly convenient way to do any
>>> run-time tests.
>>
>> Never mind, I spoke too soon and withdraw this patch, since this doesn't
>> actually fix the problem, which is:
>>
>> $ obj/grub-efi-arm64/grub-mkimage -O arm64-efi -o test.efi -d obj/grub-efi-arm64/grub-core -p /boot/grub -v ext2
>> obj/grub-efi-arm64/grub-mkimage: info: the total module size is 0x37e8.
>
> *snip*
>
>> obj/grub-efi-arm64/grub-mkimage: info: dealing with the relocation section .rela.text for .text.
>> obj/grub-efi-arm64/grub-mkimage: error: relocation 0x113 is not implemented yet.
>>
>> Would anyone arm64-knowledgeable mind taking a look at this?
>
> So, it seems this toolchain generates the HI21/LO12 relocation combo:
> - R_AARCH64_ADR_PREL_PG_HI21/R_AARCH64_ADR_PREL_PG_HI21_NC
> - R_AARCH64_LDST16_ABS_LO12_NC
> - R_AARCH64_LDST32_ABS_LO12_NC
> - R_AARCH64_LDST64_ABS_LO12_NC
> - R_AARCH64_LDST128_ABS_LO12_NC
>
> So I'll implement support for these.
>
I'm looking forward for those patches
Unfortunately missing relocation support is common problem. I added a
verifier in build system to catch it on build time rather than runtime
> With regards to your -mcmodel=large patch - that didn't change
> anything because I already hardcoded that into
> conf/Makefile.common. Your suggested patch is probably the better way
> of doing it - so do consider pushing that anyway (dropping the
> Makefile.common stanza at the same time).
>
> /
> Leif
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]
next prev parent reply other threads:[~2015-12-31 12:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-24 4:14 [PATCH] arm64: build with -mcmodel=large Colin Watson
2015-12-24 4:14 ` Colin Watson
2015-12-24 4:20 ` Colin Watson
2015-12-25 18:18 ` Leif Lindholm
2015-12-31 12:52 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2015-12-31 16:09 ` Vladimir 'φ-coder/phcoder' Serbinenko
2016-01-22 2:14 ` Colin Watson
2016-01-22 18:13 ` Vladimir 'φ-coder/phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5685251C.4000600@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.