* [Qemu-devel] [PATCH v3] linux-user/mmap.c: Always zero MAP_ANONYMOUS memory in mmap_frag()
@ 2015-12-30 1:10 chengang
2015-12-30 1:14 ` Laurent Vivier
0 siblings, 1 reply; 3+ messages in thread
From: chengang @ 2015-12-30 1:10 UTC (permalink / raw)
To: riku.voipio, laurent; +Cc: peter.maydell, Chen Gang, Chen Gang, qemu-devel, rth
From: Chen Gang <chengang@emindsoft.com.cn>
When mapping MAP_ANONYMOUS memory fragments, still need notice about to
set it zero, or it will cause issues.
Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
linux-user/mmap.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/linux-user/mmap.c b/linux-user/mmap.c
index 7b459d5..c6c478e 100644
--- a/linux-user/mmap.c
+++ b/linux-user/mmap.c
@@ -186,10 +186,12 @@ static int mmap_frag(abi_ulong real_start,
if (prot_new != (prot1 | PROT_WRITE))
mprotect(host_start, qemu_host_page_size, prot_new);
} else {
- /* just update the protection */
if (prot_new != prot1) {
mprotect(host_start, qemu_host_page_size, prot_new);
}
+ if (prot_new & PROT_WRITE) {
+ memset(g2h(start), 0, end - start);
+ }
}
return 0;
}
--
1.7.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH v3] linux-user/mmap.c: Always zero MAP_ANONYMOUS memory in mmap_frag()
2015-12-30 1:10 [Qemu-devel] [PATCH v3] linux-user/mmap.c: Always zero MAP_ANONYMOUS memory in mmap_frag() chengang
@ 2015-12-30 1:14 ` Laurent Vivier
2015-12-31 13:10 ` Chen Gang
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Vivier @ 2015-12-30 1:14 UTC (permalink / raw)
To: riku.voipio, Chen Gang; +Cc: peter.maydell, qemu-devel, rth
Le 30/12/2015 02:10, chengang@emindsoft.com.cn a écrit :
> From: Chen Gang <chengang@emindsoft.com.cn>
>
> When mapping MAP_ANONYMOUS memory fragments, still need notice about to
> set it zero, or it will cause issues.
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
> linux-user/mmap.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/linux-user/mmap.c b/linux-user/mmap.c
> index 7b459d5..c6c478e 100644
> --- a/linux-user/mmap.c
> +++ b/linux-user/mmap.c
> @@ -186,10 +186,12 @@ static int mmap_frag(abi_ulong real_start,
> if (prot_new != (prot1 | PROT_WRITE))
> mprotect(host_start, qemu_host_page_size, prot_new);
> } else {
> - /* just update the protection */
> if (prot_new != prot1) {
> mprotect(host_start, qemu_host_page_size, prot_new);
> }
> + if (prot_new & PROT_WRITE) {
> + memset(g2h(start), 0, end - start);
> + }
> }
> return 0;
> }
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH v3] linux-user/mmap.c: Always zero MAP_ANONYMOUS memory in mmap_frag()
2015-12-30 1:14 ` Laurent Vivier
@ 2015-12-31 13:10 ` Chen Gang
0 siblings, 0 replies; 3+ messages in thread
From: Chen Gang @ 2015-12-31 13:10 UTC (permalink / raw)
To: Laurent Vivier, riku.voipio; +Cc: peter.maydell, qemu-devel, rth
On 12/30/15 09:14, Laurent Vivier wrote:
>
> Le 30/12/2015 02:10, chengang@emindsoft.com.cn a écrit :
>> From: Chen Gang <chengang@emindsoft.com.cn>
>>
>> When mapping MAP_ANONYMOUS memory fragments, still need notice about to
>> set it zero, or it will cause issues.
>>
>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
>> ---
>> linux-user/mmap.c | 4 +++-
>> 1 files changed, 3 insertions(+), 1 deletions(-)
>>
>> diff --git a/linux-user/mmap.c b/linux-user/mmap.c
>> index 7b459d5..c6c478e 100644
>> --- a/linux-user/mmap.c
>> +++ b/linux-user/mmap.c
>> @@ -186,10 +186,12 @@ static int mmap_frag(abi_ulong real_start,
>> if (prot_new != (prot1 | PROT_WRITE))
>> mprotect(host_start, qemu_host_page_size, prot_new);
>> } else {
>> - /* just update the protection */
>> if (prot_new != prot1) {
>> mprotect(host_start, qemu_host_page_size, prot_new);
>> }
>> + if (prot_new & PROT_WRITE) {
>> + memset(g2h(start), 0, end - start);
>> + }
>> }
>> return 0;
>> }
>>
>
> Reviewed-by: Laurent Vivier <laurent@vivier.eu>
>
Thank you for your work.
Happy New Year! :-)
--
Chen Gang (陈刚)
Open, share, and attitude like air, water, and life which God blessed
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-31 13:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-30 1:10 [Qemu-devel] [PATCH v3] linux-user/mmap.c: Always zero MAP_ANONYMOUS memory in mmap_frag() chengang
2015-12-30 1:14 ` Laurent Vivier
2015-12-31 13:10 ` Chen Gang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.