[U-Boot] [PATCH] cgtqmx6eval: fix pad configuration for SPI bus

[U-Boot] [PATCH] cgtqmx6eval: fix pad configuration for SPI bus

[Michael Schanz]

Use the macro SETUP_IOMUX_PAD(...) rather than imx_iomux_v3_setup_multiple_pads(...) in order to setup
the pin configuration for ECSPI1.

ARRAY_SIZE(pads) provides the wrong size for imx_iomux_v3_setup_multiple_pads(pads, ARRAY_SIZE(pads)) in
case of MX6QDL. In the particular case, the content of GPR12 is overwritten and the IPG/AHB/ATB/ATP clocks
are deactivated. Therefore, the connection to the system via JTAG is not possible anymore. Furthermore,
kernel version 3.0.35 hangs during bootprocess in the function etm_init().

Signed-off-by: Michael Schanz <michael.schanz@congatec.com>
---

 board/congatec/cgtqmx6eval/cgtqmx6eval.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/congatec/cgtqmx6eval/cgtqmx6eval.c b/board/congatec/cgtqmx6eval/cgtqmx6eval.c
index 5fd526d..225de7c 100644
--- a/board/congatec/cgtqmx6eval/cgtqmx6eval.c
+++ b/board/congatec/cgtqmx6eval/cgtqmx6eval.c
@@ -404,7 +404,7 @@ static void setup_iomux_uart(void)
 #ifdef CONFIG_MXC_SPI
 static void setup_spi(void)
 {
-	imx_iomux_v3_setup_multiple_pads(ecspi1_pads, ARRAY_SIZE(ecspi1_pads));
+	SETUP_IOMUX_PADS(ecspi1_pads);
 	gpio_direction_output(IMX_GPIO_NR(3, 19), 0);
 }
 #endif
-- 
1.9.1

[U-Boot] [PATCH] cgtqmx6eval: fix pad configuration for SPI bus

[Otavio Salvador]

On Thu, Dec 10, 2015 at 6:58 AM, Michael Schanz
<michael.schanz@congatec.com> wrote:
> Use the macro SETUP_IOMUX_PAD(...) rather than imx_iomux_v3_setup_multiple_pads(...) in order to setup
> the pin configuration for ECSPI1.
>
> ARRAY_SIZE(pads) provides the wrong size for imx_iomux_v3_setup_multiple_pads(pads, ARRAY_SIZE(pads)) in
> case of MX6QDL. In the particular case, the content of GPR12 is overwritten and the IPG/AHB/ATB/ATP clocks
> are deactivated. Therefore, the connection to the system via JTAG is not possible anymore. Furthermore,
> kernel version 3.0.35 hangs during bootprocess in the function etm_init().
>
> Signed-off-by: Michael Schanz <michael.schanz@congatec.com>

Acked-by: Otavio Salvador <otavio@ossystems.com.br>

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

[U-Boot] [PATCH] cgtqmx6eval: fix pad configuration for SPI bus

[Stefano Babic]

On 10/12/2015 09:58, Michael Schanz wrote:
> Use the macro SETUP_IOMUX_PAD(...) rather than imx_iomux_v3_setup_multiple_pads(...) in order to setup
> the pin configuration for ECSPI1.
> 
> ARRAY_SIZE(pads) provides the wrong size for imx_iomux_v3_setup_multiple_pads(pads, ARRAY_SIZE(pads)) in
> case of MX6QDL. In the particular case, the content of GPR12 is overwritten and the IPG/AHB/ATB/ATP clocks
> are deactivated. Therefore, the connection to the system via JTAG is not possible anymore. Furthermore,
> kernel version 3.0.35 hangs during bootprocess in the function etm_init().
> 
> Signed-off-by: Michael Schanz <michael.schanz@congatec.com>
> ---

Applied to u-boot-imx, thanks!

Best regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================