Re: [PATCH] leds: add HAS_IOMEM dependency to LEDS_BCM6328/LEDS_BCM6358

[Jacek Anaszewski <j.anaszewski@samsung.com>]

Hi Vegard,

On 01/02/2016 02:05 PM, Vegard Nossum wrote:
> Ran into this on UML:
>
> drivers/built-in.o: In function `bcm6328_leds_probe':
> drivers/leds/leds-bcm6328.c:340: undefined reference to `devm_ioremap_resource'
> drivers/built-in.o: In function `bcm6358_leds_probe':
> drivers/leds/leds-bcm6358.c:173: undefined reference to `devm_ioremap_resource'
> collect2: error: ld returned 1 exit status
>
> devm_ioremap_resource() is defined only when HAS_IOMEM is selected.
>
> Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
> Cc: Richard Purdie <rpurdie@rpsys.net>
> Cc: Jacek Anaszewski <j.anaszewski@samsung.com>
> Cc: linux-leds@vger.kernel.org
> ---
>   drivers/leds/Kconfig | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index b1ab8bd..7f940c2 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -52,6 +52,7 @@ config LEDS_AAT1290
>   config LEDS_BCM6328
>   	tristate "LED Support for Broadcom BCM6328"
>   	depends on LEDS_CLASS
> +	depends on HAS_IOMEM
>   	depends on OF
>   	help
>   	  This option enables support for LEDs connected to the BCM6328
> @@ -60,6 +61,7 @@ config LEDS_BCM6328
>   config LEDS_BCM6358
>   	tristate "LED Support for Broadcom BCM6358"
>   	depends on LEDS_CLASS
> +	depends on HAS_IOMEM
>   	depends on OF
>   	help
>   	  This option enables support for LEDs connected to the BCM6358
>

Applied, thanks.

-- 
Best Regards,
Jacek Anaszewski