* [PATCH] leds: add HAS_IOMEM dependency to LEDS_BCM6328/LEDS_BCM6358
@ 2016-01-02 13:05 Vegard Nossum
2016-01-04 9:17 ` Jacek Anaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Vegard Nossum @ 2016-01-02 13:05 UTC (permalink / raw)
To: Richard Purdie, Jacek Anaszewski; +Cc: linux-leds
Ran into this on UML:
drivers/built-in.o: In function `bcm6328_leds_probe':
drivers/leds/leds-bcm6328.c:340: undefined reference to `devm_ioremap_resource'
drivers/built-in.o: In function `bcm6358_leds_probe':
drivers/leds/leds-bcm6358.c:173: undefined reference to `devm_ioremap_resource'
collect2: error: ld returned 1 exit status
devm_ioremap_resource() is defined only when HAS_IOMEM is selected.
Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
Cc: Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: linux-leds@vger.kernel.org
---
drivers/leds/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index b1ab8bd..7f940c2 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -52,6 +52,7 @@ config LEDS_AAT1290
config LEDS_BCM6328
tristate "LED Support for Broadcom BCM6328"
depends on LEDS_CLASS
+ depends on HAS_IOMEM
depends on OF
help
This option enables support for LEDs connected to the BCM6328
@@ -60,6 +61,7 @@ config LEDS_BCM6328
config LEDS_BCM6358
tristate "LED Support for Broadcom BCM6358"
depends on LEDS_CLASS
+ depends on HAS_IOMEM
depends on OF
help
This option enables support for LEDs connected to the BCM6358
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] leds: add HAS_IOMEM dependency to LEDS_BCM6328/LEDS_BCM6358
2016-01-02 13:05 [PATCH] leds: add HAS_IOMEM dependency to LEDS_BCM6328/LEDS_BCM6358 Vegard Nossum
@ 2016-01-04 9:17 ` Jacek Anaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Jacek Anaszewski @ 2016-01-04 9:17 UTC (permalink / raw)
To: Vegard Nossum; +Cc: Richard Purdie, linux-leds
Hi Vegard,
On 01/02/2016 02:05 PM, Vegard Nossum wrote:
> Ran into this on UML:
>
> drivers/built-in.o: In function `bcm6328_leds_probe':
> drivers/leds/leds-bcm6328.c:340: undefined reference to `devm_ioremap_resource'
> drivers/built-in.o: In function `bcm6358_leds_probe':
> drivers/leds/leds-bcm6358.c:173: undefined reference to `devm_ioremap_resource'
> collect2: error: ld returned 1 exit status
>
> devm_ioremap_resource() is defined only when HAS_IOMEM is selected.
>
> Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
> Cc: Richard Purdie <rpurdie@rpsys.net>
> Cc: Jacek Anaszewski <j.anaszewski@samsung.com>
> Cc: linux-leds@vger.kernel.org
> ---
> drivers/leds/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index b1ab8bd..7f940c2 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -52,6 +52,7 @@ config LEDS_AAT1290
> config LEDS_BCM6328
> tristate "LED Support for Broadcom BCM6328"
> depends on LEDS_CLASS
> + depends on HAS_IOMEM
> depends on OF
> help
> This option enables support for LEDs connected to the BCM6328
> @@ -60,6 +61,7 @@ config LEDS_BCM6328
> config LEDS_BCM6358
> tristate "LED Support for Broadcom BCM6358"
> depends on LEDS_CLASS
> + depends on HAS_IOMEM
> depends on OF
> help
> This option enables support for LEDs connected to the BCM6358
>
Applied, thanks.
--
Best Regards,
Jacek Anaszewski
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-04 9:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-02 13:05 [PATCH] leds: add HAS_IOMEM dependency to LEDS_BCM6328/LEDS_BCM6358 Vegard Nossum
2016-01-04 9:17 ` Jacek Anaszewski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.