From: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Jingoo Han <jg1.han@samsung.com>,
Thierry Reding <thierry.reding@gmail.com>,
linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] backlight: pwm: free pwm requested by legacy API on error path
Date: Mon, 04 Jan 2016 15:20:42 +0000 [thread overview]
Message-ID: <568A8DCA.6010301@mentor.com> (raw)
In-Reply-To: <20150921232338.GG11284@x1>
Hi Lee,
On 22.09.2015 02:23, Lee Jones wrote:
> On Sun, 14 Jun 2015, Vladimir Zapolskiy wrote:
>
>> If pwm is requested by legacy pwm_request() and if the following
>> backlight_device_register() call fails, add pwm_free() clean-up.
>>
>> Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
>> ---
>> drivers/video/backlight/pwm_bl.c | 2 ++
>> 1 file changed, 2 insertions(+)
>
> Applied, thanks.
>
I've just encountered that this change is not present in v4.4-rc, also it is
not in yours for-backlight-next branch, could you please double check the
status of the change?
Thank you in advance.
Best wishes,
Vladimir
>> diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
>> index 9991cdb..a691247 100644
>> --- a/drivers/video/backlight/pwm_bl.c
>> +++ b/drivers/video/backlight/pwm_bl.c
>> @@ -307,6 +307,8 @@ static int pwm_backlight_probe(struct platform_device *pdev)
>> if (IS_ERR(bl)) {
>> dev_err(&pdev->dev, "failed to register backlight\n");
>> ret = PTR_ERR(bl);
>> + if (pb->legacy)
>> + pwm_free(pb->pwm);
>> goto err_alloc;
>> }
>>
>
WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Jingoo Han <jg1.han@samsung.com>,
Thierry Reding <thierry.reding@gmail.com>,
linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] backlight: pwm: free pwm requested by legacy API on error path
Date: Mon, 4 Jan 2016 17:20:42 +0200 [thread overview]
Message-ID: <568A8DCA.6010301@mentor.com> (raw)
In-Reply-To: <20150921232338.GG11284@x1>
Hi Lee,
On 22.09.2015 02:23, Lee Jones wrote:
> On Sun, 14 Jun 2015, Vladimir Zapolskiy wrote:
>
>> If pwm is requested by legacy pwm_request() and if the following
>> backlight_device_register() call fails, add pwm_free() clean-up.
>>
>> Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
>> ---
>> drivers/video/backlight/pwm_bl.c | 2 ++
>> 1 file changed, 2 insertions(+)
>
> Applied, thanks.
>
I've just encountered that this change is not present in v4.4-rc, also it is
not in yours for-backlight-next branch, could you please double check the
status of the change?
Thank you in advance.
Best wishes,
Vladimir
>> diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
>> index 9991cdb..a691247 100644
>> --- a/drivers/video/backlight/pwm_bl.c
>> +++ b/drivers/video/backlight/pwm_bl.c
>> @@ -307,6 +307,8 @@ static int pwm_backlight_probe(struct platform_device *pdev)
>> if (IS_ERR(bl)) {
>> dev_err(&pdev->dev, "failed to register backlight\n");
>> ret = PTR_ERR(bl);
>> + if (pb->legacy)
>> + pwm_free(pb->pwm);
>> goto err_alloc;
>> }
>>
>
next prev parent reply other threads:[~2016-01-04 15:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-14 14:32 [PATCH] backlight: pwm: free pwm requested by legacy API on error path Vladimir Zapolskiy
2015-06-14 14:32 ` Vladimir Zapolskiy
2015-09-21 15:15 ` Vladimir Zapolskiy
2015-09-21 15:15 ` Vladimir Zapolskiy
2015-09-21 23:23 ` Lee Jones
2015-09-21 23:23 ` Lee Jones
2016-01-04 15:20 ` Vladimir Zapolskiy [this message]
2016-01-04 15:20 ` Vladimir Zapolskiy
2016-01-11 9:39 ` Lee Jones
2016-01-11 9:39 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568A8DCA.6010301@mentor.com \
--to=vladimir_zapolskiy@mentor.com \
--cc=jg1.han@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.