* [PATCH] bios/fan: hardcode the fan mode to linear
@ 2015-11-29 14:10 Martin Peres
[not found] ` <1448806218-6029-1-git-send-email-martin.peres-GANU6spQydw@public.gmane.org>
0 siblings, 1 reply; 7+ messages in thread
From: Martin Peres @ 2015-11-29 14:10 UTC (permalink / raw)
To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
This is an oversight that made use of the trip-point-based fan managenent on
cards that never expose those. This led the fan to stay at fan_min.
Fortunately, the emergency code would kick when the temperature would reach
90°C.
Reported-by: Tom Englund <tomenglund26@gmail.com>
Tested-by: Tom Englund <tomenglund26@gmail.com>
Signed-off-by: Martin Peres <martin.peres@free.fr>
---
drm/nouveau/nvkm/subdev/bios/fan.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drm/nouveau/nvkm/subdev/bios/fan.c b/drm/nouveau/nvkm/subdev/bios/fan.c
index 43006db..80fed7e 100644
--- a/drm/nouveau/nvkm/subdev/bios/fan.c
+++ b/drm/nouveau/nvkm/subdev/bios/fan.c
@@ -83,6 +83,7 @@ nvbios_fan_parse(struct nvkm_bios *bios, struct nvbios_therm_fan *fan)
fan->type = NVBIOS_THERM_FAN_UNK;
}
+ fan->fan_mode = NVBIOS_THERM_FAN_LINEAR;
fan->min_duty = nvbios_rd08(bios, data + 0x02);
fan->max_duty = nvbios_rd08(bios, data + 0x03);
--
2.6.2
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply related [flat|nested] 7+ messages in thread[parent not found: <1448806218-6029-1-git-send-email-martin.peres-GANU6spQydw@public.gmane.org>]
* Re: [PATCH] bios/fan: hardcode the fan mode to linear [not found] ` <1448806218-6029-1-git-send-email-martin.peres-GANU6spQydw@public.gmane.org> @ 2015-12-17 17:18 ` Martin Peres [not found] ` <5672EE74.6090403-GANU6spQydw@public.gmane.org> 0 siblings, 1 reply; 7+ messages in thread From: Martin Peres @ 2015-12-17 17:18 UTC (permalink / raw) To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW On 29/11/15 16:10, Martin Peres wrote: > This is an oversight that made use of the trip-point-based fan managenent on > cards that never expose those. This led the fan to stay at fan_min. > > Fortunately, the emergency code would kick when the temperature would reach > 90°C. > > Reported-by: Tom Englund <tomenglund26@gmail.com> > Tested-by: Tom Englund <tomenglund26@gmail.com> Tested-by: Daemon32 <lnf.purple@gmail.com> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92126 > Signed-off-by: Martin Peres <martin.peres@free.fr> > --- > drm/nouveau/nvkm/subdev/bios/fan.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drm/nouveau/nvkm/subdev/bios/fan.c b/drm/nouveau/nvkm/subdev/bios/fan.c > index 43006db..80fed7e 100644 > --- a/drm/nouveau/nvkm/subdev/bios/fan.c > +++ b/drm/nouveau/nvkm/subdev/bios/fan.c > @@ -83,6 +83,7 @@ nvbios_fan_parse(struct nvkm_bios *bios, struct nvbios_therm_fan *fan) > fan->type = NVBIOS_THERM_FAN_UNK; > } > > + fan->fan_mode = NVBIOS_THERM_FAN_LINEAR; > fan->min_duty = nvbios_rd08(bios, data + 0x02); > fan->max_duty = nvbios_rd08(bios, data + 0x03); > > Ben, can you merge this patch? It is kind of critical :s And it should be CCed to stable too, without it, some kepler/maxwell get 0% fan power which is kind of dangerous, even without reclocking! _______________________________________________ Nouveau mailing list Nouveau@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/nouveau ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <5672EE74.6090403-GANU6spQydw@public.gmane.org>]
* Re: [PATCH] bios/fan: hardcode the fan mode to linear [not found] ` <5672EE74.6090403-GANU6spQydw@public.gmane.org> @ 2016-01-04 14:56 ` Martin Peres [not found] ` <568A880E.1070603-GANU6spQydw@public.gmane.org> 0 siblings, 1 reply; 7+ messages in thread From: Martin Peres @ 2016-01-04 14:56 UTC (permalink / raw) To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Ben Skeggs On 17/12/15 19:18, Martin Peres wrote: > > > On 29/11/15 16:10, Martin Peres wrote: >> This is an oversight that made use of the trip-point-based fan >> managenent on >> cards that never expose those. This led the fan to stay at fan_min. >> >> Fortunately, the emergency code would kick when the temperature would >> reach >> 90°C. >> >> Reported-by: Tom Englund <tomenglund26@gmail.com> >> Tested-by: Tom Englund <tomenglund26@gmail.com> > > Tested-by: Daemon32 <lnf.purple@gmail.com> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92126 > >> Signed-off-by: Martin Peres <martin.peres@free.fr> >> --- >> drm/nouveau/nvkm/subdev/bios/fan.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drm/nouveau/nvkm/subdev/bios/fan.c >> b/drm/nouveau/nvkm/subdev/bios/fan.c >> index 43006db..80fed7e 100644 >> --- a/drm/nouveau/nvkm/subdev/bios/fan.c >> +++ b/drm/nouveau/nvkm/subdev/bios/fan.c >> @@ -83,6 +83,7 @@ nvbios_fan_parse(struct nvkm_bios *bios, struct >> nvbios_therm_fan *fan) >> fan->type = NVBIOS_THERM_FAN_UNK; >> } >> >> + fan->fan_mode = NVBIOS_THERM_FAN_LINEAR; >> fan->min_duty = nvbios_rd08(bios, data + 0x02); >> fan->max_duty = nvbios_rd08(bios, data + 0x03); >> >> > > Ben, can you merge this patch? It is kind of critical :s And it should > be CCed to stable too, without it, some kepler/maxwell get 0% fan > power which is kind of dangerous, even without reclocking! Ping, this is really important :s _______________________________________________ Nouveau mailing list Nouveau@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/nouveau ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <568A880E.1070603-GANU6spQydw@public.gmane.org>]
* Re: [PATCH] bios/fan: hardcode the fan mode to linear [not found] ` <568A880E.1070603-GANU6spQydw@public.gmane.org> @ 2016-01-04 16:42 ` Emil Velikov [not found] ` <CACvgo502iJJzC8qj4CA=+2UucHMhWQ=+X=ZpQ22xkiRS4PzDoQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 7+ messages in thread From: Emil Velikov @ 2016-01-04 16:42 UTC (permalink / raw) To: Martin Peres; +Cc: ML nouveau, Ben Skeggs On 4 January 2016 at 14:56, Martin Peres <martin.peres@free.fr> wrote: > On 17/12/15 19:18, Martin Peres wrote: >> On 29/11/15 16:10, Martin Peres wrote: >>> >>> This is an oversight that made use of the trip-point-based fan managenent >>> on >>> cards that never expose those. This led the fan to stay at fan_min. >>> >>> Fortunately, the emergency code would kick when the temperature would >>> reach >>> 90°C. >>> >>> Reported-by: Tom Englund <tomenglund26@gmail.com> >>> Tested-by: Tom Englund <tomenglund26@gmail.com> >> >> >> Tested-by: Daemon32 <lnf.purple@gmail.com> >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92126 >> >>> Signed-off-by: Martin Peres <martin.peres@free.fr> >>> --- >>> drm/nouveau/nvkm/subdev/bios/fan.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drm/nouveau/nvkm/subdev/bios/fan.c >>> b/drm/nouveau/nvkm/subdev/bios/fan.c >>> index 43006db..80fed7e 100644 >>> --- a/drm/nouveau/nvkm/subdev/bios/fan.c >>> +++ b/drm/nouveau/nvkm/subdev/bios/fan.c >>> @@ -83,6 +83,7 @@ nvbios_fan_parse(struct nvkm_bios *bios, struct >>> nvbios_therm_fan *fan) >>> fan->type = NVBIOS_THERM_FAN_UNK; >>> } >>> >>> + fan->fan_mode = NVBIOS_THERM_FAN_LINEAR; >>> fan->min_duty = nvbios_rd08(bios, data + 0x02); >>> fan->max_duty = nvbios_rd08(bios, data + 0x03); >>> >>> >> >> Ben, can you merge this patch? It is kind of critical :s And it should be >> CCed to stable too, without it, some kepler/maxwell get 0% fan power which >> is kind of dangerous, even without reclocking! > > > Ping, this is really important :s > Not sure who picked it up, but it seems to be in the latest fixes batch [1]. [1] http://lists.freedesktop.org/archives/dri-devel/2015-December/097589.html -Emil _______________________________________________ Nouveau mailing list Nouveau@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/nouveau ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <CACvgo502iJJzC8qj4CA=+2UucHMhWQ=+X=ZpQ22xkiRS4PzDoQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH] bios/fan: hardcode the fan mode to linear [not found] ` <CACvgo502iJJzC8qj4CA=+2UucHMhWQ=+X=ZpQ22xkiRS4PzDoQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2016-01-05 8:35 ` Martin Peres [not found] ` <568B8042.6020800-GANU6spQydw@public.gmane.org> 0 siblings, 1 reply; 7+ messages in thread From: Martin Peres @ 2016-01-05 8:35 UTC (permalink / raw) To: Emil Velikov; +Cc: ML nouveau, Ben Skeggs On 04/01/16 18:42, Emil Velikov wrote: > On 4 January 2016 at 14:56, Martin Peres <martin.peres@free.fr> wrote: >> On 17/12/15 19:18, Martin Peres wrote: >>> On 29/11/15 16:10, Martin Peres wrote: >>>> This is an oversight that made use of the trip-point-based fan managenent >>>> on >>>> cards that never expose those. This led the fan to stay at fan_min. >>>> >>>> Fortunately, the emergency code would kick when the temperature would >>>> reach >>>> 90°C. >>>> >>>> Reported-by: Tom Englund <tomenglund26@gmail.com> >>>> Tested-by: Tom Englund <tomenglund26@gmail.com> >>> >>> Tested-by: Daemon32 <lnf.purple@gmail.com> >>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92126 >>> >>>> Signed-off-by: Martin Peres <martin.peres@free.fr> >>>> --- >>>> drm/nouveau/nvkm/subdev/bios/fan.c | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/drm/nouveau/nvkm/subdev/bios/fan.c >>>> b/drm/nouveau/nvkm/subdev/bios/fan.c >>>> index 43006db..80fed7e 100644 >>>> --- a/drm/nouveau/nvkm/subdev/bios/fan.c >>>> +++ b/drm/nouveau/nvkm/subdev/bios/fan.c >>>> @@ -83,6 +83,7 @@ nvbios_fan_parse(struct nvkm_bios *bios, struct >>>> nvbios_therm_fan *fan) >>>> fan->type = NVBIOS_THERM_FAN_UNK; >>>> } >>>> >>>> + fan->fan_mode = NVBIOS_THERM_FAN_LINEAR; >>>> fan->min_duty = nvbios_rd08(bios, data + 0x02); >>>> fan->max_duty = nvbios_rd08(bios, data + 0x03); >>>> >>>> >>> Ben, can you merge this patch? It is kind of critical :s And it should be >>> CCed to stable too, without it, some kepler/maxwell get 0% fan power which >>> is kind of dangerous, even without reclocking! >> >> Ping, this is really important :s >> > Not sure who picked it up, but it seems to be in the latest fixes batch [1]. > > [1] http://lists.freedesktop.org/archives/dri-devel/2015-December/097589.html Thanks Emil, Karol pointed it out to me on IRC too. Thanks to whoever picked it up :) _______________________________________________ Nouveau mailing list Nouveau@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/nouveau ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <568B8042.6020800-GANU6spQydw@public.gmane.org>]
* Re: [PATCH] bios/fan: hardcode the fan mode to linear [not found] ` <568B8042.6020800-GANU6spQydw@public.gmane.org> @ 2016-01-05 8:38 ` Ben Skeggs [not found] ` <568B8120.2050500-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 0 siblings, 1 reply; 7+ messages in thread From: Ben Skeggs @ 2016-01-05 8:38 UTC (permalink / raw) To: Martin Peres, Emil Velikov; +Cc: ML nouveau [-- Attachment #1.1: Type: text/plain, Size: 2315 bytes --] On 01/05/2016 06:35 PM, Martin Peres wrote: > On 04/01/16 18:42, Emil Velikov wrote: >> On 4 January 2016 at 14:56, Martin Peres <martin.peres-GANU6spQydw@public.gmane.org> wrote: >>> On 17/12/15 19:18, Martin Peres wrote: >>>> On 29/11/15 16:10, Martin Peres wrote: >>>>> This is an oversight that made use of the trip-point-based fan >>>>> managenent >>>>> on >>>>> cards that never expose those. This led the fan to stay at fan_min. >>>>> >>>>> Fortunately, the emergency code would kick when the temperature would >>>>> reach >>>>> 90°C. >>>>> >>>>> Reported-by: Tom Englund <tomenglund26-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> >>>>> Tested-by: Tom Englund <tomenglund26-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> >>>> >>>> Tested-by: Daemon32 <lnf.purple-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> >>>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92126 >>>> >>>>> Signed-off-by: Martin Peres <martin.peres-GANU6spQydw@public.gmane.org> >>>>> --- >>>>> drm/nouveau/nvkm/subdev/bios/fan.c | 1 + >>>>> 1 file changed, 1 insertion(+) >>>>> >>>>> diff --git a/drm/nouveau/nvkm/subdev/bios/fan.c >>>>> b/drm/nouveau/nvkm/subdev/bios/fan.c >>>>> index 43006db..80fed7e 100644 >>>>> --- a/drm/nouveau/nvkm/subdev/bios/fan.c >>>>> +++ b/drm/nouveau/nvkm/subdev/bios/fan.c >>>>> @@ -83,6 +83,7 @@ nvbios_fan_parse(struct nvkm_bios *bios, struct >>>>> nvbios_therm_fan *fan) >>>>> fan->type = NVBIOS_THERM_FAN_UNK; >>>>> } >>>>> >>>>> + fan->fan_mode = NVBIOS_THERM_FAN_LINEAR; >>>>> fan->min_duty = nvbios_rd08(bios, data + 0x02); >>>>> fan->max_duty = nvbios_rd08(bios, data + 0x03); >>>>> >>>>> >>>> Ben, can you merge this patch? It is kind of critical :s And it >>>> should be >>>> CCed to stable too, without it, some kepler/maxwell get 0% fan power >>>> which >>>> is kind of dangerous, even without reclocking! >>> >>> Ping, this is really important :s >>> >> Not sure who picked it up, but it seems to be in the latest fixes >> batch [1]. >> >> [1] >> http://lists.freedesktop.org/archives/dri-devel/2015-December/097589.html > > Thanks Emil, Karol pointed it out to me on IRC too. Thanks to whoever > picked it up :) I did, my apologies for not communicating that better! Ben. [-- Attachment #1.2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --] [-- Attachment #2: Type: text/plain, Size: 153 bytes --] _______________________________________________ Nouveau mailing list Nouveau@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/nouveau ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <568B8120.2050500-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]
* Re: [PATCH] bios/fan: hardcode the fan mode to linear [not found] ` <568B8120.2050500-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> @ 2016-01-05 8:58 ` Martin Peres 0 siblings, 0 replies; 7+ messages in thread From: Martin Peres @ 2016-01-05 8:58 UTC (permalink / raw) To: Ben Skeggs, Emil Velikov; +Cc: ML nouveau On 05/01/16 10:38, Ben Skeggs wrote: > On 01/05/2016 06:35 PM, Martin Peres wrote: >> On 04/01/16 18:42, Emil Velikov wrote: >>> On 4 January 2016 at 14:56, Martin Peres <martin.peres@free.fr> wrote: >>>> On 17/12/15 19:18, Martin Peres wrote: >>>>> On 29/11/15 16:10, Martin Peres wrote: >>>>>> This is an oversight that made use of the trip-point-based fan >>>>>> managenent >>>>>> on >>>>>> cards that never expose those. This led the fan to stay at fan_min. >>>>>> >>>>>> Fortunately, the emergency code would kick when the temperature would >>>>>> reach >>>>>> 90°C. >>>>>> >>>>>> Reported-by: Tom Englund <tomenglund26@gmail.com> >>>>>> Tested-by: Tom Englund <tomenglund26@gmail.com> >>>>> Tested-by: Daemon32 <lnf.purple@gmail.com> >>>>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92126 >>>>> >>>>>> Signed-off-by: Martin Peres <martin.peres@free.fr> >>>>>> --- >>>>>> drm/nouveau/nvkm/subdev/bios/fan.c | 1 + >>>>>> 1 file changed, 1 insertion(+) >>>>>> >>>>>> diff --git a/drm/nouveau/nvkm/subdev/bios/fan.c >>>>>> b/drm/nouveau/nvkm/subdev/bios/fan.c >>>>>> index 43006db..80fed7e 100644 >>>>>> --- a/drm/nouveau/nvkm/subdev/bios/fan.c >>>>>> +++ b/drm/nouveau/nvkm/subdev/bios/fan.c >>>>>> @@ -83,6 +83,7 @@ nvbios_fan_parse(struct nvkm_bios *bios, struct >>>>>> nvbios_therm_fan *fan) >>>>>> fan->type = NVBIOS_THERM_FAN_UNK; >>>>>> } >>>>>> >>>>>> + fan->fan_mode = NVBIOS_THERM_FAN_LINEAR; >>>>>> fan->min_duty = nvbios_rd08(bios, data + 0x02); >>>>>> fan->max_duty = nvbios_rd08(bios, data + 0x03); >>>>>> >>>>>> >>>>> Ben, can you merge this patch? It is kind of critical :s And it >>>>> should be >>>>> CCed to stable too, without it, some kepler/maxwell get 0% fan power >>>>> which >>>>> is kind of dangerous, even without reclocking! >>>> Ping, this is really important :s >>>> >>> Not sure who picked it up, but it seems to be in the latest fixes >>> batch [1]. >>> >>> [1] >>> http://lists.freedesktop.org/archives/dri-devel/2015-December/097589.html >> Thanks Emil, Karol pointed it out to me on IRC too. Thanks to whoever >> picked it up :) > I did, my apologies for not communicating that better! No probs :) Didn't know you moved to github too, it may be worth sending an email on the ML and we need to update the wiki. Are you planning on using the merge request feature to keep track of the review you need to make? We can also ask Damien Lespiau to set up a Nouveau instance of patchwork: https://patchwork.freedesktop.org/ _______________________________________________ Nouveau mailing list Nouveau@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/nouveau ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-01-05 8:58 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-29 14:10 [PATCH] bios/fan: hardcode the fan mode to linear Martin Peres
[not found] ` <1448806218-6029-1-git-send-email-martin.peres-GANU6spQydw@public.gmane.org>
2015-12-17 17:18 ` Martin Peres
[not found] ` <5672EE74.6090403-GANU6spQydw@public.gmane.org>
2016-01-04 14:56 ` Martin Peres
[not found] ` <568A880E.1070603-GANU6spQydw@public.gmane.org>
2016-01-04 16:42 ` Emil Velikov
[not found] ` <CACvgo502iJJzC8qj4CA=+2UucHMhWQ=+X=ZpQ22xkiRS4PzDoQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-01-05 8:35 ` Martin Peres
[not found] ` <568B8042.6020800-GANU6spQydw@public.gmane.org>
2016-01-05 8:38 ` Ben Skeggs
[not found] ` <568B8120.2050500-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-01-05 8:58 ` Martin Peres
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.