Re: [Qemu-devel] [PATCH v3 0/4] Convert to realize()

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1209 bytes --]

On 01/06/2016 04:08 AM, Stefano Stabellini wrote:
> On Wed, 6 Jan 2016, Cao jin wrote:
>> v3 changelog:
>> 1. use following style when we want to check the returned error
>>
>>      Error *err = NULL;
>>      foo(arg, &err);
>>      if (err) {
>>          handle the error...
>>          error_propagate(errp, err);
>>      }
>>
>> Cao jin (4):
>>   Add Error **errp for xen_host_pci_device_get()
>>   Add Error **errp for xen_pt_setup_vga()
>>   Add Error **errp for xen_pt_config_init()
>>   Xen PCI passthru: convert to realize()
>>
>>  hw/xen/xen-host-pci-device.c | 106 +++++++++++++++++++++++++------------------
>>  hw/xen/xen-host-pci-device.h |   5 +-
>>  hw/xen/xen_pt.c              |  73 ++++++++++++++++-------------
>>  hw/xen/xen_pt.h              |   5 +-
>>  hw/xen/xen_pt_config_init.c  |  51 +++++++++++----------
>>  hw/xen/xen_pt_graphics.c     |  11 +++--
>>  6 files changed, 141 insertions(+), 110 deletions(-)
> 
> Thanks Cao, I applied the whole series to my next branch.

I found some issues while reviewing; maybe you want to wait for a v4.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]