Re: [Qemu-devel] [PATCH v3 4/4] Xen PCI passthru: convert to realize()

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 931 bytes --]

On 01/07/2016 12:16 AM, Cao jin wrote:
> 
> 
> On 01/07/2016 12:07 AM, Eric Blake wrote:
>> On 01/05/2016 07:39 PM, Cao jin wrote:
> [...]
>>
>>> @@ -827,27 +827,26 @@ static int xen_pt_initfn(PCIDevice *d)
>>>       xen_pt_config_init(s, &local_err);
>>>       if (local_err) {
>>>           error_append_hint(&local_err, "PCI Config space
>>> initialisation failed");
>>> -        rc = -1;
>>> +        error_propagate(errp, local_err);
>>>           goto err_out;
>>>       }
>>
>> Looks like this fixes a memory leak in an earlier patch; maybe you need
>> to shuffle hunks around?
>>
> 
> Sorry, don`t quite undertand what "shuffle hunks around" means, could
> you detail it?

It means this change should occur in an earlier patch (probably 2/4?).
I shuffle hunks by using 'git rebase -i'.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]