From: Max Reitz <mreitz@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
pbonzini@redhat.com, Jeff Cody <jcody@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v9 1/2] mirror: Rewrite mirror_iteration
Date: Wed, 6 Jan 2016 18:57:29 +0100 [thread overview]
Message-ID: <568D5589.9070208@redhat.com> (raw)
In-Reply-To: <1451983580-10561-2-git-send-email-famz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 676 bytes --]
On 05.01.2016 09:46, Fam Zheng wrote:
> The "pnum < nb_sectors" condition in deciding whether to actually copy
> data is unnecessarily strict, and the qiov initialization is
> unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard.
>
> Rewrite mirror_iteration to fix both flaws.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> block/mirror.c | 347 +++++++++++++++++++++++++++++++++++----------------------
> trace-events | 1 -
> 2 files changed, 216 insertions(+), 132 deletions(-)
Side note: This breaks the output of iotest 109, probably due to
different alignment of the mirroring operations (doesn't look serious,
though).
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-01-06 17:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 8:46 [Qemu-devel] [PATCH v9 0/2] mirror: Improve zero write and discard Fam Zheng
2016-01-05 8:46 ` [Qemu-devel] [PATCH v9 1/2] mirror: Rewrite mirror_iteration Fam Zheng
2016-01-06 17:53 ` Max Reitz
2016-01-12 12:06 ` Fam Zheng
2016-01-06 17:57 ` Max Reitz [this message]
2016-01-05 8:46 ` [Qemu-devel] [PATCH v9 2/2] mirror: Add mirror_wait_for_io Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568D5589.9070208@redhat.com \
--to=mreitz@redhat.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.