All of lore.kernel.org
 help / color / mirror / Atom feed
From: robin.murphy@arm.com (Robin Murphy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64/dts: Add missing DMA Abort interrupt to Juno
Date: Thu, 7 Jan 2016 15:45:15 +0000	[thread overview]
Message-ID: <568E880B.2090602@arm.com> (raw)
In-Reply-To: <2736927.0LiVxGZzgm@wuerfel>

On 07/01/16 14:36, Arnd Bergmann wrote:
> On Thursday 07 January 2016 12:01:59 Robin Murphy wrote:
>> The DMA-330 has an "irq_abort" interrupt line on which it signals faults
>> separately from the "irq[n:0]" channel interrupts. On Juno, this is
>> wired up to SPI 92; add it to the DT so that DMAC faults are correctly
>> reported for the driver to reset the thing, rather than leaving it
>> locked up and waiting to time out.
>>
>> CC: Liviu Dudau <liviu.dudau@arm.com>
>> CC: Sudeep Holla <sudeep.holla@arm.com>
>> CC: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
>> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
>>
>
> Nothing wrong with the patch, but could you please come up with
> a more structured way to get patches for Juno into the kernel?
>
> You have addressed the patch "to:" the arm-soc maintainers, but
> you are not listed in the maintainers file for the directory, so
> it's not clear what you expect to happen here.

I'll admit I got to the addressing point and wasn't entirely sure either 
- there still seemed to be a precedent of patches going to arm-soc 
picking up acks along the way, rather than via a sub-maintainer pull, 
hence what I ended up with.

> Ideally, we'd get patches from just one of the people listed
> in the MAINTAINERS file normally, and let us know if the
> primary maintainer changes, or if one of the others sends a
> patch because that person is unavailable.

Sure, I'll bear that in mind in future, especially when sending from an 
email domain which doesn't really make clear the context that I'm just 
another end-user posting a fix for something I found, rather than trying 
to assume any "official" capacity ;)

As a side note, the Juno dts* files don't actually seem to be covered by 
MAINTAINERS at all, which can't help the situation.

Sorry for the confusion,
Robin.

WARNING: multiple messages have this Message-ID (diff)
From: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org,
	khilman-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Lorenzo Pieralisi
	<lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org>,
	Liviu Dudau <liviu.dudau-5wv7dgnIgG8@public.gmane.org>,
	Sudeep Holla <sudeep.holla-5wv7dgnIgG8@public.gmane.org>
Subject: Re: [PATCH] arm64/dts: Add missing DMA Abort interrupt to Juno
Date: Thu, 7 Jan 2016 15:45:15 +0000	[thread overview]
Message-ID: <568E880B.2090602@arm.com> (raw)
In-Reply-To: <2736927.0LiVxGZzgm@wuerfel>

On 07/01/16 14:36, Arnd Bergmann wrote:
> On Thursday 07 January 2016 12:01:59 Robin Murphy wrote:
>> The DMA-330 has an "irq_abort" interrupt line on which it signals faults
>> separately from the "irq[n:0]" channel interrupts. On Juno, this is
>> wired up to SPI 92; add it to the DT so that DMAC faults are correctly
>> reported for the driver to reset the thing, rather than leaving it
>> locked up and waiting to time out.
>>
>> CC: Liviu Dudau <liviu.dudau-5wv7dgnIgG8@public.gmane.org>
>> CC: Sudeep Holla <sudeep.holla-5wv7dgnIgG8@public.gmane.org>
>> CC: Lorenzo Pieralisi <lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org>
>> Signed-off-by: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>
>>
>
> Nothing wrong with the patch, but could you please come up with
> a more structured way to get patches for Juno into the kernel?
>
> You have addressed the patch "to:" the arm-soc maintainers, but
> you are not listed in the maintainers file for the directory, so
> it's not clear what you expect to happen here.

I'll admit I got to the addressing point and wasn't entirely sure either 
- there still seemed to be a precedent of patches going to arm-soc 
picking up acks along the way, rather than via a sub-maintainer pull, 
hence what I ended up with.

> Ideally, we'd get patches from just one of the people listed
> in the MAINTAINERS file normally, and let us know if the
> primary maintainer changes, or if one of the others sends a
> patch because that person is unavailable.

Sure, I'll bear that in mind in future, especially when sending from an 
email domain which doesn't really make clear the context that I'm just 
another end-user posting a fix for something I found, rather than trying 
to assume any "official" capacity ;)

As a side note, the Juno dts* files don't actually seem to be covered by 
MAINTAINERS at all, which can't help the situation.

Sorry for the confusion,
Robin.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2016-01-07 15:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-07 12:01 [PATCH] arm64/dts: Add missing DMA Abort interrupt to Juno Robin Murphy
2016-01-07 12:01 ` Robin Murphy
2016-01-07 14:36 ` Arnd Bergmann
2016-01-07 14:36   ` Arnd Bergmann
2016-01-07 15:06   ` Sudeep Holla
2016-01-07 15:06     ` Sudeep Holla
2016-01-11 10:47     ` Liviu Dudau
2016-01-11 10:47       ` Liviu Dudau
2016-01-07 15:45   ` Robin Murphy [this message]
2016-01-07 15:45     ` Robin Murphy
2016-01-07 16:10     ` Sudeep Holla
2016-01-07 16:10       ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=568E880B.2090602@arm.com \
    --to=robin.murphy@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.