From: Mike Kravetz <mike.kravetz@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Hillf Danton <hillf.zj@alibaba-inc.com>,
Hugh Dickins <hughd@google.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Dave Hansen <dave.hansen@linux.intel.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] mm/hugetlbfs Fix bugs in hugetlb_vmtruncate_list
Date: Thu, 7 Jan 2016 15:51:21 -0800 [thread overview]
Message-ID: <568EF9F9.8050404@oracle.com> (raw)
In-Reply-To: <20160107151356.0e131b25f5740f6046221419@linux-foundation.org>
On 01/07/2016 03:13 PM, Andrew Morton wrote:
> On Thu, 7 Jan 2016 14:35:37 -0800 Mike Kravetz <mike.kravetz@oracle.com> wrote:
>
>> Hillf Danton noticed bugs in the hugetlb_vmtruncate_list routine.
>> The argument end is of type pgoff_t. It was being converted to a
>> vaddr offset and passed to unmap_hugepage_range. However, end
>> was also being used as an argument to the vma_interval_tree_foreach
>> controlling loop. In addition, the conversion of end to vaddr offset
>> was incorrect.
>
> Could we please have a description of the user-visible effects of the
> bug? It's always needed for -stable things. And for all bugfixes, really.
>
> (stable@vger.kernel.org[4.3] isn't an email address btw - my client barfed)
Will do.
As I stare at the code to come up with user visible effects, I am not
convinced the fix is correct. An update will come after more study.
--
Mike Kravetz
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Mike Kravetz <mike.kravetz@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Hillf Danton <hillf.zj@alibaba-inc.com>,
Hugh Dickins <hughd@google.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Dave Hansen <dave.hansen@linux.intel.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] mm/hugetlbfs Fix bugs in hugetlb_vmtruncate_list
Date: Thu, 7 Jan 2016 15:51:21 -0800 [thread overview]
Message-ID: <568EF9F9.8050404@oracle.com> (raw)
In-Reply-To: <20160107151356.0e131b25f5740f6046221419@linux-foundation.org>
On 01/07/2016 03:13 PM, Andrew Morton wrote:
> On Thu, 7 Jan 2016 14:35:37 -0800 Mike Kravetz <mike.kravetz@oracle.com> wrote:
>
>> Hillf Danton noticed bugs in the hugetlb_vmtruncate_list routine.
>> The argument end is of type pgoff_t. It was being converted to a
>> vaddr offset and passed to unmap_hugepage_range. However, end
>> was also being used as an argument to the vma_interval_tree_foreach
>> controlling loop. In addition, the conversion of end to vaddr offset
>> was incorrect.
>
> Could we please have a description of the user-visible effects of the
> bug? It's always needed for -stable things. And for all bugfixes, really.
>
> (stable@vger.kernel.org[4.3] isn't an email address btw - my client barfed)
Will do.
As I stare at the code to come up with user visible effects, I am not
convinced the fix is correct. An update will come after more study.
--
Mike Kravetz
next prev parent reply other threads:[~2016-01-07 23:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 22:35 [PATCH] mm/hugetlbfs Fix bugs in hugetlb_vmtruncate_list Mike Kravetz
2016-01-07 23:13 ` Andrew Morton
2016-01-07 23:13 ` Andrew Morton
2016-01-07 23:51 ` Mike Kravetz [this message]
2016-01-07 23:51 ` Mike Kravetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568EF9F9.8050404@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@linux.intel.com \
--cc=dave@stgolabs.net \
--cc=hillf.zj@alibaba-inc.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.