From: Dave Hansen <dave.hansen@intel.com>
To: John Allen <jallen@linux.vnet.ibm.com>, gregkh@linuxfoundation.org
Cc: Nathan Fontenot <nfont@linux.vnet.ibm.com>,
akpm@linux-foundation.org, Michael Ellerman <mpe@ellerman.id.au>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Linux-MM <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v4] memory-hotplug: Fix kernel warning during memory hotplug on ppc64
Date: Thu, 7 Jan 2016 17:13:58 -0800 [thread overview]
Message-ID: <568F0D56.5010908@intel.com> (raw)
In-Reply-To: <568D9568.1010808@linux.vnet.ibm.com>
On 01/06/2016 02:30 PM, John Allen wrote:
> On any architecture that uses memory_probe_store to reserve memory, the
> udev rule will be triggered after the first section of the block is
> reserved and will subsequently attempt to online the entire block,
> interrupting the memory reservation process and causing the warning.
> This patch modifies memory_probe_store to add a block of memory with
> a single call to add_memory as opposed to looping through and adding
> each section individually. A single call to add_memory is protected by
> the mem_hotplug mutex which will prevent the udev rule from onlining
> memory until the reservation of the entire block is complete.
Seems sane to me. Makes the code simpler too, so win win.
Acked-by: Dave Hansen <dave.hansen@intel.com>
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave.hansen@intel.com>
To: John Allen <jallen@linux.vnet.ibm.com>, gregkh@linuxfoundation.org
Cc: Nathan Fontenot <nfont@linux.vnet.ibm.com>,
akpm@linux-foundation.org, Michael Ellerman <mpe@ellerman.id.au>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Linux-MM <linux-mm@kvack.org>Andrew Morton
<akpm@linux-foundation.org>
Subject: Re: [PATCH v4] memory-hotplug: Fix kernel warning during memory hotplug on ppc64
Date: Thu, 7 Jan 2016 17:13:58 -0800 [thread overview]
Message-ID: <568F0D56.5010908@intel.com> (raw)
In-Reply-To: <568D9568.1010808@linux.vnet.ibm.com>
On 01/06/2016 02:30 PM, John Allen wrote:
> On any architecture that uses memory_probe_store to reserve memory, the
> udev rule will be triggered after the first section of the block is
> reserved and will subsequently attempt to online the entire block,
> interrupting the memory reservation process and causing the warning.
> This patch modifies memory_probe_store to add a block of memory with
> a single call to add_memory as opposed to looping through and adding
> each section individually. A single call to add_memory is protected by
> the mem_hotplug mutex which will prevent the udev rule from onlining
> memory until the reservation of the entire block is complete.
Seems sane to me. Makes the code simpler too, so win win.
Acked-by: Dave Hansen <dave.hansen@intel.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-01-08 1:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 22:30 [PATCH v4] memory-hotplug: Fix kernel warning during memory hotplug on ppc64 John Allen
2016-01-07 22:47 ` Andrew Morton
2016-01-07 22:47 ` Andrew Morton
2016-01-08 1:13 ` Dave Hansen [this message]
2016-01-08 1:13 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568F0D56.5010908@intel.com \
--to=dave.hansen@intel.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=jallen@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=nfont@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.