All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com,
	gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org,
	stefanha@redhat.com, pbonzini@redhat.com,
	dan.j.williams@intel.com, rth@twiddle.net
Subject: Re: [PATCH 5/6] nvdimm acpi: let qemu handle _DSM method
Date: Fri, 8 Jan 2016 12:01:54 +0800	[thread overview]
Message-ID: <568F34B2.9090101@linux.intel.com> (raw)
In-Reply-To: <20160107152228.2676222a@nial.brq.redhat.com>



On 01/07/2016 10:22 PM, Igor Mammedov wrote:
> On Tue,  5 Jan 2016 02:52:07 +0800
> Xiao Guangrong <guangrong.xiao@linux.intel.com> wrote:
>
>> If dsm memory is successfully patched, we let qemu fully emulate
>> the dsm method
>>
>> This patch saves _DSM input parameters into dsm memory, tell dsm
>> memory address to QEMU, then fetch the result from the dsm memory
> you also need to add NVDR._CRS method that would report
> resources used by operation regions.

I can not understand this point, why we need to report the resource
of OperationRegion? It is ACPI internally used anyway.

>
> NVDIMM_COMMON_DSM - probably should be serialized, otherwise
> there is a race risk, when several callers would write to
> control region.

Yes, i did it in patch 6/6, but definitely i should more it to here.

WARNING: multiple messages have this Message-ID (diff)
From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com,
	gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org,
	stefanha@redhat.com, pbonzini@redhat.com,
	dan.j.williams@intel.com, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH 5/6] nvdimm acpi: let qemu handle _DSM method
Date: Fri, 8 Jan 2016 12:01:54 +0800	[thread overview]
Message-ID: <568F34B2.9090101@linux.intel.com> (raw)
In-Reply-To: <20160107152228.2676222a@nial.brq.redhat.com>



On 01/07/2016 10:22 PM, Igor Mammedov wrote:
> On Tue,  5 Jan 2016 02:52:07 +0800
> Xiao Guangrong <guangrong.xiao@linux.intel.com> wrote:
>
>> If dsm memory is successfully patched, we let qemu fully emulate
>> the dsm method
>>
>> This patch saves _DSM input parameters into dsm memory, tell dsm
>> memory address to QEMU, then fetch the result from the dsm memory
> you also need to add NVDR._CRS method that would report
> resources used by operation regions.

I can not understand this point, why we need to report the resource
of OperationRegion? It is ACPI internally used anyway.

>
> NVDIMM_COMMON_DSM - probably should be serialized, otherwise
> there is a race risk, when several callers would write to
> control region.

Yes, i did it in patch 6/6, but definitely i should more it to here.

  reply	other threads:[~2016-01-08  4:01 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-04 18:52 [PATCH 0/6] NVDIMM ACPI: introduce the framework of QEMU emulated DSM Xiao Guangrong
2016-01-04 18:52 ` [Qemu-devel] " Xiao Guangrong
2016-01-04 18:52 ` [PATCH 1/6] pc: acpi: bump DSDT/SSDT compliance revision to v2 Xiao Guangrong
2016-01-04 18:52   ` [Qemu-devel] " Xiao Guangrong
2016-01-04 18:52 ` [PATCH 2/6] nvdimm acpi: initialize the resource used by NVDIMM ACPI Xiao Guangrong
2016-01-04 18:52   ` [Qemu-devel] " Xiao Guangrong
2016-01-04 18:52 ` [PATCH 3/6] nvdimm acpi: introduce patched dsm memory Xiao Guangrong
2016-01-04 18:52   ` [Qemu-devel] " Xiao Guangrong
2016-01-06 15:23   ` Igor Mammedov
2016-01-06 15:23     ` [Qemu-devel] " Igor Mammedov
2016-01-06 15:39     ` Xiao Guangrong
2016-01-06 15:39       ` [Qemu-devel] " Xiao Guangrong
2016-01-07 11:04       ` Igor Mammedov
2016-01-07 11:04         ` [Qemu-devel] " Igor Mammedov
2016-01-08  3:40         ` Xiao Guangrong
2016-01-08  3:40           ` [Qemu-devel] " Xiao Guangrong
2016-01-08 17:06           ` Igor Mammedov
2016-01-08 17:06             ` [Qemu-devel] " Igor Mammedov
2016-01-04 18:52 ` [PATCH 4/6] acpi: allow using acpi named offset for OperationRegion Xiao Guangrong
2016-01-04 18:52   ` [Qemu-devel] " Xiao Guangrong
2016-01-04 18:52 ` [PATCH 5/6] nvdimm acpi: let qemu handle _DSM method Xiao Guangrong
2016-01-04 18:52   ` [Qemu-devel] " Xiao Guangrong
2016-01-07 14:22   ` Igor Mammedov
2016-01-07 14:22     ` [Qemu-devel] " Igor Mammedov
2016-01-08  4:01     ` Xiao Guangrong [this message]
2016-01-08  4:01       ` Xiao Guangrong
2016-01-08 16:08       ` Igor Mammedov
2016-01-08 16:08         ` [Qemu-devel] " Igor Mammedov
2016-01-04 18:52 ` [PATCH 6/6] nvdimm acpi: emulate dsm method Xiao Guangrong
2016-01-04 18:52   ` [Qemu-devel] " Xiao Guangrong
2016-01-07 14:13 ` [Qemu-devel] [PATCH 0/6] NVDIMM ACPI: introduce the framework of QEMU emulated DSM Igor Mammedov
2016-01-07 14:13   ` Igor Mammedov
2016-01-12 19:02   ` Xiao Guangrong
2016-01-12 19:02     ` Xiao Guangrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=568F34B2.9090101@linux.intel.com \
    --to=guangrong.xiao@linux.intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=ehabkost@redhat.com \
    --cc=gleb@kernel.org \
    --cc=imammedo@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.