From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: "Yang, Wenyou" <Wenyou.Yang@atmel.com>
Cc: Sebastian Reichel <sre@kernel.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
"Ferre, Nicolas" <Nicolas.FERRE@atmel.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: [PATCH 1/2] power: act8945a: add charger driver for ACT8945A
Date: Fri, 08 Jan 2016 16:02:45 +0900 [thread overview]
Message-ID: <568F5F15.8050602@samsung.com> (raw)
In-Reply-To: <B256D81BAE5131468A838E5D7A243641D63E5A3E@penmbx01>
On 08.01.2016 15:43, Yang, Wenyou wrote:
[...]
>>> +static struct platform_driver act8945a_charger_driver = {
>>> + .driver = {
>>> + .name = "act8945a-charger",
>>> + },
>>> + .probe = act8945a_charger_probe,
>>> + .remove = act8945a_charger_remove, };
>>> +
>>> +static int __init act8945a_charger_init(void) {
>>> + return platform_driver_register(&act8945a_charger_driver);
>>> +}
>>> +subsys_initcall(act8945a_charger_init);
>>
>> Why subsys_initcall? This should be regular module_platform_driver.
>
> I want it to register early enough as MFD. Maybe I am wrong.
No, you shouldn't manually order the probing by initcalls. This should
be registered as usual and, if needed, support deferred probing. In this
case I even can't find any reason to register it earlier than usual.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] power: act8945a: add charger driver for ACT8945A
Date: Fri, 08 Jan 2016 16:02:45 +0900 [thread overview]
Message-ID: <568F5F15.8050602@samsung.com> (raw)
In-Reply-To: <B256D81BAE5131468A838E5D7A243641D63E5A3E@penmbx01>
On 08.01.2016 15:43, Yang, Wenyou wrote:
[...]
>>> +static struct platform_driver act8945a_charger_driver = {
>>> + .driver = {
>>> + .name = "act8945a-charger",
>>> + },
>>> + .probe = act8945a_charger_probe,
>>> + .remove = act8945a_charger_remove, };
>>> +
>>> +static int __init act8945a_charger_init(void) {
>>> + return platform_driver_register(&act8945a_charger_driver);
>>> +}
>>> +subsys_initcall(act8945a_charger_init);
>>
>> Why subsys_initcall? This should be regular module_platform_driver.
>
> I want it to register early enough as MFD. Maybe I am wrong.
No, you shouldn't manually order the probing by initcalls. This should
be registered as usual and, if needed, support deferred probing. In this
case I even can't find any reason to register it earlier than usual.
Best regards,
Krzysztof
next prev parent reply other threads:[~2016-01-08 7:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 2:13 [PATCH 0/2] power: act8945a: add charger driver for the sub-device of ACT8945A MFD Wenyou Yang
2016-01-08 2:13 ` Wenyou Yang
2016-01-08 2:13 ` Wenyou Yang
2016-01-08 2:13 ` [PATCH 1/2] power: act8945a: add charger driver for ACT8945A Wenyou Yang
2016-01-08 2:13 ` Wenyou Yang
2016-01-08 2:13 ` Wenyou Yang
2016-01-08 3:55 ` Krzysztof Kozlowski
2016-01-08 3:55 ` Krzysztof Kozlowski
2016-01-08 6:43 ` Yang, Wenyou
2016-01-08 6:43 ` Yang, Wenyou
2016-01-08 7:02 ` Krzysztof Kozlowski [this message]
2016-01-08 7:02 ` Krzysztof Kozlowski
2016-01-08 7:58 ` Yang, Wenyou
2016-01-08 7:58 ` Yang, Wenyou
2016-01-08 15:00 ` Javier Martinez Canillas
2016-01-08 15:00 ` Javier Martinez Canillas
2016-01-12 8:23 ` Yang, Wenyou
2016-01-12 8:23 ` Yang, Wenyou
2016-01-12 14:03 ` Javier Martinez Canillas
2016-01-12 14:03 ` Javier Martinez Canillas
2016-01-08 2:13 ` [PATCH 2/2] power: add documentation for ACT8945A's charger DT bindings Wenyou Yang
2016-01-08 2:13 ` Wenyou Yang
2016-01-08 2:13 ` Wenyou Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568F5F15.8050602@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=Nicolas.FERRE@atmel.com \
--cc=Wenyou.Yang@atmel.com \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.