* [PATCH] iio: ak8975: constify ak_def structures
@ 2016-01-05 14:56 ` Julia Lawall
0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2016-01-05 14:56 UTC (permalink / raw)
To: Jonathan Cameron
Cc: kernel-janitors, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald, linux-iio, linux-kernel
The ak_def structures are never modified, so declare them as const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/iio/magnetometer/ak8975.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/ak8975.c
index b13936d..9c5c9ef 100644
--- a/drivers/iio/magnetometer/ak8975.c
+++ b/drivers/iio/magnetometer/ak8975.c
@@ -252,7 +252,7 @@ struct ak_def {
u8 data_regs[3];
};
-static struct ak_def ak_def_array[AK_MAX_TYPE] = {
+static const struct ak_def ak_def_array[AK_MAX_TYPE] = {
{
.type = AK8975,
.raw_to_gauss = ak8975_raw_to_gauss,
@@ -360,7 +360,7 @@ static struct ak_def ak_def_array[AK_MAX_TYPE] = {
*/
struct ak8975_data {
struct i2c_client *client;
- struct ak_def *def;
+ const struct ak_def *def;
struct attribute_group attrs;
struct mutex lock;
u8 asa[3];
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] iio: ak8975: constify ak_def structures
@ 2016-01-05 14:56 ` Julia Lawall
0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2016-01-05 14:56 UTC (permalink / raw)
To: Jonathan Cameron
Cc: kernel-janitors, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald, linux-iio, linux-kernel
The ak_def structures are never modified, so declare them as const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/iio/magnetometer/ak8975.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/ak8975.c
index b13936d..9c5c9ef 100644
--- a/drivers/iio/magnetometer/ak8975.c
+++ b/drivers/iio/magnetometer/ak8975.c
@@ -252,7 +252,7 @@ struct ak_def {
u8 data_regs[3];
};
-static struct ak_def ak_def_array[AK_MAX_TYPE] = {
+static const struct ak_def ak_def_array[AK_MAX_TYPE] = {
{
.type = AK8975,
.raw_to_gauss = ak8975_raw_to_gauss,
@@ -360,7 +360,7 @@ static struct ak_def ak_def_array[AK_MAX_TYPE] = {
*/
struct ak8975_data {
struct i2c_client *client;
- struct ak_def *def;
+ const struct ak_def *def;
struct attribute_group attrs;
struct mutex lock;
u8 asa[3];
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] iio: ak8975: constify ak_def structures
2016-01-05 14:56 ` Julia Lawall
@ 2016-01-09 17:03 ` Jonathan Cameron
-1 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2016-01-09 17:03 UTC (permalink / raw)
To: Julia Lawall
Cc: kernel-janitors, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald, linux-iio, linux-kernel
On 05/01/16 14:56, Julia Lawall wrote:
> The ak_def structures are never modified, so declare them as const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
Applied, thanks.
Jonathan
> ---
> drivers/iio/magnetometer/ak8975.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/ak8975.c
> index b13936d..9c5c9ef 100644
> --- a/drivers/iio/magnetometer/ak8975.c
> +++ b/drivers/iio/magnetometer/ak8975.c
> @@ -252,7 +252,7 @@ struct ak_def {
> u8 data_regs[3];
> };
>
> -static struct ak_def ak_def_array[AK_MAX_TYPE] = {
> +static const struct ak_def ak_def_array[AK_MAX_TYPE] = {
> {
> .type = AK8975,
> .raw_to_gauss = ak8975_raw_to_gauss,
> @@ -360,7 +360,7 @@ static struct ak_def ak_def_array[AK_MAX_TYPE] = {
> */
> struct ak8975_data {
> struct i2c_client *client;
> - struct ak_def *def;
> + const struct ak_def *def;
> struct attribute_group attrs;
> struct mutex lock;
> u8 asa[3];
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] iio: ak8975: constify ak_def structures
@ 2016-01-09 17:03 ` Jonathan Cameron
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2016-01-09 17:03 UTC (permalink / raw)
To: Julia Lawall
Cc: kernel-janitors, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald, linux-iio, linux-kernel
On 05/01/16 14:56, Julia Lawall wrote:
> The ak_def structures are never modified, so declare them as const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
Applied, thanks.
Jonathan
> ---
> drivers/iio/magnetometer/ak8975.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/ak8975.c
> index b13936d..9c5c9ef 100644
> --- a/drivers/iio/magnetometer/ak8975.c
> +++ b/drivers/iio/magnetometer/ak8975.c
> @@ -252,7 +252,7 @@ struct ak_def {
> u8 data_regs[3];
> };
>
> -static struct ak_def ak_def_array[AK_MAX_TYPE] = {
> +static const struct ak_def ak_def_array[AK_MAX_TYPE] = {
> {
> .type = AK8975,
> .raw_to_gauss = ak8975_raw_to_gauss,
> @@ -360,7 +360,7 @@ static struct ak_def ak_def_array[AK_MAX_TYPE] = {
> */
> struct ak8975_data {
> struct i2c_client *client;
> - struct ak_def *def;
> + const struct ak_def *def;
> struct attribute_group attrs;
> struct mutex lock;
> u8 asa[3];
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-01-09 17:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-05 14:56 [PATCH] iio: ak8975: constify ak_def structures Julia Lawall
2016-01-05 14:56 ` Julia Lawall
2016-01-09 17:03 ` Jonathan Cameron
2016-01-09 17:03 ` Jonathan Cameron
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.