Re: [Qemu-arm] [PATCH v10 7/7] arm_mptimer: Convert to use ptimer

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Dmitry Osipenko <digetx@gmail.com>
To: QEMU Developers <qemu-devel@nongnu.org>, qemu-arm@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Peter Crosthwaite <crosthwaitepeter@gmail.com>
Subject: Re: [Qemu-arm] [PATCH v10 7/7] arm_mptimer: Convert to use ptimer
Date: Sun, 10 Jan 2016 21:12:52 +0300	[thread overview]
Message-ID: <56929F24.7090309@gmail.com> (raw)
In-Reply-To: <56929D6F.7010301@gmail.com>

10.01.2016 21:05, Dmitry Osipenko пишет:
> I missed case where periodic timer should stop in the following case:
>
> load = 0, counter != 0 -> run -> set counter = 0 -> should stop
>
> Test added. Will fix it in V11.
>

Forgot to mention that prescaler must be 0 in that case. Prescaler != 0 would 
result in unclearable IRQ while periodic timer is enabled and counter = load = 0.

-- 
Dmitry

WARNING: multiple messages have this Message-ID (diff)

From: Dmitry Osipenko <digetx@gmail.com>
To: QEMU Developers <qemu-devel@nongnu.org>, qemu-arm@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Peter Crosthwaite <crosthwaitepeter@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v10 7/7] arm_mptimer: Convert to use ptimer
Date: Sun, 10 Jan 2016 21:12:52 +0300	[thread overview]
Message-ID: <56929F24.7090309@gmail.com> (raw)
In-Reply-To: <56929D6F.7010301@gmail.com>

10.01.2016 21:05, Dmitry Osipenko пишет:
> I missed case where periodic timer should stop in the following case:
>
> load = 0, counter != 0 -> run -> set counter = 0 -> should stop
>
> Test added. Will fix it in V11.
>

Forgot to mention that prescaler must be 0 in that case. Prescaler != 0 would 
result in unclearable IRQ while periodic timer is enabled and counter = load = 0.

-- 
Dmitry

next prev parent reply	other threads:[~2016-01-10 18:13 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-09 17:39 [Qemu-devel] [PATCH v10 0/7] PTimer fixes/features and ARM MPTimer conversion Dmitry Osipenko
2016-01-09 17:39 ` [Qemu-devel] [PATCH v10 1/7] hw/ptimer: Fix issues caused by the adjusted timer limit value Dmitry Osipenko
2016-01-10  0:28   ` [Qemu-arm] " Peter Crosthwaite
2016-01-10  0:28     ` [Qemu-devel] " Peter Crosthwaite
2016-01-09 17:39 ` [Qemu-devel] [PATCH v10 2/7] hw/ptimer: Perform tick and counter wrap around if timer already expired Dmitry Osipenko
2016-01-10  0:44   ` [Qemu-arm] " Peter Crosthwaite
2016-01-10  0:44     ` [Qemu-devel] " Peter Crosthwaite
2016-01-10 14:09     ` [Qemu-arm] " Dmitry Osipenko
2016-01-10 14:09       ` [Qemu-devel] " Dmitry Osipenko
2016-01-20 17:03     ` [Qemu-arm] " Dmitry Osipenko
2016-01-20 17:03       ` [Qemu-devel] " Dmitry Osipenko
2016-01-20 17:22       ` Dmitry Osipenko
2016-01-09 17:39 ` [Qemu-devel] [PATCH v10 3/7] hw/ptimer: Update .delta on period/freq change Dmitry Osipenko
2016-01-09 17:39 ` [Qemu-arm] [PATCH v10 4/7] hw/ptimer: Support "on the fly" timer mode switch Dmitry Osipenko
2016-01-09 17:39   ` [Qemu-devel] " Dmitry Osipenko
2016-01-10  0:50   ` [Qemu-arm] " Peter Crosthwaite
2016-01-10  0:50     ` [Qemu-devel] " Peter Crosthwaite
2016-01-09 17:39 ` [Qemu-devel] [PATCH v10 5/7] hw/ptimer: Legalize running with delta = load = 0 Dmitry Osipenko
2016-01-12  3:58   ` [Qemu-arm] " Peter Crosthwaite
2016-01-12  3:58     ` [Qemu-devel] " Peter Crosthwaite
2016-01-12 18:12     ` [Qemu-arm] " Dmitry Osipenko
2016-01-12 18:12       ` [Qemu-devel] " Dmitry Osipenko
2016-01-15 18:10       ` [Qemu-arm] " Dmitry Osipenko
2016-01-15 18:10         ` [Qemu-devel] " Dmitry Osipenko
2016-01-20  0:50       ` [Qemu-arm] " Dmitry Osipenko
2016-01-20  0:50         ` [Qemu-devel] " Dmitry Osipenko
2016-01-09 17:39 ` [Qemu-arm] [PATCH v10 6/7] hw/ptimer: Introduce ptimer_get_limit Dmitry Osipenko
2016-01-09 17:39   ` [Qemu-devel] " Dmitry Osipenko
2016-01-12  3:59   ` Peter Crosthwaite
2016-01-09 17:39 ` [Qemu-arm] [PATCH v10 7/7] arm_mptimer: Convert to use ptimer Dmitry Osipenko
2016-01-09 17:39   ` [Qemu-devel] " Dmitry Osipenko
2016-01-10 18:05   ` [Qemu-arm] " Dmitry Osipenko
2016-01-10 18:05     ` [Qemu-devel] " Dmitry Osipenko
2016-01-10 18:12     ` Dmitry Osipenko [this message]
2016-01-10 18:12       ` Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56929F24.7090309@gmail.com \
    --to=digetx@gmail.com \
    --cc=crosthwaitepeter@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.