From: xuejiancheng <xuejiancheng@huawei.com>
To: Rob Herring <robh@kernel.org>
Cc: Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
<shijie.huang@intel.com>, <pengbinquan@huawei.com>,
<han.xu@freescale.com>,
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
Fabio Estevam <fabio.estevam@freescale.com>,
Joachim Eastwood <manabian@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
<yanhaifeng@hisilicon.com>, <yanghongwei@hisilicon.com>,
<suwenping@hisilicon.com>, <ml.yang@hisilicon.com>,
<gaofei@hisilicon.com>, <zhangzhenxing@hisilicon.com>,
<xuejiancheng@hisilicon.com>
Subject: Re: [PATCH v2] mtd: spi-nor: add hisilicon spi-nor flash controller driver
Date: Mon, 11 Jan 2016 11:53:38 +0800 [thread overview]
Message-ID: <56932742.5070105@huawei.com> (raw)
In-Reply-To: <CAL_Jsq+K-tF=snhq+w9yYQKmAxbxDSLq6cv5fLfWjHTgdJxQWQ@mail.gmail.com>
On 2016/1/11 11:09, Rob Herring wrote:
> On Sun, Jan 10, 2016 at 7:20 PM, xuejiancheng <xuejiancheng@huawei.com> wrote:
>> Hi Rob,
>>
>> On 2016/1/9 23:42, Rob Herring wrote:
>>> On Fri, Jan 08, 2016 at 09:26:45AM +0800, Jiancheng Xue wrote:
>>>> add hisilicon spi-nor flash controller driver
>>>>
>>>> Signed-off-by: Binquan Peng <pengbinquan@huawei.com>
>>>> Signed-off-by: Jiancheng Xue <xuejiancheng@huawei.com>
>>>> ---
>
>>>> +Required properties:
>>>> +- compatible : Should be "hisilicon,hisi-sfc".
>>>
>>> I missed this last time, but you also need a more specific compatible
>>> string with the SOC name in it.
>>>
>>
>> This IP block is used in many SOCs. Do I need to add a specific compatible
>> string for every SOC? Thank you.
>
> Yes. You can keep the generic one for driver matching, but you want to
> have the specific one in case there ever is a quirk/errata in a
> specific SOC.
>
I see. Thank you.
> Rob
>
> .
>
WARNING: multiple messages have this Message-ID (diff)
From: xuejiancheng <xuejiancheng-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Brian Norris
<computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
shijie.huang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
pengbinquan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
han.xu-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
Ezequiel Garcia
<ezequiel-30ULvvUtt6G51wMPkGsGjgyUoB5FGQPZ@public.gmane.org>,
Fabio Estevam
<fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
Joachim Eastwood
<manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
yanhaifeng-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org,
yanghongwei-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org,
suwenping-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org,
ml.yang-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org,
gaofei-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org,
zhangzhenxing-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org,
xuejiancheng-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org
Subject: Re: [PATCH v2] mtd: spi-nor: add hisilicon spi-nor flash controller driver
Date: Mon, 11 Jan 2016 11:53:38 +0800 [thread overview]
Message-ID: <56932742.5070105@huawei.com> (raw)
In-Reply-To: <CAL_Jsq+K-tF=snhq+w9yYQKmAxbxDSLq6cv5fLfWjHTgdJxQWQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 2016/1/11 11:09, Rob Herring wrote:
> On Sun, Jan 10, 2016 at 7:20 PM, xuejiancheng <xuejiancheng-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> wrote:
>> Hi Rob,
>>
>> On 2016/1/9 23:42, Rob Herring wrote:
>>> On Fri, Jan 08, 2016 at 09:26:45AM +0800, Jiancheng Xue wrote:
>>>> add hisilicon spi-nor flash controller driver
>>>>
>>>> Signed-off-by: Binquan Peng <pengbinquan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
>>>> Signed-off-by: Jiancheng Xue <xuejiancheng-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
>>>> ---
>
>>>> +Required properties:
>>>> +- compatible : Should be "hisilicon,hisi-sfc".
>>>
>>> I missed this last time, but you also need a more specific compatible
>>> string with the SOC name in it.
>>>
>>
>> This IP block is used in many SOCs. Do I need to add a specific compatible
>> string for every SOC? Thank you.
>
> Yes. You can keep the generic one for driver matching, but you want to
> have the specific one in case there ever is a quirk/errata in a
> specific SOC.
>
I see. Thank you.
> Rob
>
> .
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-01-11 4:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 1:26 [PATCH v2] mtd: spi-nor: add hisilicon spi-nor flash controller driver Jiancheng Xue
2016-01-08 1:26 ` Jiancheng Xue
2016-01-09 15:42 ` Rob Herring
2016-01-09 15:42 ` Rob Herring
2016-01-11 1:20 ` xuejiancheng
2016-01-11 1:20 ` xuejiancheng
2016-01-11 3:09 ` Rob Herring
2016-01-11 3:53 ` xuejiancheng [this message]
2016-01-11 3:53 ` xuejiancheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56932742.5070105@huawei.com \
--to=xuejiancheng@huawei.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=fabio.estevam@freescale.com \
--cc=galak@codeaurora.org \
--cc=gaofei@hisilicon.com \
--cc=han.xu@freescale.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=manabian@gmail.com \
--cc=mark.rutland@arm.com \
--cc=ml.yang@hisilicon.com \
--cc=pawel.moll@arm.com \
--cc=pengbinquan@huawei.com \
--cc=robh@kernel.org \
--cc=shijie.huang@intel.com \
--cc=suwenping@hisilicon.com \
--cc=xuejiancheng@hisilicon.com \
--cc=yanghongwei@hisilicon.com \
--cc=yanhaifeng@hisilicon.com \
--cc=zhangzhenxing@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.