From: Paolo Bonzini <pbonzini@redhat.com>
To: Ashley Jonathan <jonathan.ashley@altran.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>
Subject: Re: [Qemu-trivial] [PATCH] Keep pty slave file descriptor open until the master is closed
Date: Mon, 11 Jan 2016 10:16:12 +0100 [thread overview]
Message-ID: <569372DC.5020606@redhat.com> (raw)
In-Reply-To: <AC19797808C8D548ABDE0CA4A97AA30A30DEB409@XMB-DCFR-37.europe.corp.altran.com>
On 11/12/2015 12:29, Ashley Jonathan wrote:
> I have experienced a minor difficulty using QEMU with the "-serial
> pty" option:
>
> If a process opens the slave pts device, writes data to it, then
> immediately closes it, the data doesn't reliably get delivered to the
> emulated serial port. This seems to be because a read of the master
> pty device returns EIO on Linux if no process has the pts device
> open, even when data is waiting "in the pipe".
>
> A fix seems to be for QEMU to keep the pts file descriptor open until
> the pty is closed, as per the below patch.
You need to include a "Signed-off-by: Ashley Jonathan <jonathan.ashley@altran.com>"
line in the commit message, meaning that you have read and understood the
"Developer Certificate of Origin":
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches?id=f6f94e2ab1b33f0082ac22d71f66385a60d8157f#n297
Just reply to this message with the above line.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Ashley Jonathan <jonathan.ashley@altran.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] Keep pty slave file descriptor open until the master is closed
Date: Mon, 11 Jan 2016 10:16:12 +0100 [thread overview]
Message-ID: <569372DC.5020606@redhat.com> (raw)
In-Reply-To: <AC19797808C8D548ABDE0CA4A97AA30A30DEB409@XMB-DCFR-37.europe.corp.altran.com>
On 11/12/2015 12:29, Ashley Jonathan wrote:
> I have experienced a minor difficulty using QEMU with the "-serial
> pty" option:
>
> If a process opens the slave pts device, writes data to it, then
> immediately closes it, the data doesn't reliably get delivered to the
> emulated serial port. This seems to be because a read of the master
> pty device returns EIO on Linux if no process has the pts device
> open, even when data is waiting "in the pipe".
>
> A fix seems to be for QEMU to keep the pts file descriptor open until
> the pty is closed, as per the below patch.
You need to include a "Signed-off-by: Ashley Jonathan <jonathan.ashley@altran.com>"
line in the commit message, meaning that you have read and understood the
"Developer Certificate of Origin":
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches?id=f6f94e2ab1b33f0082ac22d71f66385a60d8157f#n297
Just reply to this message with the above line.
Paolo
next prev parent reply other threads:[~2016-01-11 9:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 11:29 [Qemu-trivial] [PATCH] Keep pty slave file descriptor open until the master is closed Ashley Jonathan
2015-12-11 11:29 ` [Qemu-devel] " Ashley Jonathan
2016-01-11 8:33 ` [Qemu-trivial] " Michael Tokarev
2016-01-11 8:33 ` [Qemu-devel] " Michael Tokarev
2016-01-11 9:13 ` [Qemu-trivial] " Paolo Bonzini
2016-01-11 9:13 ` [Qemu-devel] " Paolo Bonzini
2016-02-12 2:29 ` [Qemu-trivial] " Marc-André Lureau
2016-02-12 2:29 ` Marc-André Lureau
2016-02-12 13:51 ` [Qemu-trivial] " Marc-André Lureau
2016-02-12 13:51 ` Marc-André Lureau
2016-01-11 9:16 ` Paolo Bonzini [this message]
2016-01-11 9:16 ` Paolo Bonzini
2016-01-11 9:29 ` [Qemu-trivial] " Ashley Jonathan
2016-01-11 9:29 ` [Qemu-devel] " Ashley Jonathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569372DC.5020606@redhat.com \
--to=pbonzini@redhat.com \
--cc=jonathan.ashley@altran.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.