From: Paolo Bonzini <pbonzini@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>,
Cao jin <caoj.fnst@cn.fujitsu.com>,
qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-trivial] [PATCH] PCI: add param check for api
Date: Mon, 11 Jan 2016 10:20:59 +0100 [thread overview]
Message-ID: <569373FB.7080505@redhat.com> (raw)
In-Reply-To: <5693688A.9030201@msgid.tls.msk.ru>
On 11/01/2016 09:32, Michael Tokarev wrote:
>> >
>> > + assert(size > 0);
>> > + assert(offset >= PCI_CONFIG_HEADER_SIZE || !offset);
>> > +
> I'd like to see some ACKs/Reviews for this one, in particular why
> size should be != 0.
In fact it should be >= 2, because two bytes are always written below:
config = pdev->config + offset;
config[PCI_CAP_LIST_ID] = cap_id;
config[PCI_CAP_LIST_NEXT] = pdev->config[PCI_CAPABILITY_LIST];
> Also either move offset assert to the below
> "else" clause or rewrite it to be offset == 0 instead if !offset :)
Good idea to move it below, or even to add
assert(offset >= PCI_CONFIG_HEADER_SIZE);
after the "if", before the "config" assignment.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>,
Cao jin <caoj.fnst@cn.fujitsu.com>,
qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH] PCI: add param check for api
Date: Mon, 11 Jan 2016 10:20:59 +0100 [thread overview]
Message-ID: <569373FB.7080505@redhat.com> (raw)
In-Reply-To: <5693688A.9030201@msgid.tls.msk.ru>
On 11/01/2016 09:32, Michael Tokarev wrote:
>> >
>> > + assert(size > 0);
>> > + assert(offset >= PCI_CONFIG_HEADER_SIZE || !offset);
>> > +
> I'd like to see some ACKs/Reviews for this one, in particular why
> size should be != 0.
In fact it should be >= 2, because two bytes are always written below:
config = pdev->config + offset;
config[PCI_CAP_LIST_ID] = cap_id;
config[PCI_CAP_LIST_NEXT] = pdev->config[PCI_CAPABILITY_LIST];
> Also either move offset assert to the below
> "else" clause or rewrite it to be offset == 0 instead if !offset :)
Good idea to move it below, or even to add
assert(offset >= PCI_CONFIG_HEADER_SIZE);
after the "if", before the "config" assignment.
Paolo
next prev parent reply other threads:[~2016-01-11 9:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-21 7:45 [Qemu-trivial] [PATCH] PCI: add param check for api Cao jin
2015-11-21 7:45 ` [Qemu-devel] " Cao jin
2016-01-11 8:32 ` [Qemu-trivial] " Michael Tokarev
2016-01-11 8:32 ` [Qemu-devel] " Michael Tokarev
2016-01-11 9:20 ` Paolo Bonzini [this message]
2016-01-11 9:20 ` Paolo Bonzini
2016-01-12 7:22 ` [Qemu-trivial] " Cao jin
2016-01-12 7:22 ` [Qemu-devel] " Cao jin
2016-01-12 12:04 ` [Qemu-trivial] " Paolo Bonzini
2016-01-12 12:04 ` [Qemu-devel] " Paolo Bonzini
2016-01-12 6:39 ` [Qemu-trivial] " Cao jin
2016-01-12 6:39 ` [Qemu-devel] " Cao jin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569373FB.7080505@redhat.com \
--to=pbonzini@redhat.com \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=mjt@tls.msk.ru \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.