From: Sudeep Holla <sudeep.holla@arm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Taku Izumi <izumi.taku@jp.fujitsu.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
tony.luck@intel.com, qiuxishi@huawei.com,
kamezawa.hiroyu@jp.fujitsu.com, mel@csn.ul.ie,
dave.hansen@intel.com, matt@codeblueprint.co.uk, arnd@arndb.de,
steve.capper@linaro.org
Subject: Re: [PATCH v4 2/2] mm/page_alloc.c: introduce kernelcore=mirror option
Date: Mon, 11 Jan 2016 09:56:20 +0000 [thread overview]
Message-ID: <56937C44.9040707@arm.com> (raw)
In-Reply-To: <20160108151223.a9b7e9099de69dbe6309d159@linux-foundation.org>
On 08/01/16 23:12, Andrew Morton wrote:
> On Fri, 8 Jan 2016 17:02:39 +0000 Sudeep Holla <sudeep.holla@arm.com> wrote:
>
>>> +
>>> + /*
>>> + * if not mirrored_kernelcore and ZONE_MOVABLE exists,
>>> + * range from zone_movable_pfn[nid] to end of each node
>>> + * should be ZONE_MOVABLE not ZONE_NORMAL. skip it.
>>> + */
>>> + if (!mirrored_kernelcore && zone_movable_pfn[nid])
>>> + if (zone == ZONE_NORMAL &&
>>> + pfn >= zone_movable_pfn[nid])
>>> + continue;
>>> +
>>
>> I tried this with today's -next, the above lines gave compilation error.
>> Moved them below into HAVE_MEMBLOCK_NODE_MAP and tested it on ARM64.
>> I don't see the previous backtraces. Let me know if that's correct or
>> you can post a version that compiles correctly and I can give a try.
>
> Thanks. I'll include the below and shall add your tested-by:, OK?
>
Yes this is the exact change I tested. Also I retested your latest patch
set with today's -next. So,
Tested-by: Sudeep Holla <sudeep.holla@arm.com>
--
Regards,
Sudeep
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla@arm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Taku Izumi <izumi.taku@jp.fujitsu.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
tony.luck@intel.com, qiuxishi@huawei.com,
kamezawa.hiroyu@jp.fujitsu.com, mel@csn.ul.ie,
dave.hansen@intel.com, matt@codeblueprint.co.uk, arnd@arndb.de,
steve.capper@linaro.org
Subject: Re: [PATCH v4 2/2] mm/page_alloc.c: introduce kernelcore=mirror option
Date: Mon, 11 Jan 2016 09:56:20 +0000 [thread overview]
Message-ID: <56937C44.9040707@arm.com> (raw)
In-Reply-To: <20160108151223.a9b7e9099de69dbe6309d159@linux-foundation.org>
On 08/01/16 23:12, Andrew Morton wrote:
> On Fri, 8 Jan 2016 17:02:39 +0000 Sudeep Holla <sudeep.holla@arm.com> wrote:
>
>>> +
>>> + /*
>>> + * if not mirrored_kernelcore and ZONE_MOVABLE exists,
>>> + * range from zone_movable_pfn[nid] to end of each node
>>> + * should be ZONE_MOVABLE not ZONE_NORMAL. skip it.
>>> + */
>>> + if (!mirrored_kernelcore && zone_movable_pfn[nid])
>>> + if (zone == ZONE_NORMAL &&
>>> + pfn >= zone_movable_pfn[nid])
>>> + continue;
>>> +
>>
>> I tried this with today's -next, the above lines gave compilation error.
>> Moved them below into HAVE_MEMBLOCK_NODE_MAP and tested it on ARM64.
>> I don't see the previous backtraces. Let me know if that's correct or
>> you can post a version that compiles correctly and I can give a try.
>
> Thanks. I'll include the below and shall add your tested-by:, OK?
>
Yes this is the exact change I tested. Also I retested your latest patch
set with today's -next. So,
Tested-by: Sudeep Holla <sudeep.holla@arm.com>
--
Regards,
Sudeep
next prev parent reply other threads:[~2016-01-11 9:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 8:25 [PATCH v4 0/2] mm: Introduce kernelcore=mirror option Taku Izumi
2016-01-08 8:25 ` Taku Izumi
2016-01-08 8:26 ` Taku Izumi
2016-01-08 8:26 ` Taku Izumi
2016-01-08 8:26 ` [PATCH v4 1/2] mm/page_alloc.c: calculate zone_start_pfn at zone_spanned_pages_in_node() Taku Izumi
2016-01-08 8:26 ` Taku Izumi
2016-01-08 8:26 ` [PATCH v4 2/2] mm/page_alloc.c: introduce kernelcore=mirror option Taku Izumi
2016-01-08 8:26 ` Taku Izumi
2016-01-08 17:02 ` Sudeep Holla
2016-01-08 17:02 ` Sudeep Holla
2016-01-08 23:12 ` Andrew Morton
2016-01-08 23:12 ` Andrew Morton
2016-01-11 9:56 ` Sudeep Holla [this message]
2016-01-11 9:56 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56937C44.9040707@arm.com \
--to=sudeep.holla@arm.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=dave.hansen@intel.com \
--cc=izumi.taku@jp.fujitsu.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matt@codeblueprint.co.uk \
--cc=mel@csn.ul.ie \
--cc=qiuxishi@huawei.com \
--cc=steve.capper@linaro.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.