From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Yoshihiro Kaneko <ykaneko0929@gmail.com>, linux-media@vger.kernel.org
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
linux-sh@vger.kernel.org
Subject: Re: [PATCH 3/3] media: soc_camera: rcar_vin: Add ARGB8888 caputre format support
Date: Mon, 11 Jan 2016 18:35:17 +0000 [thread overview]
Message-ID: <5693F5E5.3060109@cogentembedded.com> (raw)
In-Reply-To: <1452535211-4869-4-git-send-email-ykaneko0929@gmail.com>
Hello.
On 01/11/2016 09:00 PM, Yoshihiro Kaneko wrote:
> From: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
>
> This patch adds ARGB8888 capture format support for R-Car Gen3.
>
> Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> ---
> drivers/media/platform/soc_camera/rcar_vin.c | 21 +++++++++++++++++++--
> 1 file changed, 19 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/soc_camera/rcar_vin.c b/drivers/media/platform/soc_camera/rcar_vin.c
> index cccd859..afe27bb 100644
> --- a/drivers/media/platform/soc_camera/rcar_vin.c
> +++ b/drivers/media/platform/soc_camera/rcar_vin.c
[...]
> @@ -654,6 +654,14 @@ static int rcar_vin_setup(struct rcar_vin_priv *priv)
> dmr = VNDMR_EXRGB;
> break;
> }
> + case V4L2_PIX_FMT_ARGB32:
> + if (priv->chip = RCAR_GEN3)
> + dmr = VNDMR_EXRGB | VNDMR_DTMD_ARGB;
> + else {
Kernel coding style dictates using {} in all *if* branches if at least one
branch has them.
> + dev_err(icd->parent, "Not support format\n");
> + return -EINVAL;
> + }
> + break;
> default:
> dev_warn(icd->parent, "Invalid fourcc format (0x%x)\n",
> icd->current_fmt->host_fmt->fourcc);
[...]
MBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Yoshihiro Kaneko <ykaneko0929@gmail.com>, linux-media@vger.kernel.org
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
linux-sh@vger.kernel.org
Subject: Re: [PATCH 3/3] media: soc_camera: rcar_vin: Add ARGB8888 caputre format support
Date: Mon, 11 Jan 2016 21:35:17 +0300 [thread overview]
Message-ID: <5693F5E5.3060109@cogentembedded.com> (raw)
In-Reply-To: <1452535211-4869-4-git-send-email-ykaneko0929@gmail.com>
Hello.
On 01/11/2016 09:00 PM, Yoshihiro Kaneko wrote:
> From: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
>
> This patch adds ARGB8888 capture format support for R-Car Gen3.
>
> Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> ---
> drivers/media/platform/soc_camera/rcar_vin.c | 21 +++++++++++++++++++--
> 1 file changed, 19 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/soc_camera/rcar_vin.c b/drivers/media/platform/soc_camera/rcar_vin.c
> index cccd859..afe27bb 100644
> --- a/drivers/media/platform/soc_camera/rcar_vin.c
> +++ b/drivers/media/platform/soc_camera/rcar_vin.c
[...]
> @@ -654,6 +654,14 @@ static int rcar_vin_setup(struct rcar_vin_priv *priv)
> dmr = VNDMR_EXRGB;
> break;
> }
> + case V4L2_PIX_FMT_ARGB32:
> + if (priv->chip == RCAR_GEN3)
> + dmr = VNDMR_EXRGB | VNDMR_DTMD_ARGB;
> + else {
Kernel coding style dictates using {} in all *if* branches if at least one
branch has them.
> + dev_err(icd->parent, "Not support format\n");
> + return -EINVAL;
> + }
> + break;
> default:
> dev_warn(icd->parent, "Invalid fourcc format (0x%x)\n",
> icd->current_fmt->host_fmt->fourcc);
[...]
MBR, Sergei
next prev parent reply other threads:[~2016-01-11 18:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 18:00 [PATCH 0/3] media: soc_camera: rcar_vin: add rcar-gen3 support Yoshihiro Kaneko
2016-01-11 18:00 ` Yoshihiro Kaneko
2016-01-11 18:00 ` [PATCH 1/3] media: soc_camera: rcar_vin: Add rcar fallback compatibility string Yoshihiro Kaneko
2016-01-11 18:00 ` Yoshihiro Kaneko
2016-01-11 18:19 ` Geert Uytterhoeven
2016-01-11 18:19 ` Geert Uytterhoeven
2016-01-11 18:27 ` Yoshihiro Kaneko
2016-01-11 18:27 ` Yoshihiro Kaneko
2016-01-11 18:00 ` [PATCH 2/3] media: soc_camera: rcar_vin: Add R-Car Gen3 support Yoshihiro Kaneko
2016-01-11 18:00 ` Yoshihiro Kaneko
2016-01-11 18:00 ` [PATCH 3/3] media: soc_camera: rcar_vin: Add ARGB8888 caputre format support Yoshihiro Kaneko
2016-01-11 18:00 ` Yoshihiro Kaneko
2016-01-11 18:35 ` Sergei Shtylyov [this message]
2016-01-11 18:35 ` Sergei Shtylyov
2016-01-11 18:46 ` Yoshihiro Kaneko
2016-01-11 18:46 ` Yoshihiro Kaneko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5693F5E5.3060109@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=g.liakhovetski@gmx.de \
--cc=horms@verge.net.au \
--cc=linux-media@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=ykaneko0929@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.