From: Joao Pinto <Joao.Pinto@synopsys.com>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>,
Joao Pinto <Joao.Pinto@synopsys.com>, <helgaas@kernel.org>
Cc: <Vineet.Gupta1@synopsys.com>, <linux-pci@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-snps-arc@lists.infradead.org>,
<CARLOS.PALMINHA@synopsys.com>, <Alexey.Brodkin@synopsys.com>,
<robh+dt@kernel.org>, <pawel.moll@arm.com>,
<mark.rutland@arm.com>, <ijc+devicetree@hellion.org.uk>,
<galak@codeaurora.org>
Subject: Re: [PATCH v4 1/2] PCI support added to ARC
Date: Tue, 12 Jan 2016 09:55:27 +0000 [thread overview]
Message-ID: <5694CD8F.1060706@synopsys.com> (raw)
In-Reply-To: <569497AE.3030405@synopsys.com>
Hi Vineet,
On 1/12/2016 6:05 AM, Vineet Gupta wrote:
> On Monday 11 January 2016 10:54 PM, Joao Pinto wrote:
>> This patch adds PCI support to ARC and updates drivers/pci Makefile enabling
>> the ARC arch to use the generic PCI setup functions.
>>
>> Signed-off-by: Joao Pinto <jpinto@synopsys.com>
>
> BTW this patch has whitespace errors still - can you make sure they are not in the
> next version(s)
By executing checkpatch.pl no whitespaces were detected:
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#9:
This patch adds PCI support to ARC and updates drivers/pci Makefile enabling
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#132:
new file mode 100644
total: 0 errors, 2 warnings, 212 lines checked
0001-PCI-support-added-to-ARC.patch has style problems, please review.
>
> -Vineet
>
I am going to check your comments and make the necessary adjustments.
Thanks,
Joao
WARNING: multiple messages have this Message-ID (diff)
From: Joao.Pinto@synopsys.com (Joao Pinto)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH v4 1/2] PCI support added to ARC
Date: Tue, 12 Jan 2016 09:55:27 +0000 [thread overview]
Message-ID: <5694CD8F.1060706@synopsys.com> (raw)
In-Reply-To: <569497AE.3030405@synopsys.com>
Hi Vineet,
On 1/12/2016 6:05 AM, Vineet Gupta wrote:
> On Monday 11 January 2016 10:54 PM, Joao Pinto wrote:
>> This patch adds PCI support to ARC and updates drivers/pci Makefile enabling
>> the ARC arch to use the generic PCI setup functions.
>>
>> Signed-off-by: Joao Pinto <jpinto at synopsys.com>
>
> BTW this patch has whitespace errors still - can you make sure they are not in the
> next version(s)
By executing checkpatch.pl no whitespaces were detected:
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#9:
This patch adds PCI support to ARC and updates drivers/pci Makefile enabling
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#132:
new file mode 100644
total: 0 errors, 2 warnings, 212 lines checked
0001-PCI-support-added-to-ARC.patch has style problems, please review.
>
> -Vineet
>
I am going to check your comments and make the necessary adjustments.
Thanks,
Joao
next prev parent reply other threads:[~2016-01-12 9:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 17:24 [PATCH v4 0/2] adding PCI support to AXS10x Joao Pinto
2016-01-11 17:24 ` Joao Pinto
2016-01-11 17:24 ` [PATCH v4 1/2] PCI support added to ARC Joao Pinto
2016-01-11 17:24 ` Joao Pinto
2016-01-12 5:58 ` Vineet Gupta
2016-01-12 5:58 ` Vineet Gupta
2016-01-12 6:05 ` Vineet Gupta
2016-01-12 6:05 ` Vineet Gupta
2016-01-12 9:55 ` Joao Pinto [this message]
2016-01-12 9:55 ` Joao Pinto
2016-01-12 10:49 ` Vineet Gupta
2016-01-12 10:49 ` Vineet Gupta
2016-01-11 17:24 ` [PATCH v4 2/2] add new platform driver for PCI RC Joao Pinto
2016-01-11 17:24 ` Joao Pinto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5694CD8F.1060706@synopsys.com \
--to=joao.pinto@synopsys.com \
--cc=Alexey.Brodkin@synopsys.com \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=galak@codeaurora.org \
--cc=helgaas@kernel.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.